mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-10 12:12:39 -05:00
[Bug]: side-nav visual hierarchy #1174
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#1174
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MatissJanis on GitHub (Jun 26, 2024).
Verified issue does not already exist?
What happened?
The addition of the underline for account categories (introduced here https://github.com/actualbudget/actual/pull/2847) has created an issue: the visual hierarchy between accounts and top-level items has been broken.
Some potential solutions:
Where are you hosting Actual?
None
What browsers are you seeing the problem on?
No response
Operating System
None
@ParthJohri commented on GitHub (Jun 27, 2024):
Hi @MatissJanis , Thank you for the bug clarification, I have made the following changes (screenshot attached), pleasre let me know if any further changes need to be done. If everything looks good, then I will create the PR for it.
Modifications
Screenshots
Thank you!
@youngcw commented on GitHub (Jun 27, 2024):
I like the font size increase and the added capitalization. I do still like the underline though if there is a way to keep it and not make the All Accounts header get lost
@MatissJanis commented on GitHub (Jun 27, 2024):
Agreed with @youngcw on all things except the underline. IMO it stands out too much in the side-nav and thus creates unnecessary clutter.
We'll need a tie-breaker here on this topic :)
@ParthJohri commented on GitHub (Jun 27, 2024):
@MatissJanis @youngcw
How about this one?
@newtonfav commented on GitHub (Jun 27, 2024):
The dotted border doesn't look nice. Why not use a solid border with a very thin border-width? Additionally, remove the solid border for the All Accounts header and increase its font size.
@ParthJohri commented on GitHub (Jun 27, 2024):
@newtonfav Kind of like this?
@youngcw commented on GitHub (Jun 27, 2024):
thats pretty nice.
@ParthJohri commented on GitHub (Jun 27, 2024):
If the above looks good, I can create a PR for it, please let me know if there is any other change to be made.
@MatissJanis commented on GitHub (Jun 27, 2024):
"All accounts" is too large. None of these nav items should exceed in size the "Setting/Reports/etc" nav items.
How would it look in lightmode? I'm still on the fence for the underlines.
@ParthJohri commented on GitHub (Jun 27, 2024):
@MatissJanis
For example:-
All Accounts
For Account
Off Account
Screenshots for all the themes:-
Light Mode
Dark Mode
Midnight Mode
@Teprifer commented on GitHub (Jun 27, 2024):
Not sure about bullet points, the account names would also have to be indented a fair bit.
One idea put forward in discord was to only slightly indent the account names by 5px.
@MatissJanis commented on GitHub (Jun 28, 2024):
Of all the revisions: I liked best the 1st one and second-best was the last one.
Happy to go with either of those options if people still feel like the underline is a good idea for the UX.
@ParthJohri commented on GitHub (Jun 28, 2024):
@MatissJanis @youngcw @Teprifer @newtonfav
How does this look?
@MatissJanis commented on GitHub (Jul 1, 2024):
Comparatively I prefered the 1st version best. The horizontal indentation looks out of place.
@ParthJohri commented on GitHub (Jul 2, 2024):
Thank you @MatissJanis for your suggestions, if others agree then I can create the PR for it.
@youngcw commented on GitHub (Jul 3, 2024):
@ParthJohri Go ahead and make a PR we can keep discussing there if needed
@matt-fidd commented on GitHub (Feb 13, 2026):
@MatissJanis do you still stand by this? absolutely fine if you do, it's just been a while :)
@MatissJanis commented on GitHub (Feb 13, 2026):
Lets close this. We ca revisit when/if we redesign the sidenav.