github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[GH-ISSUE #5287] Add report options translations #116636

New Issue
Closed
opened 2026-06-11 10:07:10 -05:00 by GiteaMirror · 5 comments
GiteaMirror commented 2026-06-11 10:07:10 -05:00
Owner
Copy Link
Copy Source

Originally created by @matt-fidd on GitHub (Jul 4, 2025).
Original GitHub issue: https://github.com/actualbudget/actual/issues/5287

Originally assigned to: @Copilot on GitHub.

Some of the options for reports are currently hardcoded english strings, it would be good to be able to mark these for translation.

You can find these in https://github.com/actualbudget/actual/blob/80bb4ab299ea7cb80f486773564416cb3c2d4c33/packages/desktop-client/src/components/reports/ReportOptions.ts

Originally created by @matt-fidd on GitHub (Jul 4, 2025). Original GitHub issue: https://github.com/actualbudget/actual/issues/5287 Originally assigned to: @Copilot on GitHub. Some of the options for reports are currently hardcoded english strings, it would be good to be able to mark these for translation. You can find these in https://github.com/actualbudget/actual/blob/80bb4ab299ea7cb80f486773564416cb3c2d4c33/packages/desktop-client/src/components/reports/ReportOptions.ts
GiteaMirror added the tech debttranslations labels 2026-06-11 10:07:13 -05:00
GiteaMirror commented 2026-06-11 10:07:15 -05:00
Author
Owner
Copy Link
Copy Source

@MatissJanis commented on GitHub (Jun 2, 2026):

cc @matt-fidd is this done?

<!-- gh-comment-id:4607461285 --> @MatissJanis commented on GitHub (Jun 2, 2026): cc @matt-fidd is this done?
GiteaMirror commented 2026-06-11 10:07:16 -05:00
Author
Owner
Copy Link
Copy Source

@matt-fidd commented on GitHub (Jun 4, 2026):

It looks like jfdoming might have done some of these but the times don't quite line up.

https://github.com/actualbudget/actual/pull/4303

It was a while ago now, but I think I might have been referring to these which are keys in plain english with spaces in and are a bit of a smell

https://github.com/actualbudget/actual/blob/abeeca67deda771c07cfd554f76daabfe79b98a7/packages/desktop-client/src/components/reports/ReportOptions.ts#L19-L23

<!-- gh-comment-id:4622216398 --> @matt-fidd commented on GitHub (Jun 4, 2026): It looks like jfdoming might have done some of these but the times don't quite line up. https://github.com/actualbudget/actual/pull/4303 It was a while ago now, but I think I might have been referring to these which are keys in plain english with spaces in and are a bit of a smell https://github.com/actualbudget/actual/blob/abeeca67deda771c07cfd554f76daabfe79b98a7/packages/desktop-client/src/components/reports/ReportOptions.ts#L19-L23
GiteaMirror commented 2026-06-11 10:07:17 -05:00
Author
Owner
Copy Link
Copy Source

@MatissJanis commented on GitHub (Jun 4, 2026):

I think those are just badly made keys that we actually store in the DB, not actually translateable strings.

Here's one of the translations for example:
https://github.com/actualbudget/actual/blob/23da0016d2a1bf3f9c65ef423b7b8659d7e1162e/packages/desktop-client/src/components/reports/ReportOptions.ts#L150-L159

<!-- gh-comment-id:4625733403 --> @MatissJanis commented on GitHub (Jun 4, 2026): I think those are just badly made keys that we actually store in the DB, not actually translateable strings. Here's one of the translations for example: https://github.com/actualbudget/actual/blob/23da0016d2a1bf3f9c65ef423b7b8659d7e1162e/packages/desktop-client/src/components/reports/ReportOptions.ts#L150-L159
GiteaMirror commented 2026-06-11 10:07:23 -05:00
Author
Owner
Copy Link
Copy Source

@matt-fidd commented on GitHub (Jun 4, 2026):

I think I may have looked at a different copy at the time then (without the stuff jfdoming did). We can probably close this one.

<!-- gh-comment-id:4625756402 --> @matt-fidd commented on GitHub (Jun 4, 2026): I think I may have looked at a different copy at the time then (without the stuff jfdoming did). We can probably close this one.
GiteaMirror commented 2026-06-11 10:07:28 -05:00
Author
Owner
Copy Link
Copy Source

@MatissJanis commented on GitHub (Jun 4, 2026):

Yep, that's very likely. We previously did have a big push to translate everything, so I would expect most (if not all) things to be already translate-able. :)

<!-- gh-comment-id:4625765648 --> @MatissJanis commented on GitHub (Jun 4, 2026): Yep, that's very likely. We previously did have a big push to translate everything, so I would expect most (if not all) things to be already translate-able. :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels tech debt translations
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#116636