github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[Bug]: transactions table - select all not selecting schedules #1154

New Issue
Closed
opened 2026-02-28 19:33:54 -06:00 by GiteaMirror · 8 comments
GiteaMirror commented 2026-02-28 19:33:54 -06:00
Owner
Copy Link

Originally created by @MatissJanis on GitHub (Jun 16, 2024).

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Reproduction:

  1. open transactions table (that has schedules too)
  2. click the "select all" box
  3. notice only the transactions get selected - schedules are not selected

https://github.com/actualbudget/actual/assets/886567/8141fc53-8f85-4a46-9b8b-e1385ff46dbf

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

No response

Operating System

None

Originally created by @MatissJanis on GitHub (Jun 16, 2024). ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? Reproduction: 1. open transactions table (that has schedules too) 2. click the "select all" box 3. notice only the transactions get selected - schedules are not selected https://github.com/actualbudget/actual/assets/886567/8141fc53-8f85-4a46-9b8b-e1385ff46dbf ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? _No response_ ### Operating System None
GiteaMirror added the user interfacefeedback labels 2026-02-28 19:33:54 -06:00
GiteaMirror commented 2026-02-28 19:33:54 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Jun 16, 2024):

Looks like it doesn't select split-transaction parent transactions either.

Screenshot 2024-06-16 at 21 05 07
@MatissJanis commented on GitHub (Jun 16, 2024): Looks like it doesn't select split-transaction parent transactions either. <img width="1435" alt="Screenshot 2024-06-16 at 21 05 07" src="https://github.com/actualbudget/actual/assets/886567/ed5c319a-a9b0-43cf-a1df-32fa601ea05a">
GiteaMirror commented 2026-02-28 19:33:55 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jun 17, 2024):

This feels like the correct behavior to me. Schedules are different than regular transactions and if the split parent is included in the selection the amount calculations get messed up.

@youngcw commented on GitHub (Jun 17, 2024): This feels like the correct behavior to me. Schedules are different than regular transactions and if the split parent is included in the selection the amount calculations get messed up.
GiteaMirror commented 2026-02-28 19:33:55 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Jun 17, 2024):

Interesting perspective. From a usability POV I would expect a "select all" checkbox in the header to do what most other products do - to select all the entries within the table. Is there a good argument for why we should treat schedules differently?

if the split parent is included in the selection the amount calculations get messed up

IMO this is an unrelated problem. Even if you manually select the parent + children transactions - the calculations get messed up. It definitely should be addressed. But it's not really related to select-all functionality.

@MatissJanis commented on GitHub (Jun 17, 2024): Interesting perspective. From a usability POV I would expect a "select all" checkbox in the header to do what most other products do - to select all the entries within the table. Is there a good argument for why we should treat schedules differently? > if the split parent is included in the selection the amount calculations get messed up IMO this is an unrelated problem. Even if you manually select the parent + children transactions - the calculations get messed up. It definitely should be addressed. But it's not really related to select-all functionality.
GiteaMirror commented 2026-02-28 19:33:55 -06:00
Author
Owner
Copy Link

@dangrous commented on GitHub (Jun 18, 2024):

To be honest, I would lean towards @youngcw's perspective that - for me - this is the ideal behavior (I never want to include non-current stuff) but, I think overall I'd agree that select all should do what it says on the tin and select all. It'd definitely be worth thinking about some sort of "select real entries" though too in the future!

@dangrous commented on GitHub (Jun 18, 2024): To be honest, I would lean towards @youngcw's perspective that - for me - this is the ideal behavior (I never want to include non-current stuff) but, I think overall I'd agree that select all should do what it says on the tin and select all. It'd definitely be worth thinking about some sort of "select real entries" though too in the future!
GiteaMirror commented 2026-02-28 19:33:55 -06:00
Author
Owner
Copy Link

@youngcw commented on GitHub (Jun 20, 2024):

I don't have any issue with parents of splits being included in the select all, as long as the selected total is calculated right.

For the schedules, I don't think those should be considered transactions since they have yet to be added. They are in the table for reference purposes. Also, the bulk options are different for schedules than for regular transactions.

@youngcw commented on GitHub (Jun 20, 2024): I don't have any issue with parents of splits being included in the select all, as long as the selected total is calculated right. For the schedules, I don't think those should be considered transactions since they have yet to be added. They are in the table for reference purposes. Also, the bulk options are different for schedules than for regular transactions.
GiteaMirror commented 2026-02-28 19:33:56 -06:00
Author
Owner
Copy Link

@joel-jeremy commented on GitHub (Jun 27, 2024):

I would then to agree that the parent should not be selected specially with the recent change where the parent transaction is just going to be a shell of its children transactions (no payee, no category)

@joel-jeremy commented on GitHub (Jun 27, 2024): I would then to agree that the parent should not be selected specially with the recent change where the parent transaction is just going to be a shell of its children transactions (no payee, no category)
GiteaMirror commented 2026-02-28 19:33:56 -06:00
Author
Owner
Copy Link

@dangrous commented on GitHub (Jul 3, 2024):

So it sounds like the current behavior is the expected one then?

I feel like it looks a little weird to have the parents not selected, but it makes more sense that way. Maybe there's a visual cue if all child transactions are selected vs. not - that would be a separate issue though.

@dangrous commented on GitHub (Jul 3, 2024): So it sounds like the current behavior is the expected one then? I feel like it looks a little weird to have the parents not selected, but it makes more sense that way. Maybe there's a visual cue if all child transactions are selected vs. not - that would be a separate issue though.
GiteaMirror commented 2026-02-28 19:33:56 -06:00
Author
Owner
Copy Link

@MatissJanis commented on GitHub (Jul 7, 2024):

Yes, looks like the majority prefers to keep the status quo here. Lets do that :)

Closing the ticket as complete

@MatissJanis commented on GitHub (Jul 7, 2024): Yes, looks like the majority prefers to keep the status quo here. Lets do that :) Closing the ticket as complete
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label feedback user interface
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?