github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-05 22:52:20 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2738] [MERGED] Add crdt to the API package to fix types #11538

New Issue
Closed
opened 2026-04-10 21:03:02 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:03:02 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2738
Author: @twk3
Created: 5/11/2024
Status: ✅ Merged
Merged: 5/18/2024
Merged by: @twk3

Base: master ← Head: twk3/api-crdt-types

📝 Commits (4)

  • ac993e6 Add crdt to the API package to fix types
  • 86ebbdb Add release note
  • 280895e Merge remote-tracking branch 'origin/master' into twk3/api-crdt-types
  • 10a4f5b Cleanup yarn.lock merge

📊 Changes

4 files changed (+11 additions, -9 deletions)

View changed files

📝 packages/api/package.json (+1 -0)
📝 packages/loot-core/webpack/webpack.api.config.js (+1 -0)
➕ upcoming-release-notes/2738.md (+6 -0)
📝 yarn.lock (+3 -9)

📄 Description

  • This way we get the crdt types available to users when they use the api
    • Otherwise they may have gotten missing type errors from typescript regarding the server/sync code from loot-core.

Instead of adding crdt as a dependency, I did confirm we could generate just the crdt types and copy them into the api like we do for loot-core. But then we still get an error regarding the google-protobuf types missing. Which is fixed by adding google-protobuf to our api dependencies. Being that a dependency needed to be added to the api either way, I just did the crdt one for now (which includes the google-protobuf dependency)

I believe this is the final unblocker for shipping the types with the API in https://github.com/actualbudget/actual/pull/2559

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2738 **Author:** [@twk3](https://github.com/twk3) **Created:** 5/11/2024 **Status:** ✅ Merged **Merged:** 5/18/2024 **Merged by:** [@twk3](https://github.com/twk3) **Base:** `master` ← **Head:** `twk3/api-crdt-types` --- ### 📝 Commits (4) - [`ac993e6`](https://github.com/actualbudget/actual/commit/ac993e66021ba518016b74040b73a75bc7bd97f5) Add crdt to the API package to fix types - [`86ebbdb`](https://github.com/actualbudget/actual/commit/86ebbdb3a29fc3e03a2d51e1361c0e021d4b0aa2) Add release note - [`280895e`](https://github.com/actualbudget/actual/commit/280895e9f9af4b16cb34ad221b940f80558e1f61) Merge remote-tracking branch 'origin/master' into twk3/api-crdt-types - [`10a4f5b`](https://github.com/actualbudget/actual/commit/10a4f5becd0c939c74cdfbe91dc7490624bdd644) Cleanup yarn.lock merge ### 📊 Changes **4 files changed** (+11 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/package.json` (+1 -0) 📝 `packages/loot-core/webpack/webpack.api.config.js` (+1 -0) ➕ `upcoming-release-notes/2738.md` (+6 -0) 📝 `yarn.lock` (+3 -9) </details> ### 📄 Description - This way we get the crdt types available to users when they use the api * Otherwise they may have gotten missing type errors from typescript regarding the server/sync code from loot-core. Instead of adding crdt as a dependency, I did confirm we could generate just the crdt types and copy them into the api like we do for loot-core. But then we still get an error regarding the google-protobuf types missing. Which is fixed by adding google-protobuf to our api dependencies. Being that a dependency needed to be added to the api either way, I just did the crdt one for now (which includes the google-protobuf dependency) I believe this is the final unblocker for shipping the types with the API in https://github.com/actualbudget/actual/pull/2559 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 21:03:02 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11538
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?