github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 10:02:07 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7963] [MERGED] [AI] Remove AI-generated release notes workflow and support custom filenames #114319

New Issue
Closed
opened 2026-06-05 22:06:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-05 22:06:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7963
Author: @MatissJanis
Created: 5/26/2026
Status: ✅ Merged
Merged: 6/4/2026
Merged by: @MatissJanis

Base: master ← Head: claude/brave-darwin-vSvCV

📝 Commits (10+)

  • e5fbf5c [AI] Relax release-notes filename convention
  • 71243ac Add release notes for PR #7963
  • 81f8599 [AI] Use execFile to look up release-note add-commits
  • 36382f5 [AI] Drop duplicate release note added by the to-be-removed auto-creator
  • bfe05c5 [AI] Don't fail release-notes generation on transient API errors
  • 02440d0 [AI] Address CodeRabbit full-review nits
  • 63890b5 [AI] Reject empty release-note bodies
  • 5faee31 [AI] Merge master into claude/brave-darwin-vSvCV
  • 259f61e [AI] Resolve PR numbers from commit subjects instead of GitHub's API
  • 3af57e9 [AI] Pin PR-number lookup to each note's add commit

📊 Changes

16 files changed (+153 additions, -842 deletions)

View changed files

➖ .github/actions/ai-generated-release-notes/check-first-comment.js (+0 -76)
➖ .github/actions/ai-generated-release-notes/check-release-notes-exists.js (+0 -77)
➖ .github/actions/ai-generated-release-notes/comment-on-pr.js (+0 -77)
➖ .github/actions/ai-generated-release-notes/create-release-notes-file.js (+0 -138)
➖ .github/actions/ai-generated-release-notes/determine-category.js (+0 -118)
➖ .github/actions/ai-generated-release-notes/generate-summary.js (+0 -95)
➖ .github/actions/ai-generated-release-notes/pr-details.js (+0 -101)
📝 .github/actions/release-notes/check/action.yml (+1 -1)
➖ .github/workflows/ai-generated-release-notes.yml (+0 -94)
📝 bin/release-note-generator.ts (+22 -32)
📝 packages/ci-actions/bin/release-notes-check.mjs (+64 -26)
📝 packages/ci-actions/bin/release-notes-generate.mjs (+4 -0)
📝 packages/ci-actions/src/release-notes/util.mjs (+49 -4)
📝 packages/docs/docs/contributing/index.md (+2 -2)
📝 packages/docs/scripts/generate-upcoming-release-notes.mjs (+5 -1)
➕ upcoming-release-notes/relax-release-notes-filenames.md (+6 -0)

📄 Description

Description

Three factors contribute to the proposed change here:

  1. lelemm is no longer in the team (and he was the person who owned the OPENAPI keys & the release notes generator workflow)
  2. the release note generator workflow needs to use my PAT (which I would prefer to keep to a minimum if not fully removed from the codebase)
  3. we are getting increasingly more PRs from the community without a release notes in the first commit; thus we are wasting CI resources

The change: allow people to name the release notes files however they want. Any slug will be fine. We do the "notes" -> "number" matching when drafting the release.

Related issue(s)

N/A

Testing

N/A

Checklist

  • Release notes added (see link above)
  • No obvious regressions in affected areas
  • Self-review has been performed - I understand what each change in the code does and why it is needed

https://claude.ai/code/session_01TctqXAZZq3ueevMhgaZ2m5

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7963 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 5/26/2026 **Status:** ✅ Merged **Merged:** 6/4/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/brave-darwin-vSvCV` --- ### 📝 Commits (10+) - [`e5fbf5c`](https://github.com/actualbudget/actual/commit/e5fbf5cdec1fbfd6199f7801e39cd485f6a6f391) [AI] Relax release-notes filename convention - [`71243ac`](https://github.com/actualbudget/actual/commit/71243ac0da7cedd3c37c5d9b0c0a271f9a9d3ea5) Add release notes for PR #7963 - [`81f8599`](https://github.com/actualbudget/actual/commit/81f8599cb08c1afcc16c52b002652e067a80ae7c) [AI] Use execFile to look up release-note add-commits - [`36382f5`](https://github.com/actualbudget/actual/commit/36382f5ac8a8cc484c9c8bfb1b1aa45c963434e3) [AI] Drop duplicate release note added by the to-be-removed auto-creator - [`bfe05c5`](https://github.com/actualbudget/actual/commit/bfe05c5d98e4a6d9caa9fe4b3cb3d7716cd15a79) [AI] Don't fail release-notes generation on transient API errors - [`02440d0`](https://github.com/actualbudget/actual/commit/02440d0aa8e5f0ddf62b4233df022b22eddd1410) [AI] Address CodeRabbit full-review nits - [`63890b5`](https://github.com/actualbudget/actual/commit/63890b523862acfcdad88414f1babf779b438c3a) [AI] Reject empty release-note bodies - [`5faee31`](https://github.com/actualbudget/actual/commit/5faee3120e4a56c7889b816002b8a73ad05a57af) [AI] Merge master into claude/brave-darwin-vSvCV - [`259f61e`](https://github.com/actualbudget/actual/commit/259f61e351704aa8ba3cadb965cb1eb318497a3d) [AI] Resolve PR numbers from commit subjects instead of GitHub's API - [`3af57e9`](https://github.com/actualbudget/actual/commit/3af57e9a2f5f0fe0e2ffc4238768de11292838a2) [AI] Pin PR-number lookup to each note's add commit ### 📊 Changes **16 files changed** (+153 additions, -842 deletions) <details> <summary>View changed files</summary> ➖ `.github/actions/ai-generated-release-notes/check-first-comment.js` (+0 -76) ➖ `.github/actions/ai-generated-release-notes/check-release-notes-exists.js` (+0 -77) ➖ `.github/actions/ai-generated-release-notes/comment-on-pr.js` (+0 -77) ➖ `.github/actions/ai-generated-release-notes/create-release-notes-file.js` (+0 -138) ➖ `.github/actions/ai-generated-release-notes/determine-category.js` (+0 -118) ➖ `.github/actions/ai-generated-release-notes/generate-summary.js` (+0 -95) ➖ `.github/actions/ai-generated-release-notes/pr-details.js` (+0 -101) 📝 `.github/actions/release-notes/check/action.yml` (+1 -1) ➖ `.github/workflows/ai-generated-release-notes.yml` (+0 -94) 📝 `bin/release-note-generator.ts` (+22 -32) 📝 `packages/ci-actions/bin/release-notes-check.mjs` (+64 -26) 📝 `packages/ci-actions/bin/release-notes-generate.mjs` (+4 -0) 📝 `packages/ci-actions/src/release-notes/util.mjs` (+49 -4) 📝 `packages/docs/docs/contributing/index.md` (+2 -2) 📝 `packages/docs/scripts/generate-upcoming-release-notes.mjs` (+5 -1) ➕ `upcoming-release-notes/relax-release-notes-filenames.md` (+6 -0) </details> ### 📄 Description ## Description Three factors contribute to the proposed change here: 1. lelemm is no longer in the team (and he was the person who owned the OPENAPI keys & the release notes generator workflow) 2. the release note generator workflow needs to use my PAT (which I would prefer to keep to a minimum if not fully removed from the codebase) 3. we are getting increasingly more PRs from the community without a release notes in the first commit; thus we are wasting CI resources The change: allow people to name the release notes files however they want. Any slug will be fine. We do the "notes" -> "number" matching when drafting the release. ## Related issue(s) N/A ## Testing N/A ## Checklist - [x] Release notes added (see link above) - [x] No obvious regressions in affected areas - [x] Self-review has been performed - I understand what each change in the code does and why it is needed https://claude.ai/code/session_01TctqXAZZq3ueevMhgaZ2m5 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-05 22:06:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#114319
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?