github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2570] [MERGED] [Bugfix] Remove menu from income group on mobile view #11430

New Issue
Closed
opened 2026-04-10 21:00:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 21:00:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2570
Author: @shall0pass
Created: 4/8/2024
Status: ✅ Merged
Merged: 4/9/2024
Merged by: @shall0pass

Base: master ← Head: income_menu_crash

📝 Commits (2)

📊 Changes

2 files changed (+63 additions, -53 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx (+57 -53)
➕ upcoming-release-notes/2570.md (+6 -0)

📄 Description

Fixes https://github.com/actualbudget/actual/issues/2565

After looking at the menu options on the desktop view and comparing them to the mobile view, there is not currently a need to show a menu option in the mobile view. Selecting the option resulted in a crash. The desktop view has options to rename and create categories; however, the mobile view already uses a different method to accomplish those tasks. The remaining option of Show/Hide the Income group category has no effect on the desktop view and thus doesn't really need to be displayed in Mobile view to replicate the functionality. This PR simply hides the menu option if, and only if, the Income Group is selected. All other groups and categories are unaffected.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2570 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 4/8/2024 **Status:** ✅ Merged **Merged:** 4/9/2024 **Merged by:** [@shall0pass](https://github.com/shall0pass) **Base:** `master` ← **Head:** `income_menu_crash` --- ### 📝 Commits (2) - [`c0c184b`](https://github.com/actualbudget/actual/commit/c0c184b2a4d50326819fe97b2f4df01c2137fead) remove menu option from Income group - [`c2a2bd0`](https://github.com/actualbudget/actual/commit/c2a2bd0062e05e0fb5ef2e5e111c3a56eeb0e015) note ### 📊 Changes **2 files changed** (+63 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx` (+57 -53) ➕ `upcoming-release-notes/2570.md` (+6 -0) </details> ### 📄 Description Fixes https://github.com/actualbudget/actual/issues/2565 After looking at the menu options on the desktop view and comparing them to the mobile view, there is not currently a need to show a menu option in the mobile view. Selecting the option resulted in a crash. The desktop view has options to rename and create categories; however, the mobile view already uses a different method to accomplish those tasks. The remaining option of Show/Hide the Income group category has no effect on the desktop view and thus doesn't really need to be displayed in Mobile view to replicate the functionality. This PR simply hides the menu option if, and only if, the Income Group is selected. All other groups and categories are unaffected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 21:00:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11430
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?