github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2362] [MERGED] Added Header Authentication - Client Part #11325

New Issue
Closed
opened 2026-04-10 20:58:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:58:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2362
Author: @joewashear007
Created: 2/15/2024
Status: ✅ Merged
Merged: 5/4/2024
Merged by: @twk3

Base: master ← Head: master

📝 Commits (10+)

📊 Changes

6 files changed (+113 additions, -32 deletions)

View changed files

📝 packages/desktop-client/src/components/manager/ManagementApp.jsx (+1 -1)
📝 packages/desktop-client/src/components/manager/subscribe/Login.tsx (+85 -24)
📝 packages/desktop-client/src/components/manager/subscribe/common.tsx (+7 -4)
📝 packages/loot-core/src/server/main.ts (+10 -2)
📝 packages/loot-core/src/types/server-handlers.d.ts (+4 -1)
➕ upcoming-release-notes/2362.md (+6 -0)

📄 Description

Client Side modifications for https://github.com/actualbudget/actual-server/pull/312 for https://github.com/actualbudget/actual/issues/1092

This change added the check for the "loginMethod" from the /account/use-bootstrap endpoint. It will then adjust the login page to automatically call the login endpoint if the loginMethod == "header".

I was having trouble getting this built and tested, so I would appreciate pointers or testing tips.

Thanks!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2362 **Author:** [@joewashear007](https://github.com/joewashear007) **Created:** 2/15/2024 **Status:** ✅ Merged **Merged:** 5/4/2024 **Merged by:** [@twk3](https://github.com/twk3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`271842e`](https://github.com/actualbudget/actual/commit/271842e71ebfbd5686251bb28643546a5ca2a4a8) Updated Login to handle header auth - [`6afaf6c`](https://github.com/actualbudget/actual/commit/6afaf6c2c210c18c71c68daaa1038c62d084e2af) Added release notes - [`0fb4c40`](https://github.com/actualbudget/actual/commit/0fb4c40bc4204037ecb21bd54f4269746e958d81) Fixes from testing - [`3e82c40`](https://github.com/actualbudget/actual/commit/3e82c40bd0f026e9831a36aaf10d5f455bc42718) Added loginMethod to subscribe-sign-in event - [`a24c9af`](https://github.com/actualbudget/actual/commit/a24c9af95e597b5972af54216157c46e45d89855) Using routes for login method - [`787130d`](https://github.com/actualbudget/actual/commit/787130da35efd3cbdddda158a2005811656a14ba) Updated Lint Fixes - [`8971fd4`](https://github.com/actualbudget/actual/commit/8971fd48db5ffb64e62f8c7e4638b2e61d421c7b) Updated Lint Fixes - [`10a751c`](https://github.com/actualbudget/actual/commit/10a751c2cd5432feac92cfeb4d8981bd963b339b) Updated release notes - [`7d9184e`](https://github.com/actualbudget/actual/commit/7d9184ec8f62b248384dd983c5c88c9d154d3b12) Updated release notes - [`d29f268`](https://github.com/actualbudget/actual/commit/d29f2684b091394264545b3ff18c62264a7683c2) Updated Lint Fixes ### 📊 Changes **6 files changed** (+113 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/manager/ManagementApp.jsx` (+1 -1) 📝 `packages/desktop-client/src/components/manager/subscribe/Login.tsx` (+85 -24) 📝 `packages/desktop-client/src/components/manager/subscribe/common.tsx` (+7 -4) 📝 `packages/loot-core/src/server/main.ts` (+10 -2) 📝 `packages/loot-core/src/types/server-handlers.d.ts` (+4 -1) ➕ `upcoming-release-notes/2362.md` (+6 -0) </details> ### 📄 Description Client Side modifications for https://github.com/actualbudget/actual-server/pull/312 for https://github.com/actualbudget/actual/issues/1092 This change added the check for the "loginMethod" from the `/account/use-bootstrap` endpoint. It will then adjust the login page to automatically call the login endpoint if the loginMethod == "header". I was having trouble getting this built and tested, so I would appreciate pointers or testing tips. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:58:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11325
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?