github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-22 00:13:45 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

Update or remove jwl-dev-utils #113

New Issue
Closed
opened 2026-02-28 18:48:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-02-28 18:48:53 -06:00
Owner
Copy Link

Originally created by @TomAFrench on GitHub (Jul 8, 2022).

I've been looking at how to update various packages so we can increase the stability of the build process and support TS but the dependency which is causing troubles with this is jwl-dev-utils. This seems to be a fork of react-dev-utils which is maintained by @jlongster.

In order to update the codebase to use TS we need a TS compatible linter (#110), swapping out babel for tslint's parser as otherwise the linter will error on any .ts files.

The issue with this however is we need to update eslint as we're using a version released in 2018 whereas v1.0.0 of typescript-eslint was released in 2019. Updating eslint causes incompatibilities with eslint-loader, and in turn updating that causes incompatibilities with jwl-dev-utils.

jwl-dev-utils has had a number of patches applied relative to react-dev-utils (but these patches don't seem to have been pushed to github). This means that it's hard to know exactly what code is running and how it's different from react-dev-utils. Not knowing how the code differs from react-dev-utils makes it difficult to easily rollback to the official version of react-dev-utils so we can start migrating forwards to more recent versions (builds start failing when replacing it with the most similar version of react-dev-utils).

@jlongster could you publish what these changes are and potentially help with updating these dependencies as this seems to be a blocker for many priorities and there's info about this which only you can provide?

Originally created by @TomAFrench on GitHub (Jul 8, 2022). I've been looking at how to update various packages so we can increase the stability of the build process and support TS but the dependency which is causing troubles with this is `jwl-dev-utils`. This seems to be a fork of `react-dev-utils` which is maintained by @jlongster. In order to update the codebase to use TS we need a TS compatible linter (#110), swapping out babel for tslint's parser as otherwise the linter will error on any .ts files. The issue with this however is we need to update eslint as we're using a version released in 2018 whereas [v1.0.0 of typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/releases/tag/v1.0.0) was released in 2019. Updating `eslint` causes incompatibilities with `eslint-loader`, and in turn updating that causes incompatibilities with `jwl-dev-utils`. `jwl-dev-utils` has had a number of patches applied relative to `react-dev-utils` (but these patches don't seem to have been pushed to github). This means that it's hard to know exactly what code is running and how it's different from `react-dev-utils`. Not knowing how the code differs from `react-dev-utils` makes it difficult to easily rollback to the official version of `react-dev-utils` so we can start migrating forwards to more recent versions (builds start failing when replacing it with the most similar version of `react-dev-utils`). @jlongster could you publish what these changes are and potentially help with updating these dependencies as this seems to be a blocker for many priorities and there's info about this which only you can provide?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#113
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?