github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2101] [MERGED] (ESLint) Enforce filename extensions for jsx #11173

New Issue
Closed
opened 2026-04-10 20:53:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:53:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2101
Author: @twk3
Created: 12/18/2023
Status: ✅ Merged
Merged: 12/18/2023
Merged by: @MatissJanis

Base: master ← Head: eslint-jsx-extensions

📝 Commits (2)

  • 4e49041 (ESLint) Enforce filename extensions for jsx
  • c49ac22 Add relese note

📊 Changes

70 files changed (+11 additions, -3 deletions)

View changed files

📝 .eslintrc.js (+5 -3)
📝 packages/desktop-client/src/components/GlobalKeys.ts (+0 -0)
📝 packages/desktop-client/src/components/SyncRefresh.ts (+0 -0)
📝 packages/desktop-client/src/components/accounts/Account.jsx (+0 -0)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx (+0 -0)
📝 packages/desktop-client/src/components/accounts/Balance.jsx (+0 -0)
📝 packages/desktop-client/src/components/accounts/Header.jsx (+0 -0)
📝 packages/desktop-client/src/components/accounts/MobileAccount.jsx (+0 -0)
📝 packages/desktop-client/src/components/accounts/MobileAccountDetails.jsx (+0 -0)
📝 packages/desktop-client/src/components/accounts/MobileAccounts.jsx (+0 -0)
📝 packages/desktop-client/src/components/accounts/Reconcile.jsx (+0 -0)
📝 packages/desktop-client/src/components/budget/BudgetCategories.jsx (+0 -0)
📝 packages/desktop-client/src/components/budget/BudgetTable.jsx (+0 -0)
📝 packages/desktop-client/src/components/budget/MobileBudget.jsx (+0 -0)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.jsx (+0 -0)
📝 packages/desktop-client/src/components/common/InitialFocus.ts (+0 -0)
📝 packages/desktop-client/src/components/filters/FiltersMenu.jsx (+0 -0)
📝 packages/desktop-client/src/components/filters/SavedFilters.jsx (+0 -0)
📝 packages/desktop-client/src/components/manager/BudgetList.jsx (+0 -0)
📝 packages/desktop-client/src/components/manager/DeleteFile.jsx (+0 -0)

...and 50 more files

📄 Description

  • JSX content must use .jsx or .tsx here
  • Files that don't contain JSX can't use those two extensions

In preparation for considering moving to vite, which requires JSX content to be in one of these file extensions.

Currently this MR is also removing the x from files that don't contain JSX, (and enforcing that via eslint as well), but that is optional and not required for moving to vite. (Just seemed logical to me).

The eslint file contains the only content changes, everything else is just extension renames.

Split out of https://github.com/actualbudget/actual/pull/2084

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2101 **Author:** [@twk3](https://github.com/twk3) **Created:** 12/18/2023 **Status:** ✅ Merged **Merged:** 12/18/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `eslint-jsx-extensions` --- ### 📝 Commits (2) - [`4e49041`](https://github.com/actualbudget/actual/commit/4e4904105a69f9151eefa526f2577fc935bcf187) (ESLint) Enforce filename extensions for jsx - [`c49ac22`](https://github.com/actualbudget/actual/commit/c49ac220274e84b9d8bad508fa0ccd6a5f76ae2d) Add relese note ### 📊 Changes **70 files changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+5 -3) 📝 `packages/desktop-client/src/components/GlobalKeys.ts` (+0 -0) 📝 `packages/desktop-client/src/components/SyncRefresh.ts` (+0 -0) 📝 `packages/desktop-client/src/components/accounts/Account.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/accounts/Balance.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/accounts/Header.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/accounts/MobileAccount.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/accounts/MobileAccountDetails.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/accounts/MobileAccounts.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/accounts/Reconcile.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/budget/BudgetCategories.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/budget/BudgetTable.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/budget/MobileBudget.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/common/InitialFocus.ts` (+0 -0) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/filters/SavedFilters.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/manager/BudgetList.jsx` (+0 -0) 📝 `packages/desktop-client/src/components/manager/DeleteFile.jsx` (+0 -0) _...and 50 more files_ </details> ### 📄 Description - JSX content must use .jsx or .tsx here - Files that don't contain JSX can't use those two extensions In preparation for considering moving to vite, which requires JSX content to be in one of these file extensions. Currently this MR is also removing the x from files that don't contain JSX, (and enforcing that via eslint as well), but that is optional and not required for moving to vite. (Just seemed logical to me). The eslint file contains the only content changes, everything else is just extension renames. Split out of https://github.com/actualbudget/actual/pull/2084 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:53:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11173
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?