mirror of
https://github.com/actualbudget/actual.git
synced 2026-11-16 14:56:16 -06:00
[PR #3274] [CLOSED] [WIP] Fix mobile transaction form requires additional click to unfocus amount input #111582
Closed
opened 2026-06-05 16:11:12 -05:00 by GiteaMirror
·
0 comments
No Branch/Tag Specified
master
matiss/enable-banking-pending-and-rate-limit
claude/lucid-turing-br8zwl
jfdoming/api-key-shared-bank-sync
worktree-pr-description-rules
ios-ci-launch-test
theme-number-contrast
theme-contrast-test
fix/automatic-bank-sync-mobile-app
future-buffer
carryover-chain
copilot/fix-failing-github-actions-job
copilot/fix-failing-github-actions-job-compare
fix/hide-sab-warning-in-capacitor
release
tabedzki/feat/docker-non-root
ios-home-screen-widgets
mobile-budget-redesign
ai/fix-mobile-carryover-arrow-alignment
jfdoming/provider-identity-update
jfdoming/electron-signin-update
jfdoming/openid-flow-update
release-update/26.10.1
release-notes/26.10.1
matiss/dazzling-babbage-b9rjwi
react-query-rules
ai/add-loan-formula-autocomplete
claude/pr-8519-regression-testing-fhvrrh
speed-up-transaction-list-and-schedules
fix-slow-balance-recompute-on-transaction-edit
jfdoming/opfs-sahpool-mobile
jfdoming/opfs-sahpool
fix-8612-schedule-delete-menu
jfdoming/api-tokens-part-8
jfdoming/api-tokens-part-7
jfdoming/api-tokens-part-6
jfdoming/api-tokens-part-5
jfdoming/mobile-safe-area-header
jfdoming/api-tokens-part-4
jfdoming/mobile-splash-lifecycle
jfdoming/api-tokens-part-3
jfdoming/mobile-shared-array-buffer
jfdoming/api-tokens-part-2
jfdoming/api-tokens-part-1
persist-transaction-filters
claude/modernize-transactions-tanstack-orgrze
bank-sync-per-file-03-pluggy-loot-core
claude/auto-close-prs-no-profile-pic-mjqpsy
cross-version-sync-stage2
claude/react-table-library-research-afx83z
tolerate-newer-migrations
claude/verify-migration-guardrails-i82c8m
tabedzki/feat/replacing-month-picker-with-day-picker
delay-initial-sync-until-loaded
cross-version-sync-compat
jfdoming/mobile-app-updates
claude/budget-version-migration-compat-151jlr
claude/worker-error-serialization-9iqtl7
claude/issue-8401-regression-test-9nw9l3
jfdoming/mobile-app-foundation-part-1
jfdoming/mobile-app-scaffold
ai-fix-cleanup-def-8290
claude/relaxed-shannon-jusywa
claude/fervent-keller-s6f2fq
claude/determined-feynman-st1y9z
claude/wizardly-einstein-vi2wce
claude/sweet-albattani-7nseio
feat/bank-sync-per-budget-file
claude/affectionate-cannon-y0kc82
claude/dependabot-findings-m9pgmb
claude/mac-app-ios-publish-zjs1lz
claude/vigilant-tesla-aiiyos
claude/quirky-cerf-v5qck7
claude/animation-removal-alternative-2etfh1
claude/netlify-preview-comments-consolidate-9XPYa
osc/7391-error-boundaries-reports
claude/pensive-dijkstra-7DYui
claude/server-app-version-mismatch-HTCGv
claude/pr-8027-review-feedback-mELuO
claude/zealous-wozniak-e5pO0
claude/intelligent-heisenberg-BSHJq
claude/translation-download-refactor-jFRsO
claude/mobile-performance-ideas-G9PAO
claude/github-issue-7988-5A5ly
blacksmith-migration-ff70d2d
claude/great-mayer-KRvOk
claude/react-native-ios-compilation-fcJh5
claude/serene-goldberg-58xv0
claude/kind-euler-LVG3K
release-automation/edge-nightly
7710-bundle-migrations
claude/fix-docker-build-error-WMfed
claude/llm-compatible-release-notes-t20Nr
7710-tests-tdd
cursor/transaction-table-rewrite-f077
claude/plan-ci-secure-context-OtEe1
claude/fix-issue-7667-DPXi3
cursor/resolve-pr-7449-ee11
claude/fix-typescript-build-error-JPtZ5
copilot/add-repository-configs-to-packages
worktree-compressed-drifting-ritchie
claude/api-consumer-verification-kfz1K
pr-7454
claude/fix-issue-7410-LLLQ4
revert-7281-generate-icons
react-query-useSchedules
copilot/sub-pr-6140
package-upgrades
v26.11.0
v26.10.0
v26.9.0
v26.8.1
v26.8.0
v26.7.0
v26.6.0
v26.5.2
v26.5.1
v26.5.0
v26.4.0
v26.3.0
v26.2.1
v26.2.0
v26.1.0
v25.12.0
v25.11.0
v25.10.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.1
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.1
v25.2.0
v25.1.0
v24.12.0
v24.11.0
v24.10.1
v24.10.0
v24.9.0
v24.8.0
v24.7.0
v24.6.0
v24.5.0
v24.4.0
v24.3.0
v24.2.0
v24.1.0
v23.12.0
v23.11.0
v23.10.0
v23.9.0
v23.8.1
v23.8.0
v23.7.2
v23.7.1
v23.7.0
v23.6.0
v23.5.0
v23.4.2
v23.4.1
v23.4.0
v23.3.2
v23.3.0
v23.2.9
v23.2.5
v23.1.12
v22.12.9
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
Mirrored from GitHub Pull Request
No labels
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#111582
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/3274
Author: @minajevs
Created: 8/16/2024
Status: ❌ Closed
Base:
master← Head:dm-fix-second-click-on-mobile-new-transaction📝 Commits (10+)
bf965b1Fix mobile transaction form requires additional click to unfocus amount input4132141remove console.logsf159765Release notec902193Merge branch 'master' into dm-fix-second-click-on-mobile-new-transactiona70a144Merge branch 'master' into dm-fix-second-click-on-mobile-new-transaction04da995Remove single active form hook1890304remove controlled focus from FocusableAmountInput3951fadfix optional prop4c0d853Remove erroneous importb32ebdffix lint errors📊 Changes
6 files changed (+92 additions, -322 deletions)
View changed files
📝
packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx(+14 -9)📝
packages/desktop-client/src/components/mobile/transactions/TransactionEdit.jsx(+70 -174)📝
packages/desktop-client/src/components/modals/EnvelopeBudgetMenuModal.tsx(+1 -10)📝
packages/desktop-client/src/components/modals/TrackingBudgetMenuModal.tsx(+1 -10)➖
packages/desktop-client/src/hooks/useSingleActiveEditForm.tsx(+0 -119)➕
upcoming-release-notes/3274.md(+6 -0)📄 Description
Closes #3268
So the "bug" happened because
setTimeoutinonBlurhandler messed up event-loop. The current edited field was reset on the next cycle, afteronClickhandler of the next field was fired. RemovingsetTimeoutlinearizes event-loop and current edited field is reset beforeonClickis fired.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.