github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #2009] [MERGED] [Maintenance] Migrating util.js and chartTheme.js to typescript #11126

New Issue
Closed
opened 2026-04-10 20:52:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:52:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2009
Author: @ghosetuhin
Created: 12/2/2023
Status: ✅ Merged
Merged: 12/6/2023
Merged by: @MatissJanis

Base: master ← Head: master

📝 Commits (10+)

📊 Changes

4 files changed (+65 additions, -46 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/chart-theme.ts (+2 -2)
➖ packages/desktop-client/src/components/reports/util.js (+0 -44)
➕ packages/desktop-client/src/components/reports/util.ts (+57 -0)
➕ upcoming-release-notes/2009.md (+6 -0)

📄 Description

Link to issue: https://github.com/actualbudget/actual/issues/1483

Replaced util.js with util.ts

  • Added data types when easily inferrable to the functions in the file
  • Fixed lint errors which were created during changes

Replaced chart-theme.js with chart-theme.ts

  • Created types for all the different styles being used
  • Assigned data types to all the variables in the file

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2009 **Author:** [@ghosetuhin](https://github.com/ghosetuhin) **Created:** 12/2/2023 **Status:** ✅ Merged **Merged:** 12/6/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`579cfea`](https://github.com/actualbudget/actual/commit/579cfea021a5ba32effb7bcde5c8ce47a3ab8038) change file type to ts - [`f6b151f`](https://github.com/actualbudget/actual/commit/f6b151f561d95a2b30cd64ef5c243d7ad0f2e4ac) added types to fromDateRepr, runAll and index functions - [`30316d6`](https://github.com/actualbudget/actual/commit/30316d6a739bce80d15a29ca7bc75ad625fc6415) added types to indexStack and indexCashFlow - [`1128b0e`](https://github.com/actualbudget/actual/commit/1128b0e4008354d66777032431983e7753705bd6) added release note file - [`9b134c2`](https://github.com/actualbudget/actual/commit/9b134c2acf260a5feefe36fe69a14380cd2edb88) ran prettier - [`7aa57f4`](https://github.com/actualbudget/actual/commit/7aa57f40ef59bdec28000c29ad7b9c6eca11514b) fixed lint errors - [`5f0eea4`](https://github.com/actualbudget/actual/commit/5f0eea48b602e377083d718cf7b64913c2f7a21f) fixed remaining lint errors - [`ff83de0`](https://github.com/actualbudget/actual/commit/ff83de002ae5ca2645334d34d89a279815dc0623) Merge branch 'master' into master - [`b131597`](https://github.com/actualbudget/actual/commit/b131597931cd7117c6e0200935076a9bf8a217de) added ColorFades interface - [`8a15ea4`](https://github.com/actualbudget/actual/commit/8a15ea427ba1db77a3072583cc425d98c8fedd96) Merge branch 'master' of https://github.com/ghosetuhin/actual ### 📊 Changes **4 files changed** (+65 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/chart-theme.ts` (+2 -2) ➖ `packages/desktop-client/src/components/reports/util.js` (+0 -44) ➕ `packages/desktop-client/src/components/reports/util.ts` (+57 -0) ➕ `upcoming-release-notes/2009.md` (+6 -0) </details> ### 📄 Description Link to issue: https://github.com/actualbudget/actual/issues/1483 ### Replaced util.js with util.ts - Added data types when easily inferrable to the functions in the file - Fixed lint errors which were created during changes ### Replaced chart-theme.js with chart-theme.ts - Created types for all the different styles being used - Assigned data types to all the variables in the file --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:52:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11126
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?