github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1993] [MERGED] [Maintenance] Use Page component for mobile pages #11115

New Issue
Closed
opened 2026-04-10 20:52:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:52:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1993
Author: @joel-jeremy
Created: 11/29/2023
Status: ✅ Merged
Merged: 12/5/2023
Merged by: @joel-jeremy

Base: master ← Head: standardize-mobile-pages

📝 Commits (10+)

  • f08ab59 Use Page component for mobile pages
  • ac4a20d Release notes
  • 7d5dd2e Use Button instead of Link in MobileBackButton
  • 099dcee Update mobile budget table to use Page component
  • 87d40d1 Settings page cleanup
  • 97adc84 Fix lint error
  • 5678d39 Updates + small font size increase in page headings
  • 8ffe1a6 Fix rebase error
  • bae6e7e Button height
  • 786902e Revert payees navtab

📊 Changes

34 files changed (+686 additions, -894 deletions)

View changed files

📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-6-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-loads-the-budget-page-with-budgeted-amounts-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-loads-the-budget-page-with-budgeted-amounts-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-2-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-3-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-4-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-5-chromium-linux.png (+0 -0)
📝 packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-6-chromium-linux.png (+0 -0)

...and 14 more files

📄 Description

Most of the updates on the VRT screenshots are due to a bit larger font on the page heading and the desktop one is the settings blocks are just a few pixels smaller in width.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1993 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 11/29/2023 **Status:** ✅ Merged **Merged:** 12/5/2023 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `standardize-mobile-pages` --- ### 📝 Commits (10+) - [`f08ab59`](https://github.com/actualbudget/actual/commit/f08ab592c3cf05b50c69f629861f18e2a7b9fe25) Use Page component for mobile pages - [`ac4a20d`](https://github.com/actualbudget/actual/commit/ac4a20da6187049af4e57909718d04c7435b0fb2) Release notes - [`7d5dd2e`](https://github.com/actualbudget/actual/commit/7d5dd2ec09bf50bcef229de445f5e9c0683d6036) Use Button instead of Link in MobileBackButton - [`099dcee`](https://github.com/actualbudget/actual/commit/099dcee90366d855b9cd503f19c31f22463d081f) Update mobile budget table to use Page component - [`87d40d1`](https://github.com/actualbudget/actual/commit/87d40d1a4d3af8d7ba7913b0f4633be494f842da) Settings page cleanup - [`97adc84`](https://github.com/actualbudget/actual/commit/97adc845ee6b508f77d3d8ec3ae3f15395ebc716) Fix lint error - [`5678d39`](https://github.com/actualbudget/actual/commit/5678d3919402245b6869cfd8627b1e7582fdcf1e) Updates + small font size increase in page headings - [`8ffe1a6`](https://github.com/actualbudget/actual/commit/8ffe1a6032a41385a8350d9f29401ca76fd7140b) Fix rebase error - [`bae6e7e`](https://github.com/actualbudget/actual/commit/bae6e7eabf51390ab752dda9a243e60a25871d2c) Button height - [`786902e`](https://github.com/actualbudget/actual/commit/786902e22162172c0cee13726b6d5d207242bc15) Revert payees navtab ### 📊 Changes **34 files changed** (+686 additions, -894 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-checks-that-settings-page-can-be-opened-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-from-accounts-id-page-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-creates-a-transaction-via-footer-button-6-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-loads-the-budget-page-with-budgeted-amounts-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-loads-the-budget-page-with-budgeted-amounts-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-2-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-3-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-4-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-5-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/e2e/mobile.test.js-snapshots/Mobile-opens-individual-account-page-and-checks-that-filtering-is-working-6-chromium-linux.png` (+0 -0) _...and 14 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Most of the updates on the VRT screenshots are due to a bit larger font on the page heading and the desktop one is the settings blocks are just a few pixels smaller in width. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:52:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11115
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?