github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #2007] [MERGED] [Maintenance] Converting dateRange and useReport to tsx #110886

New Issue
Closed
opened 2026-06-05 14:54:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-05 14:54:12 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2007
Author: @ameekSinghUniversityAcc
Created: 12/2/2023
Status: ✅ Merged
Merged: 12/2/2023
Merged by: @MatissJanis

Base: master ← Head: master

📝 Commits (10+)

📊 Changes

3 files changed (+28 additions, -9 deletions)

View changed files

📝 packages/desktop-client/src/components/reports/DateRange.tsx (+14 -6)
📝 packages/desktop-client/src/components/reports/useReport.tsx (+8 -3)
➕ upcoming-release-notes/2007.md (+6 -0)

📄 Description

Link to issue: https://github.com/actualbudget/actual/issues/1483

Files Changed

Replaced DateRange.js with DateRange.tsx

Replaced useReport.js with useReport.tsx

  • Added prop types

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2007 **Author:** [@ameekSinghUniversityAcc](https://github.com/ameekSinghUniversityAcc) **Created:** 12/2/2023 **Status:** ✅ Merged **Merged:** 12/2/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`72a8b32`](https://github.com/actualbudget/actual/commit/72a8b325be6028f6517d0e1d17e83cbf8a74455b) Migrating DateRange file from js to tsx - [`b0b6ce9`](https://github.com/actualbudget/actual/commit/b0b6ce9555154b551b98ff05025254cffe4fe1fa) fixing typo in var name, rearranging imports - [`4fc6a0f`](https://github.com/actualbudget/actual/commit/4fc6a0f9f8afb3c8ac5bad23fcdb8e72aaf79dea) removing default react import - [`0ad5960`](https://github.com/actualbudget/actual/commit/0ad5960e460e7adbeac2c148bb26724f6a413407) fixing default import failure - [`e967832`](https://github.com/actualbudget/actual/commit/e967832f7395e6546a856b6934422074a1181315) fixing lint errors - [`75c0774`](https://github.com/actualbudget/actual/commit/75c07741e8b2a9a7df75705eefbf31d061a325ab) pushing linter fixes - [`e57c4ee`](https://github.com/actualbudget/actual/commit/e57c4eea260749b45c0769df4b86b244ecfe3e41) Merge branch 'master' into master - [`a441ab4`](https://github.com/actualbudget/actual/commit/a441ab4d79fa506c2553fa07b6c4cb9f6062df0a) refactoring the date range string - [`8960718`](https://github.com/actualbudget/actual/commit/8960718d90f0edea613989c58b4e67cfdcbdbb8e) Merge branch 'master' of https://github.com/ameekSinghUniversityAcc/actual - [`2a0ddf9`](https://github.com/actualbudget/actual/commit/2a0ddf99fba6199d26563677650c46ca98ef5e1b) migrating usereport to tsx ### 📊 Changes **3 files changed** (+28 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/reports/DateRange.tsx` (+14 -6) 📝 `packages/desktop-client/src/components/reports/useReport.tsx` (+8 -3) ➕ `upcoming-release-notes/2007.md` (+6 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Link to issue: https://github.com/actualbudget/actual/issues/1483 ## Files Changed ### Replaced DateRange.js with DateRange.tsx - Added types to function props - Added types to function return value - Replaced the direct modification of the props with constants (`parseStart` and `parseEnd`) - Replaced deprecated Date fn `getYear()` with `getFullYear()` (see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/getYear) - Formatted new file with linter ### Replaced useReport.js with useReport.tsx - Added prop types --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-05 14:54:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#110886