mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-09 19:52:56 -05:00
[Bug]: Menus blend in with other elements #1105
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#1105
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @psybers on GitHub (May 18, 2024).
Verified issue does not already exist?
What happened?
The popup menus have no border, which means they tend to blend in with other elements behind them making them less obviously a menu:
Simply open any menu and you can observe it. This affects the dark theme, though technically the other themes also have the problem. But in those other themes, the shadow added to the menu is enough to make it have somewhat of a border.
Where are you hosting Actual?
Docker
What browsers are you seeing the problem on?
Chrome, Desktop App (Electron)
Operating System
Mac OSX
@Tigatok commented on GitHub (May 20, 2024):
I think its mostly due to the searchbar background color being very similar to the popup menu color in dark mode, less about the shadow. That being said, some sort of technique could be applied to differentiate better
@psybers commented on GitHub (May 20, 2024):
There are other places where this can happen. I discovered it while working on a popup menu inside a modal.
The dark theme needs to do something around the menus to help give them a border between them and the things behind them.
@Tigatok commented on GitHub (May 20, 2024):
It actually doesn't look too terrible with a white border around in dark mode. Maybe something to consider
@youngcw commented on GitHub (May 20, 2024):
Those tooltips in darkmode used to be a different color, but it was getting to be such a middle of the road color that it was really hard to have good contrast with non-white text. We should do something to fix that color being the exact same as may backgrounds, but imo its better than it used to.
@VoltaicGRiD commented on GitHub (May 24, 2024):
@psybers Have a look at these screenshots I pulled from the electron app. Let me know what you think:
I'm not convinced on the color of the border in light-mode, but it is visible for sure in my opinion.
Alternatively, I found another color that is far more "vocal" but doesn't look quite as clean:
The first one uses
menuItemBackgroundHoverThe second one uses
menuItemTextHeader@psybers commented on GitHub (May 24, 2024):
@VoltaicGRiD Dark mode looks good. Do we even need to change the light mode ones? I think they worked as is.
@youngcw commented on GitHub (May 24, 2024):
I feel like adding borders would feel out of place since none of the other pop ups use borders. I second that the light theme has no issues as is and should't be changed.
@VoltaicGRiD commented on GitHub (May 24, 2024):
@youngcw I'm definitely not against adding borders. I am all for accessibility and I feel like it adds that without detracting from the overall appearance or making it look "ugly" as one might say. Since they use themed variables, I was simply trying to find one that I could just apply globally to the tooltip windows, so in this case, I don't think either is necessarily a bad choice, especially considering they are mostly just a CSS styling choice.
@psybers Not necessarily, I do like that it stands out more, but I don't think its a requirement for the light theme. Might not be bad to find a middle-ground. I'll play with some colors,
@VoltaicGRiD commented on GitHub (May 24, 2024):
Alright, added a section to the themes for each theme that I think, in my non-designer non-frontend experience looks and feels quite nice:
Definitely no need for them all to be identical to the background color. Especially on dark themes like Midnight.
And just to be clear, this applies to all "tooltip" type objects, including the notes on the budget page.
@psybers commented on GitHub (May 29, 2024):
@VoltaicGRiD Making progress! I wonder if the color should match the border in between each row in the spreadsheet? It should still give a defined border, but would match the existing themes a bit more.
@VoltaicGRiD commented on GitHub (May 29, 2024):
I don't hate it, but I think that they'd have to all match as themes, so
(Light doesn't change here, since it already fits that criteria)
If we just take the color from the table, I had to adjust the color of the background otherwise they were identical.
@psybers commented on GitHub (May 29, 2024):
I don't know that these are perfect (to me), but they definitely feel closer than the prior screenshots for me. I think the issue with the prior ones was there was too much contrast between the border and the menu background. These, there is still contrast but it is more subtle.
With the prior ones, the border actually has more salience than the menu itself, which is probably backward. With the new versions that problem seems fixed.
@VoltaicGRiD commented on GitHub (May 30, 2024):
What a fantastic word
I'll go ahead and commit these for now, I might add some custom shades that fit that 50% for me (gray750 instead of gray800). I think that'll be the solution that pleases everyone. Unless you had a better suggestion of course.
@psybers commented on GitHub (May 30, 2024):
@VoltaicGRiD If you have not already done so, I would recommend opening a pull request for these changes so we can work toward merging them later.
@MatissJanis commented on GitHub (Jun 3, 2024):
Related: https://github.com/actualbudget/actual/pull/2815
@youngcw commented on GitHub (Sep 22, 2024):
fixed by #3298