github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #1836] [MERGED] fixed:issue->#1835 Support NYNAB import of transactions that contain subtransactions tha… #11034

New Issue
Closed
opened 2026-04-10 20:50:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:50:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1836
Author: @Marethyu1
Created: 10/29/2023
Status: ✅ Merged
Merged: 11/5/2023
Merged by: @MatissJanis

Base: master ← Head: fix-1835

📝 Commits (7)

  • f29a197 Support NYNAB import of transactions that contain subtransactions that are transfers
  • f3fe570 Update ynab5 demo budget so that budget import tests pass
  • b6e4d56 Fix spelling in ynab5 demo budget memo
  • fd50c87 Declare payee key in subtransaction
  • 0d559af YNAB5 importer - use a map to speed up importing transactions with transfers
  • f26ec0f Make ynab5.Payee transfer_acct nullable
  • 0ecb949 Formatting fix - apply yarn lint --fix to ynab5 files

📊 Changes

5 files changed (+90 additions, -3 deletions)

View changed files

📝 packages/desktop-client/e2e/data/ynab5-demo-budget.json (+62 -1)
📝 packages/desktop-client/e2e/onboarding.test.js (+2 -2)
📝 packages/loot-core/src/server/importers/ynab5-types.d.ts (+2 -0)
📝 packages/loot-core/src/server/importers/ynab5.ts (+18 -0)
➕ upcoming-release-notes/1836.md (+6 -0)

📄 Description

…t are transfers

A subtransaction is considered a transfer from ynab if

  • the transfer_account_id is set
  • the category_id is null (transfers dont have categories)

This addresses #1835

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1836 **Author:** [@Marethyu1](https://github.com/Marethyu1) **Created:** 10/29/2023 **Status:** ✅ Merged **Merged:** 11/5/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `fix-1835` --- ### 📝 Commits (7) - [`f29a197`](https://github.com/actualbudget/actual/commit/f29a197579c967ba40520bb264a6138c9c15d520) Support NYNAB import of transactions that contain subtransactions that are transfers - [`f3fe570`](https://github.com/actualbudget/actual/commit/f3fe570963a9e2068bbbcd728d86ec36eb8dbf23) Update ynab5 demo budget so that budget import tests pass - [`b6e4d56`](https://github.com/actualbudget/actual/commit/b6e4d56244136e308675d43aaf1c773d6194c698) Fix spelling in ynab5 demo budget memo - [`fd50c87`](https://github.com/actualbudget/actual/commit/fd50c878aef8051536b0b2583618e8858057d880) Declare payee key in subtransaction - [`0d559af`](https://github.com/actualbudget/actual/commit/0d559aff8cefd29da66866d785fb2f7299251e41) YNAB5 importer - use a map to speed up importing transactions with transfers - [`f26ec0f`](https://github.com/actualbudget/actual/commit/f26ec0fcdf3d354e6ec589011f9131441dba8014) Make ynab5.Payee transfer_acct nullable - [`0ecb949`](https://github.com/actualbudget/actual/commit/0ecb9495bc32003b4563dc89450f541ea840745d) Formatting fix - apply yarn lint --fix to ynab5 files ### 📊 Changes **5 files changed** (+90 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/data/ynab5-demo-budget.json` (+62 -1) 📝 `packages/desktop-client/e2e/onboarding.test.js` (+2 -2) 📝 `packages/loot-core/src/server/importers/ynab5-types.d.ts` (+2 -0) 📝 `packages/loot-core/src/server/importers/ynab5.ts` (+18 -0) ➕ `upcoming-release-notes/1836.md` (+6 -0) </details> ### 📄 Description …t are transfers A subtransaction is considered a transfer from ynab if - the transfer_account_id is set - the category_id is null (transfers dont have categories) This addresses #1835 <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:50:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11034
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?