[PR #922] [CLOSED] [WIP] Dark theme #110226

Closed
opened 2026-06-05 13:35:54 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/922
Author: @biohzrddd
Created: 4/18/2023
Status: Closed

Base: masterHead: dark-theme


📝 Commits (10+)

  • aee06a7 Added base colors, updated sidebar
  • a90fce6 Budget page mostly complete
  • 30443f4 Got accounts page working
  • 5f362d5 Fix small errors preventing compile
  • 106a6f8 Create a list of themes
  • 9062545 Make a demo page for themed components
  • 2e6c207 Added initial color pallet
  • d7533bd Started work on sidebar conversion, many bugs!
  • 8035983 Updated Navy to be less purple, removed colorsn
  • 45145a4 Core buttons working

📊 Changes

120 files changed (+2286 additions, -1909 deletions)

View changed files

📝 packages/desktop-client/public/index.html (+11 -10)
packages/desktop-client/src/components/Background.js (+159 -0)
📝 packages/desktop-client/src/components/BankSyncStatus.js (+4 -4)
📝 packages/desktop-client/src/components/LoggedInUser.js (+14 -5)
📝 packages/desktop-client/src/components/ManageRules.js (+141 -129)
📝 packages/desktop-client/src/components/MobileWebMessage.js (+3 -3)
📝 packages/desktop-client/src/components/NotesButton.tsx (+6 -5)
📝 packages/desktop-client/src/components/Notifications.tsx (+23 -11)
📝 packages/desktop-client/src/components/Page.js (+7 -6)
📝 packages/desktop-client/src/components/SidebarWithData.js (+2 -2)
📝 packages/desktop-client/src/components/Titlebar.js (+21 -12)
📝 packages/desktop-client/src/components/UpdateNotification.js (+5 -12)
📝 packages/desktop-client/src/components/accounts/Account.js (+11 -5)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.js (+4 -4)
📝 packages/desktop-client/src/components/accounts/Balance.js (+10 -5)
📝 packages/desktop-client/src/components/accounts/Header.js (+7 -21)
📝 packages/desktop-client/src/components/accounts/MobileAccount.js (+2 -2)
📝 packages/desktop-client/src/components/accounts/MobileAccountDetails.js (+6 -9)
📝 packages/desktop-client/src/components/accounts/MobileAccounts.js (+15 -12)
📝 packages/desktop-client/src/components/accounts/Reconcile.js (+5 -5)

...and 80 more files

📄 Description

Ready to merge!

This is an overhaul of the way colors are used in Actual in order to add a dark theme. It also adds the possibility of future themes.

Please see the netlify preview here then give your opinion and rationale on any found issues either here on github or on our Discord feedback thread.

Dark
image

Light
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/922 **Author:** [@biohzrddd](https://github.com/biohzrddd) **Created:** 4/18/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dark-theme` --- ### 📝 Commits (10+) - [`aee06a7`](https://github.com/actualbudget/actual/commit/aee06a7865112c5a12296b8332169fa63b4fa7ae) Added base colors, updated sidebar - [`a90fce6`](https://github.com/actualbudget/actual/commit/a90fce6301fb7c146591e910c0a3e1d05af5d2f9) Budget page mostly complete - [`30443f4`](https://github.com/actualbudget/actual/commit/30443f40ed673cf867f3431af0723715e2857548) Got accounts page working - [`5f362d5`](https://github.com/actualbudget/actual/commit/5f362d5fdfb47cd75ff0cbf6608e5335f4c86767) Fix small errors preventing compile - [`106a6f8`](https://github.com/actualbudget/actual/commit/106a6f87c820730b67feba344c9efcef570be92c) Create a list of themes - [`9062545`](https://github.com/actualbudget/actual/commit/90625456eb0cc8bfde8bf2e638d97e575b90673a) Make a demo page for themed components - [`2e6c207`](https://github.com/actualbudget/actual/commit/2e6c2079e27cc766c3f24e35cfa7078737fbcd4d) Added initial color pallet - [`d7533bd`](https://github.com/actualbudget/actual/commit/d7533bdc2c7645373fe1ab9e5ccc051b9906c178) Started work on sidebar conversion, many bugs! - [`8035983`](https://github.com/actualbudget/actual/commit/8035983f47ede060a6580d74c67705d7a1e9516f) Updated Navy to be less purple, removed colorsn - [`45145a4`](https://github.com/actualbudget/actual/commit/45145a4284f2e9d658c27f4e7cd67477f61ace10) Core buttons working ### 📊 Changes **120 files changed** (+2286 additions, -1909 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/public/index.html` (+11 -10) ➕ `packages/desktop-client/src/components/Background.js` (+159 -0) 📝 `packages/desktop-client/src/components/BankSyncStatus.js` (+4 -4) 📝 `packages/desktop-client/src/components/LoggedInUser.js` (+14 -5) 📝 `packages/desktop-client/src/components/ManageRules.js` (+141 -129) 📝 `packages/desktop-client/src/components/MobileWebMessage.js` (+3 -3) 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+6 -5) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+23 -11) 📝 `packages/desktop-client/src/components/Page.js` (+7 -6) 📝 `packages/desktop-client/src/components/SidebarWithData.js` (+2 -2) 📝 `packages/desktop-client/src/components/Titlebar.js` (+21 -12) 📝 `packages/desktop-client/src/components/UpdateNotification.js` (+5 -12) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+11 -5) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.js` (+4 -4) 📝 `packages/desktop-client/src/components/accounts/Balance.js` (+10 -5) 📝 `packages/desktop-client/src/components/accounts/Header.js` (+7 -21) 📝 `packages/desktop-client/src/components/accounts/MobileAccount.js` (+2 -2) 📝 `packages/desktop-client/src/components/accounts/MobileAccountDetails.js` (+6 -9) 📝 `packages/desktop-client/src/components/accounts/MobileAccounts.js` (+15 -12) 📝 `packages/desktop-client/src/components/accounts/Reconcile.js` (+5 -5) _...and 80 more files_ </details> ### 📄 Description Ready to merge! This is an overhaul of the way colors are used in Actual in order to add a dark theme. It also adds the possibility of future themes. Please see the [netlify preview here](https://deploy-preview-922--actualbudget.netlify.app/) then give your opinion and rationale on any found issues either here on github or on [our Discord feedback thread](https://discord.com/channels/937901803608096828/1117584114275582059). Dark ![image](https://github.com/actualbudget/actual/assets/10577752/08bc2a71-53d8-47b1-ac95-27e8678ed6fb) Light ![image](https://github.com/actualbudget/actual/assets/10577752/eafeb4da-4886-489b-bc59-ae880030c253) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-05 13:35:54 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#110226