github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 20:38:54 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #1753] [MERGED] [Bug] Goals: Fix schedules 'in between' calculation #10993

New Issue
Closed
opened 2026-04-10 20:49:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:49:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1753
Author: @shall0pass
Created: 9/29/2023
Status: ✅ Merged
Merged: 10/6/2023
Merged by: @shall0pass

Base: master ← Head: goals_schedulesInbetween

📝 Commits (2)

📊 Changes

2 files changed (+13 additions, -2 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goaltemplates.ts (+7 -2)
➕ upcoming-release-notes/1753.md (+6 -0)

📄 Description

The templates conditions were not finding a value when 'in between' was chosen from schedules. This adds a check on the schedule amount type, and if 'in between' is found will return the median value. I believe this matches the behavior of the scheduled transaction in the ledger. It may make more sense to fill the maximum amount here for a budgeted value. I'm interested in any comments on what the expected behavior should be.
 
Fixes: https://github.com/actualbudget/actual/issues/1747

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1753 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 9/29/2023 **Status:** ✅ Merged **Merged:** 10/6/2023 **Merged by:** [@shall0pass](https://github.com/shall0pass) **Base:** `master` ← **Head:** `goals_schedulesInbetween` --- ### 📝 Commits (2) - [`edfc806`](https://github.com/actualbudget/actual/commit/edfc8062e709ac8e3b8a3d225e9a2d8efe523f1c) fix in between calculation - [`8155dde`](https://github.com/actualbudget/actual/commit/8155dde7b8160f77fbc3173e9782d1b661fd3a49) release note ### 📊 Changes **2 files changed** (+13 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+7 -2) ➕ `upcoming-release-notes/1753.md` (+6 -0) </details> ### 📄 Description The templates conditions were not finding a value when 'in between' was chosen from schedules. This adds a check on the schedule amount type, and if 'in between' is found will return the median value. I believe this matches the behavior of the scheduled transaction in the ledger. It may make more sense to fill the maximum amount here for a budgeted value. I'm interested in any comments on what the expected behavior should be.   Fixes: https://github.com/actualbudget/actual/issues/1747 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:49:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#10993
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?