[PR #8005] [AI] fix: clear payee on split parent transactions #109764

New Issue

Open

opened 2026-06-02 18:53:35 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-06-02 18:53:35 -05:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/8005
Author: @meaqua9420
Created: 5/31/2026
Status: 🔄 Open

Base: master ← Head: fix-split-parent-payee

---

📝 Commits (1)

• f63c16f [AI] fix: clear split parent payee

📊 Changes

4 files changed (+35 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx (+1 -1)
📝 packages/loot-core/src/shared/transactions.test.ts (+26 -2)
📝 packages/loot-core/src/shared/transactions.ts (+2 -0)
➕ upcoming-release-notes/8005.md (+6 -0)

📄 Description

Summary

• clear the parent transaction payee when a transaction is split so the original payee is not kept invisibly on the parent row
• keep child rows carrying the original payee, including newly added split rows when the parent no longer stores one
• update the split transaction and transaction table tests for the new parent/child payee behavior

Fixes #7721

Notes

• This intentionally does not change off-budget transaction handling.
• This does not attempt a migration for existing split parents; it only fixes newly split transactions and newly added split rows.

Tests

• yarn install --immutable
• yarn workspace @actual-app/core run test:node src/shared/transactions.test.ts
• yarn workspace @actual-app/web test src/components/transactions/TransactionsTable.test.tsx
• yarn workspace @actual-app/core run typecheck
• yarn workspace @actual-app/web run typecheck
• git diff --check

---

Bundle Stats

Bundle	Files count	Total bundle size	% Changed
desktop-client	37	14.03 MB → 14.03 MB (+309 B)	+0.00%
loot-core	1	5.34 MB → 5.34 MB (+59 B)	+0.00%
api	2	3.97 MB → 3.97 MB (+57 B)	+0.00%
cli	1	7.97 MB	0%
crdt	1	11.12 kB	0%

View detailed bundle stats

desktop-client

Total

Files count	Total bundle size	% Changed
37	14.03 MB → 14.03 MB (+309 B)	+0.00%

Changeset

File	Δ	Size
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts	📈 +57 B (+0.68%)	8.17 kB → 8.22 kB
locale/en.json	📈 +252 B (+0.12%)	198.24 kB → 198.48 kB

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset	File Size	% Changed
static/js/en.js	198.24 kB → 198.48 kB (+252 B)	+0.12%
static/js/Value.js	5.08 MB → 5.08 MB (+57 B)	+0.00%

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/index.js	1.54 MB	0%
static/js/BackgroundImage.js	121.09 kB	0%
static/js/FormulaEditor.js	962.55 kB	0%
static/js/ManageRules.js	46.98 kB	0%
static/js/PayeeRuleCountLabel.js	7.33 kB	0%
static/js/ReportRouter.js	1.26 MB	0%
static/js/ScheduleEditForm.js	146.44 kB	0%
static/js/SchedulesTable.js	202.7 kB	0%
static/js/TransactionEdit.js	90.63 kB	0%
static/js/TransactionList.js	85.81 kB	0%
static/js/_baseIsEqual.js	98.38 kB	0%
static/js/ca.js	186.75 kB	0%
static/js/client.js	451.37 kB	0%
static/js/da.js	101.15 kB	0%
static/js/de.js	170.77 kB	0%
static/js/en-GB.js	9.25 kB	0%
static/js/es.js	178.68 kB	0%
static/js/extends.js	500.96 kB	0%
static/js/fr.js	178.57 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.46 kB	0%
static/js/it.js	165 kB	0%
static/js/narrow.js	364.2 kB	0%
static/js/nb-NO.js	148.05 kB	0%
static/js/nl.js	106.24 kB	0%
static/js/pt-BR.js	188.43 kB	0%
static/js/resize-observer.js	18.06 kB	0%
static/js/th.js	174.48 kB	0%
static/js/theme.js	31.88 kB	0%
static/js/toString.js	705.14 kB	0%
static/js/uk.js	207.46 kB	0%
static/js/useFormatList.js	2.52 kB	0%
static/js/useTransactionBatchActions.js	9.71 kB	0%
static/js/wide.js	297.21 kB	0%
static/js/workbox-window.prod.es5.js	7.33 kB	0%
static/js/zh-Hans.js	116.89 kB	0%

---

loot-core

Total

Files count	Total bundle size	% Changed
1	5.34 MB → 5.34 MB (+59 B)	+0.00%

Changeset

File	Δ	Size
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts	📈 +59 B (+0.95%)	6.05 kB → 6.1 kB

View detailed bundle breakdown

Added

Asset	File Size	% Changed
kcab.worker.BV1BFEcZ.js	0 B → 5.34 MB (+5.34 MB)	-

Removed

Asset	File Size	% Changed
kcab.worker._bwMMgjb.js	5.34 MB → 0 B (-5.34 MB)	-100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

---

api

Total

Files count	Total bundle size	% Changed
2	3.97 MB → 3.97 MB (+57 B)	+0.00%

Changeset

File	Δ	Size
home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts	📈 +57 B (+0.95%)	5.85 kB → 5.9 kB

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset	File Size	% Changed
index.js	3.97 MB → 3.97 MB (+57 B)	+0.00%

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
models.js	0 B	0%

---

cli

Total

Files count	Total bundle size	% Changed
1	7.97 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
cli.js	7.97 MB	0%

---

crdt

Total

Files count	Total bundle size	% Changed
1	11.12 kB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
index.js	11.12 kB	0%

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/8005 **Author:** [@meaqua9420](https://github.com/meaqua9420) **Created:** 5/31/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-split-parent-payee` --- ### 📝 Commits (1) - [`f63c16f`](https://github.com/actualbudget/actual/commit/f63c16ffe6ebab26510089618d6a13ca9e5d485f) [AI] fix: clear split parent payee ### 📊 Changes **4 files changed** (+35 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx` (+1 -1) 📝 `packages/loot-core/src/shared/transactions.test.ts` (+26 -2) 📝 `packages/loot-core/src/shared/transactions.ts` (+2 -0) ➕ `upcoming-release-notes/8005.md` (+6 -0) </details> ### 📄 Description ## Summary - clear the parent transaction payee when a transaction is split so the original payee is not kept invisibly on the parent row - keep child rows carrying the original payee, including newly added split rows when the parent no longer stores one - update the split transaction and transaction table tests for the new parent/child payee behavior Fixes #7721 ## Notes - This intentionally does not change off-budget transaction handling. - This does not attempt a migration for existing split parents; it only fixes newly split transactions and newly added split rows. ## Tests - `yarn install --immutable` - `yarn workspace @actual-app/core run test:node src/shared/transactions.test.ts` - `yarn workspace @actual-app/web test src/components/transactions/TransactionsTable.test.tsx` - `yarn workspace @actual-app/core run typecheck` - `yarn workspace @actual-app/web run typecheck` - `git diff --check` <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.03 MB → 14.03 MB (+309 B) | +0.00% loot-core | 1 | 5.34 MB → 5.34 MB (+59 B) | +0.00% api | 2 | 3.97 MB → 3.97 MB (+57 B) | +0.00% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.03 MB → 14.03 MB (+309 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +57 B (+0.68%) | 8.17 kB → 8.22 kB `locale/en.json` | 📈 +252 B (+0.12%) | 198.24 kB → 198.48 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/en.js | 198.24 kB → 198.48 kB (+252 B) | +0.12% static/js/Value.js | 5.08 MB → 5.08 MB (+57 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.54 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.98 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.26 MB | 0% static/js/ScheduleEditForm.js | 146.44 kB | 0% static/js/SchedulesTable.js | 202.7 kB | 0% static/js/TransactionEdit.js | 90.63 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/_baseIsEqual.js | 98.38 kB | 0% static/js/ca.js | 186.75 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.15 kB | 0% static/js/de.js | 170.77 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/es.js | 178.68 kB | 0% static/js/extends.js | 500.96 kB | 0% static/js/fr.js | 178.57 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.05 kB | 0% static/js/nl.js | 106.24 kB | 0% static/js/pt-BR.js | 188.43 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/theme.js | 31.88 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 207.46 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 297.21 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.89 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB → 5.34 MB (+59 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +59 B (+0.95%) | 6.05 kB → 6.1 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.BV1BFEcZ.js | 0 B → 5.34 MB (+5.34 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker._bwMMgjb.js | 5.34 MB → 0 B (-5.34 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.97 MB → 3.97 MB (+57 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/shared/transactions.ts` | 📈 +57 B (+0.95%) | 5.85 kB → 5.9 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.97 MB → 3.97 MB (+57 B) | +0.00% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-06-02 18:53:35 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

worktree-pr-description-rules

worktree-count-points-gh-bot

theme-number-contrast

theme-contrast-test

fix/automatic-bank-sync-mobile-app

jfdoming/api-key-shared-bank-sync

claude/lucid-turing-br8zwl

future-buffer

carryover-chain

copilot/fix-failing-github-actions-job

copilot/fix-failing-github-actions-job-compare

fix/hide-sab-warning-in-capacitor

release

tabedzki/feat/docker-non-root

ios-home-screen-widgets

mobile-budget-redesign

ai/fix-mobile-carryover-arrow-alignment

jfdoming/provider-identity-update

jfdoming/electron-signin-update

jfdoming/openid-flow-update

release-update/26.10.1

release-notes/26.10.1

matiss/dazzling-babbage-b9rjwi

react-query-rules

ai/add-loan-formula-autocomplete

claude/pr-8519-regression-testing-fhvrrh

speed-up-transaction-list-and-schedules

fix-slow-balance-recompute-on-transaction-edit

jfdoming/opfs-sahpool-mobile

jfdoming/opfs-sahpool

fix-8612-schedule-delete-menu

jfdoming/api-tokens-part-8

jfdoming/api-tokens-part-7

jfdoming/api-tokens-part-6

jfdoming/api-tokens-part-5

jfdoming/mobile-safe-area-header

jfdoming/api-tokens-part-4

jfdoming/mobile-splash-lifecycle

jfdoming/api-tokens-part-3

jfdoming/mobile-shared-array-buffer

jfdoming/api-tokens-part-2

jfdoming/api-tokens-part-1

persist-transaction-filters

claude/modernize-transactions-tanstack-orgrze

bank-sync-per-file-03-pluggy-loot-core

claude/auto-close-prs-no-profile-pic-mjqpsy

cross-version-sync-stage2

claude/react-table-library-research-afx83z

tolerate-newer-migrations

claude/verify-migration-guardrails-i82c8m

tabedzki/feat/replacing-month-picker-with-day-picker

delay-initial-sync-until-loaded

cross-version-sync-compat

jfdoming/mobile-app-updates

claude/budget-version-migration-compat-151jlr

claude/worker-error-serialization-9iqtl7

claude/issue-8401-regression-test-9nw9l3

jfdoming/mobile-app-foundation-part-1

jfdoming/mobile-app-scaffold

ai-fix-cleanup-def-8290

claude/relaxed-shannon-jusywa

claude/fervent-keller-s6f2fq

claude/determined-feynman-st1y9z

claude/wizardly-einstein-vi2wce

claude/sweet-albattani-7nseio

feat/bank-sync-per-budget-file

claude/affectionate-cannon-y0kc82

claude/dependabot-findings-m9pgmb

claude/mac-app-ios-publish-zjs1lz

claude/vigilant-tesla-aiiyos

claude/quirky-cerf-v5qck7

claude/animation-removal-alternative-2etfh1

claude/netlify-preview-comments-consolidate-9XPYa

osc/7391-error-boundaries-reports

claude/pensive-dijkstra-7DYui

claude/server-app-version-mismatch-HTCGv

claude/pr-8027-review-feedback-mELuO

claude/zealous-wozniak-e5pO0

claude/intelligent-heisenberg-BSHJq

claude/translation-download-refactor-jFRsO

claude/mobile-performance-ideas-G9PAO

claude/github-issue-7988-5A5ly

blacksmith-migration-ff70d2d

claude/great-mayer-KRvOk

claude/react-native-ios-compilation-fcJh5

claude/serene-goldberg-58xv0

claude/kind-euler-LVG3K

release-automation/edge-nightly

7710-bundle-migrations

claude/fix-docker-build-error-WMfed

claude/llm-compatible-release-notes-t20Nr

7710-tests-tdd

cursor/transaction-table-rewrite-f077

claude/plan-ci-secure-context-OtEe1

claude/fix-issue-7667-DPXi3

cursor/resolve-pr-7449-ee11

claude/fix-typescript-build-error-JPtZ5

copilot/add-repository-configs-to-packages

worktree-compressed-drifting-ritchie

claude/api-consumer-verification-kfz1K

pr-7454

claude/fix-issue-7410-LLLQ4

revert-7281-generate-icons

react-query-useSchedules

copilot/sub-pr-6140

package-upgrades

v26.11.0

v26.10.0

v26.9.0

v26.8.1

v26.8.0

v26.7.0

v26.6.0

v26.5.2

v26.5.1

v26.5.0

v26.4.0

v26.3.0

v26.2.1

v26.2.0

v26.1.0

v25.12.0

v25.11.0

v25.10.0

v25.9.0

v25.8.0

v25.7.1

v25.7.0

v25.6.1

v25.6.0

v25.5.0

v25.4.0

v25.3.1

v25.3.0

v25.2.1

v25.2.0

v25.1.0

v24.12.0

v24.11.0

v24.10.1

v24.10.0

v24.9.0

v24.8.0

v24.7.0

v24.6.0

v24.5.0

v24.4.0

v24.3.0

v24.2.0

v24.1.0

v23.12.0

v23.11.0

v23.10.0

v23.9.0

v23.8.1

v23.8.0

v23.7.2

v23.7.1

v23.7.0

v23.6.0

v23.5.0

v23.4.2

v23.4.1

v23.4.0

v23.3.2

v23.3.0

v23.2.9

v23.2.5

v23.1.12

v22.12.9

Labels

Clear labels

AI generated

API

bank sync

budgeting

bug

can’t replicate

dependencies

docker

documentation

electron

experimental feature

feature

feedback

goal templates

good first issue

help wanted

importers

maintenance

needs info

needs testing

needs triage

needs votes

openid

payees

pull-request

Mirrored from GitHub Pull Request

regression

reports

responsive

rules

schedules

server

✨ merged

split transactions

tech debt

tech-support

theme

transaction import

transaction reconciliation

transactions

translations

upstream

user interface

✅ approved

wontfix

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

GiteaMirror ninjasurge (Kaehlen Rog)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/actual#109764