mirror of
https://github.com/actualbudget/actual.git
synced 2026-11-12 03:42:19 -06:00
Closed
opened 2026-06-02 18:39:01 -05:00 by GiteaMirror
·
0 comments
No Branch/Tag Specified
master
worktree-pr-description-rules
worktree-count-points-gh-bot
theme-number-contrast
theme-contrast-test
fix/automatic-bank-sync-mobile-app
jfdoming/api-key-shared-bank-sync
claude/lucid-turing-br8zwl
future-buffer
carryover-chain
copilot/fix-failing-github-actions-job
copilot/fix-failing-github-actions-job-compare
fix/hide-sab-warning-in-capacitor
release
tabedzki/feat/docker-non-root
ios-home-screen-widgets
mobile-budget-redesign
ai/fix-mobile-carryover-arrow-alignment
jfdoming/provider-identity-update
jfdoming/electron-signin-update
jfdoming/openid-flow-update
release-update/26.10.1
release-notes/26.10.1
matiss/dazzling-babbage-b9rjwi
react-query-rules
ai/add-loan-formula-autocomplete
claude/pr-8519-regression-testing-fhvrrh
speed-up-transaction-list-and-schedules
fix-slow-balance-recompute-on-transaction-edit
jfdoming/opfs-sahpool-mobile
jfdoming/opfs-sahpool
fix-8612-schedule-delete-menu
jfdoming/api-tokens-part-8
jfdoming/api-tokens-part-7
jfdoming/api-tokens-part-6
jfdoming/api-tokens-part-5
jfdoming/mobile-safe-area-header
jfdoming/api-tokens-part-4
jfdoming/mobile-splash-lifecycle
jfdoming/api-tokens-part-3
jfdoming/mobile-shared-array-buffer
jfdoming/api-tokens-part-2
jfdoming/api-tokens-part-1
persist-transaction-filters
claude/modernize-transactions-tanstack-orgrze
bank-sync-per-file-03-pluggy-loot-core
claude/auto-close-prs-no-profile-pic-mjqpsy
cross-version-sync-stage2
claude/react-table-library-research-afx83z
tolerate-newer-migrations
claude/verify-migration-guardrails-i82c8m
tabedzki/feat/replacing-month-picker-with-day-picker
delay-initial-sync-until-loaded
cross-version-sync-compat
jfdoming/mobile-app-updates
claude/budget-version-migration-compat-151jlr
claude/worker-error-serialization-9iqtl7
claude/issue-8401-regression-test-9nw9l3
jfdoming/mobile-app-foundation-part-1
jfdoming/mobile-app-scaffold
ai-fix-cleanup-def-8290
claude/relaxed-shannon-jusywa
claude/fervent-keller-s6f2fq
claude/determined-feynman-st1y9z
claude/wizardly-einstein-vi2wce
claude/sweet-albattani-7nseio
feat/bank-sync-per-budget-file
claude/affectionate-cannon-y0kc82
claude/dependabot-findings-m9pgmb
claude/mac-app-ios-publish-zjs1lz
claude/vigilant-tesla-aiiyos
claude/quirky-cerf-v5qck7
claude/animation-removal-alternative-2etfh1
claude/netlify-preview-comments-consolidate-9XPYa
osc/7391-error-boundaries-reports
claude/pensive-dijkstra-7DYui
claude/server-app-version-mismatch-HTCGv
claude/pr-8027-review-feedback-mELuO
claude/zealous-wozniak-e5pO0
claude/intelligent-heisenberg-BSHJq
claude/translation-download-refactor-jFRsO
claude/mobile-performance-ideas-G9PAO
claude/github-issue-7988-5A5ly
blacksmith-migration-ff70d2d
claude/great-mayer-KRvOk
claude/react-native-ios-compilation-fcJh5
claude/serene-goldberg-58xv0
claude/kind-euler-LVG3K
release-automation/edge-nightly
7710-bundle-migrations
claude/fix-docker-build-error-WMfed
claude/llm-compatible-release-notes-t20Nr
7710-tests-tdd
cursor/transaction-table-rewrite-f077
claude/plan-ci-secure-context-OtEe1
claude/fix-issue-7667-DPXi3
cursor/resolve-pr-7449-ee11
claude/fix-typescript-build-error-JPtZ5
copilot/add-repository-configs-to-packages
worktree-compressed-drifting-ritchie
claude/api-consumer-verification-kfz1K
pr-7454
claude/fix-issue-7410-LLLQ4
revert-7281-generate-icons
react-query-useSchedules
copilot/sub-pr-6140
package-upgrades
v26.11.0
v26.10.0
v26.9.0
v26.8.1
v26.8.0
v26.7.0
v26.6.0
v26.5.2
v26.5.1
v26.5.0
v26.4.0
v26.3.0
v26.2.1
v26.2.0
v26.1.0
v25.12.0
v25.11.0
v25.10.0
v25.9.0
v25.8.0
v25.7.1
v25.7.0
v25.6.1
v25.6.0
v25.5.0
v25.4.0
v25.3.1
v25.3.0
v25.2.1
v25.2.0
v25.1.0
v24.12.0
v24.11.0
v24.10.1
v24.10.0
v24.9.0
v24.8.0
v24.7.0
v24.6.0
v24.5.0
v24.4.0
v24.3.0
v24.2.0
v24.1.0
v23.12.0
v23.11.0
v23.10.0
v23.9.0
v23.8.1
v23.8.0
v23.7.2
v23.7.1
v23.7.0
v23.6.0
v23.5.0
v23.4.2
v23.4.1
v23.4.0
v23.3.2
v23.3.0
v23.2.9
v23.2.5
v23.1.12
v22.12.9
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
Mirrored from GitHub Pull Request
No labels
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#109676
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/actualbudget/actual/pull/7815
Author: @matt-fidd
Created: 5/12/2026
Status: ✅ Merged
Merged: 5/13/2026
Merged by: @matt-fidd
Base:
master← Head:budget-automation/cleanup-ui📝 Commits (8)
3eb97c5[AI] Share cleanup-group helpers and let storeTemplates write cleanup_deffabcf48[AI] Add UI editor for end-of-month cleanup automations72f2294notef4d37c3review pass 130c3d67bring automation logic in line with cleanup logic3fcda36review pass 35727e0acoderabbit pass 1a0dbf14wording suggestions📊 Changes
24 files changed (+1106 additions, -139 deletions)
View changed files
📝
packages/desktop-client/package.json(+1 -0)📝
packages/desktop-client/src/components/budget/SidebarCategoryButtons.tsx(+1 -1)📝
packages/desktop-client/src/components/budget/goals/CategoryAutomationButton.tsx(+2 -1)➕
packages/desktop-client/src/components/budget/goals/cleanupModel.ts(+136 -0)➕
packages/desktop-client/src/components/budget/goals/editor/CleanupAutomation.tsx(+290 -0)➕
packages/desktop-client/src/components/budget/goals/editor/CleanupAutomationReadOnly.tsx(+34 -0)➕
packages/desktop-client/src/components/budget/goals/editor/CleanupGroupPicker.tsx(+154 -0)📝
packages/desktop-client/src/components/modals/BudgetAutomationsModal/AutomationListRow.tsx(+0 -1)📝
packages/desktop-client/src/components/modals/BudgetAutomationsModal/BudgetAutomationsBody.tsx(+126 -40)📝
packages/desktop-client/src/components/modals/BudgetAutomationsModal/BudgetAutomationsModal.tsx(+28 -17)➕
packages/desktop-client/src/components/modals/BudgetAutomationsModal/CleanupListRow.tsx(+92 -0)📝
packages/desktop-client/src/components/modals/BudgetAutomationsModal/UnsupportedDirectivesNotice.tsx(+1 -16)📝
packages/desktop-client/src/components/modals/UnmigrateBudgetAutomationsModal.tsx(+22 -8)📝
packages/desktop-client/src/hooks/useBudgetAutomations.ts(+8 -3)➕
packages/desktop-client/src/hooks/useCategoryCleanup.ts(+51 -0)➕
packages/desktop-client/src/hooks/useCleanupGroups.ts(+40 -0)📝
packages/desktop-client/src/modals/modalsSlice.ts(+2 -0)📝
packages/loot-core/src/server/budget/app.ts(+9 -0)➕
packages/loot-core/src/server/budget/cleanup-groups.ts(+54 -0)📝
packages/loot-core/src/server/budget/cleanup-template-notes.ts(+6 -35)...and 4 more files
📄 Description
Description
AI disclaimer: I used claude to orchestrate quite a bit of this, but I've done a thorough review and made quite a few tweaks from what it came up with.
Cleanup is reasonably complicated, and nailing it into a UI was pretty tough. Open to opinions here, but I have tried many iterations and this one works the best of them.
Note:
Technically, the engine supports a single category spanning multiple groups, but I have disallowed this in the UI because it's undefined behaviour (depends on what order the groups run, which is hard to predict if I'm reading it correctly). It's not hard to re-allow it if we reckon that breaks workflows, but I'm reasonably doubtful that there are many (if any) using that.
Related issue(s)
https://github.com/actualbudget/actual/issues/7692
Testing
Tested locally with this budget file, it's got some groups and some global config in it. To use it:
2026-05-12-Cleanup Test.zip
also migrated, and unmigrated to check everything is working as expected.
Checklist
Bundle Stats
View detailed bundle stats
desktop-client
Total
Changeset
src/components/budget/goals/editor/CleanupAutomation.tsxsrc/components/budget/goals/editor/CleanupGroupPicker.tsxsrc/components/modals/BudgetAutomationsModal/CleanupListRow.tsxsrc/components/budget/goals/cleanupModel.tssrc/components/budget/goals/editor/CleanupAutomationReadOnly.tsxsrc/hooks/useCategoryCleanup.tssrc/hooks/useCleanupGroups.tssrc/components/modals/BudgetAutomationsModal/BudgetAutomationsBody.tsxsrc/hooks/useBudgetAutomations.tssrc/components/modals/UnmigrateBudgetAutomationsModal.tsxsrc/components/modals/BudgetAutomationsModal/BudgetAutomationsModal.tsxsrc/components/budget/SidebarCategoryButtons.tsxsrc/components/budget/goals/CategoryAutomationButton.tsxpackage.jsonsrc/components/modals/BudgetAutomationsModal/AutomationListRow.tsxsrc/components/modals/BudgetAutomationsModal/UnsupportedDirectivesNotice.tsxView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
loot-core
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/server/budget/cleanup-groups.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/statements.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/goal-template.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/app.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/template-notes.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/cleanup-template-notes.tsView detailed bundle breakdown
Added
Removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
No assets were unchanged
api
Total
Changeset
home/runner/work/actual/actual/packages/loot-core/src/server/budget/cleanup-groups.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/statements.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/goal-template.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/app.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/template-notes.tshome/runner/work/actual/actual/packages/loot-core/src/server/budget/cleanup-template-notes.tsView detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
Smaller
No assets were smaller
Unchanged
cli
Total
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
crdt
Total
View detailed bundle breakdown
Added
No assets were added
Removed
No assets were removed
Bigger
No assets were bigger
Smaller
No assets were smaller
Unchanged
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.