[PR #7813] [MERGED] [AI] Replace any-typed Modal in undo state with structural type #109674

New Issue

Closed

opened 2026-06-02 18:38:43 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-06-02 18:38:43 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7813
Author: @MatissJanis
Created: 5/12/2026
Status: ✅ Merged
Merged: 5/13/2026
Merged by: @MatissJanis

Base: master ← Head: claude/fix-modal-type-import-MOuIp

---

📝 Commits (4)

• 30742b2 [AI] Replace any-typed Modal in undo state with structural type
• aa1638f Add release notes for PR #7813
• 951af4c Update 7813.md
• 69ad222 [AI] Add TODO on Modal cast for future type consolidation

📊 Changes

3 files changed (+19 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/global-events.ts (+9 -2)
📝 packages/loot-core/src/platform/client/undo/index.ts (+4 -2)
➕ upcoming-release-notes/7813.md (+6 -0)

📄 Description

Slightly improving typing of the "Modal" type.

---

Bundle Stats

Bundle	Files count	Total bundle size	% Changed
desktop-client	33	13.91 MB → 13.91 MB (+1.24 kB)	+0.01%
loot-core	1	5.31 MB	0%
api	2	3.94 MB	0%
cli	1	7.97 MB	0%
crdt	1	11.12 kB	0%

View detailed bundle stats

desktop-client

Total

Files count	Total bundle size	% Changed
33	13.91 MB → 13.91 MB (+1.24 kB)	+0.01%

Changeset

File	Δ	Size
locale/en-GB.json	📈 +1.81 kB (+22.12%)	8.2 kB → 10.01 kB
src/global-events.ts	📈 +26 B (+0.74%)	3.42 kB → 3.45 kB
locale/es.json	📉 -41 B (-0.02%)	178.87 kB → 178.83 kB
locale/ca.json	📉 -45 B (-0.02%)	187.76 kB → 187.72 kB
locale/de.json	📉 -42 B (-0.02%)	170.42 kB → 170.38 kB
locale/fr.json	📉 -47 B (-0.03%)	178.76 kB → 178.71 kB
locale/nb-NO.json	📉 -41 B (-0.03%)	148.23 kB → 148.19 kB
locale/it.json	📉 -46 B (-0.03%)	165.17 kB → 165.13 kB
locale/pt-BR.json	📉 -58 B (-0.03%)	189.45 kB → 189.39 kB
locale/zh-Hans.json	📉 -37 B (-0.03%)	117.79 kB → 117.75 kB
locale/uk.json	📉 -68 B (-0.03%)	207.63 kB → 207.56 kB
locale/nl.json	📉 -46 B (-0.04%)	106.39 kB → 106.34 kB
locale/en.json	📉 -138 B (-0.07%)	190.1 kB → 189.97 kB

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset	File Size	% Changed
static/js/en-GB.js	8.2 kB → 10.01 kB (+1.81 kB)	+22.12%
static/js/index.js	1.97 MB → 1.97 MB (+26 B)	+0.00%

Smaller

Asset	File Size	% Changed
static/js/en.js	190.1 kB → 189.97 kB (-138 B)	-0.07%
static/js/uk.js	207.63 kB → 207.56 kB (-68 B)	-0.03%
static/js/pt-BR.js	189.45 kB → 189.39 kB (-58 B)	-0.03%
static/js/fr.js	178.76 kB → 178.71 kB (-47 B)	-0.03%
static/js/it.js	165.17 kB → 165.13 kB (-46 B)	-0.03%
static/js/nl.js	106.39 kB → 106.34 kB (-46 B)	-0.04%
static/js/ca.js	187.76 kB → 187.72 kB (-45 B)	-0.02%
static/js/de.js	170.42 kB → 170.38 kB (-42 B)	-0.02%
static/js/es.js	178.87 kB → 178.83 kB (-41 B)	-0.02%
static/js/nb-NO.js	148.23 kB → 148.19 kB (-41 B)	-0.03%
static/js/zh-Hans.js	117.79 kB → 117.75 kB (-37 B)	-0.03%

Unchanged

Asset	File Size	% Changed
static/js/BackgroundImage.js	121.09 kB	0%
static/js/FormulaEditor.js	962.55 kB	0%
static/js/ReportRouter.js	1.22 MB	0%
static/js/ScheduleEditForm.js	146.45 kB	0%
static/js/TransactionEdit.js	190.43 kB	0%
static/js/TransactionList.js	85.81 kB	0%
static/js/Value.js	4.96 MB	0%
static/js/bankSyncUtils.js	54.15 kB	0%
static/js/chart-theme.js	800.08 kB	0%
static/js/client.js	451.37 kB	0%
static/js/da.js	101.28 kB	0%
static/js/extends.js	519.29 kB	0%
static/js/indexeddb-main-thread-worker-e59fee74.js	13.46 kB	0%
static/js/narrow.js	364.2 kB	0%
static/js/resize-observer.js	18.06 kB	0%
static/js/th.js	174.62 kB	0%
static/js/theme.js	31.67 kB	0%
static/js/useFormatList.js	4.96 kB	0%
static/js/wide.js	453 B	0%
static/js/workbox-window.prod.es5.js	7.33 kB	0%

---

loot-core

Total

Files count	Total bundle size	% Changed
1	5.31 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.Cozwd3bP.js	5.31 MB	0%

---

api

Total

Files count	Total bundle size	% Changed
2	3.94 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
index.js	3.94 MB	0%
models.js	0 B	0%

---

cli

Total

Files count	Total bundle size	% Changed
1	7.97 MB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
cli.js	7.97 MB	0%

---

crdt

Total

Files count	Total bundle size	% Changed
1	11.12 kB	0%

View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset	File Size	% Changed
index.js	11.12 kB	0%

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7813 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 5/12/2026 **Status:** ✅ Merged **Merged:** 5/13/2026 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `claude/fix-modal-type-import-MOuIp` --- ### 📝 Commits (4) - [`30742b2`](https://github.com/actualbudget/actual/commit/30742b23541c332a467abc9251a77b43b56d09b5) [AI] Replace any-typed Modal in undo state with structural type - [`aa1638f`](https://github.com/actualbudget/actual/commit/aa1638fcd88533ac8583a4ec03cc1f34a354111c) Add release notes for PR #7813 - [`951af4c`](https://github.com/actualbudget/actual/commit/951af4cc6aa7063063f031c57e729745ffef8530) Update 7813.md - [`69ad222`](https://github.com/actualbudget/actual/commit/69ad2220411fcb3265d52cdd14def6d0a0f8aaf1) [AI] Add TODO on Modal cast for future type consolidation ### 📊 Changes **3 files changed** (+19 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/global-events.ts` (+9 -2) 📝 `packages/loot-core/src/platform/client/undo/index.ts` (+4 -2) ➕ `upcoming-release-notes/7813.md` (+6 -0) </details> ### 📄 Description Slightly improving typing of the "Modal" type. <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 33 | 13.91 MB → 13.91 MB (+1.24 kB) | +0.01% loot-core | 1 | 5.31 MB | 0% api | 2 | 3.94 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 33 | 13.91 MB → 13.91 MB (+1.24 kB) | +0.01% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `locale/en-GB.json` | 📈 +1.81 kB (+22.12%) | 8.2 kB → 10.01 kB `src/global-events.ts` | 📈 +26 B (+0.74%) | 3.42 kB → 3.45 kB `locale/es.json` | 📉 -41 B (-0.02%) | 178.87 kB → 178.83 kB `locale/ca.json` | 📉 -45 B (-0.02%) | 187.76 kB → 187.72 kB `locale/de.json` | 📉 -42 B (-0.02%) | 170.42 kB → 170.38 kB `locale/fr.json` | 📉 -47 B (-0.03%) | 178.76 kB → 178.71 kB `locale/nb-NO.json` | 📉 -41 B (-0.03%) | 148.23 kB → 148.19 kB `locale/it.json` | 📉 -46 B (-0.03%) | 165.17 kB → 165.13 kB `locale/pt-BR.json` | 📉 -58 B (-0.03%) | 189.45 kB → 189.39 kB `locale/zh-Hans.json` | 📉 -37 B (-0.03%) | 117.79 kB → 117.75 kB `locale/uk.json` | 📉 -68 B (-0.03%) | 207.63 kB → 207.56 kB `locale/nl.json` | 📉 -46 B (-0.04%) | 106.39 kB → 106.34 kB `locale/en.json` | 📉 -138 B (-0.07%) | 190.1 kB → 189.97 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/en-GB.js | 8.2 kB → 10.01 kB (+1.81 kB) | +22.12% static/js/index.js | 1.97 MB → 1.97 MB (+26 B) | +0.00% **Smaller** Asset | File Size | % Changed ----- | --------- | --------- static/js/en.js | 190.1 kB → 189.97 kB (-138 B) | -0.07% static/js/uk.js | 207.63 kB → 207.56 kB (-68 B) | -0.03% static/js/pt-BR.js | 189.45 kB → 189.39 kB (-58 B) | -0.03% static/js/fr.js | 178.76 kB → 178.71 kB (-47 B) | -0.03% static/js/it.js | 165.17 kB → 165.13 kB (-46 B) | -0.03% static/js/nl.js | 106.39 kB → 106.34 kB (-46 B) | -0.04% static/js/ca.js | 187.76 kB → 187.72 kB (-45 B) | -0.02% static/js/de.js | 170.42 kB → 170.38 kB (-42 B) | -0.02% static/js/es.js | 178.87 kB → 178.83 kB (-41 B) | -0.02% static/js/nb-NO.js | 148.23 kB → 148.19 kB (-41 B) | -0.03% static/js/zh-Hans.js | 117.79 kB → 117.75 kB (-37 B) | -0.03% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ReportRouter.js | 1.22 MB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/TransactionEdit.js | 190.43 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.96 MB | 0% static/js/bankSyncUtils.js | 54.15 kB | 0% static/js/chart-theme.js | 800.08 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.28 kB | 0% static/js/extends.js | 519.29 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.62 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.31 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.Cozwd3bP.js | 5.31 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.94 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.94 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-06-02 18:38:43 -05:00

GiteaMirror closed this issue 2026-06-02 18:38:49 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

claude/verify-migration-guardrails-i82c8m

cross-version-sync-stage2

api-browser-custom-data-dir

dependabot/npm_and_yarn/npm_and_yarn-cd62b4b37a

tabedzki/feat/replacing-month-picker-with-day-picker

delay-initial-sync-until-loaded

jfdoming/mobile-app-build

cross-version-sync-compat

jfdoming/api-tokens-part-1

jfdoming/api-tokens-part-2

jfdoming/api-tokens-part-3

jfdoming/mobile-app-updates

claude/budget-version-migration-compat-151jlr

claude/worker-error-serialization-9iqtl7

claude/react-table-library-research-afx83z

claude/issue-8401-regression-test-9nw9l3

jfdoming/mobile-app-foundation-part-1

jfdoming/mobile-app-scaffold

release

ai-fix-cleanup-def-8290

claude/relaxed-shannon-jusywa

claude/fervent-keller-s6f2fq

claude/determined-feynman-st1y9z

claude/wizardly-einstein-vi2wce

claude/sweet-albattani-7nseio

feat/bank-sync-per-budget-file

claude/affectionate-cannon-y0kc82

claude/dependabot-findings-m9pgmb

claude/mac-app-ios-publish-zjs1lz

claude/vigilant-tesla-aiiyos

depot-migrate-secrets-1781296330308

claude/quirky-cerf-v5qck7

claude/animation-removal-alternative-2etfh1

claude/netlify-preview-comments-consolidate-9XPYa

osc/7391-error-boundaries-reports

claude/pensive-dijkstra-7DYui

claude/server-app-version-mismatch-HTCGv

claude/pr-8027-review-feedback-mELuO

claude/zealous-wozniak-e5pO0

claude/intelligent-heisenberg-BSHJq

claude/translation-download-refactor-jFRsO

claude/mobile-performance-ideas-G9PAO

claude/github-issue-7988-5A5ly

blacksmith-migration-ff70d2d

claude/great-mayer-KRvOk

claude/react-native-ios-compilation-fcJh5

claude/serene-goldberg-58xv0

claude/kind-euler-LVG3K

release-automation/edge-nightly

7710-bundle-migrations

claude/fix-docker-build-error-WMfed

claude/llm-compatible-release-notes-t20Nr

7710-tests-tdd

cursor/transaction-table-rewrite-f077

claude/plan-ci-secure-context-OtEe1

claude/fix-issue-7667-DPXi3

cursor/resolve-pr-7449-ee11

claude/fix-typescript-build-error-JPtZ5

copilot/add-repository-configs-to-packages

worktree-compressed-drifting-ritchie

claude/api-consumer-verification-kfz1K

pr-7454

claude/fix-issue-7410-LLLQ4

revert-7281-generate-icons

react-query-useSchedules

copilot/sub-pr-6140

package-upgrades

v26.7.0

v26.6.0

v26.5.2

v26.5.1

v26.5.0

v26.4.0

v26.3.0

v26.2.1

v26.2.0

v26.1.0

v25.12.0

v25.11.0

v25.10.0

v25.9.0

v25.8.0

v25.7.1

v25.7.0

v25.6.1

v25.6.0

v25.5.0

v25.4.0

v25.3.1

v25.3.0

v25.2.1

v25.2.0

v25.1.0

v24.12.0

v24.11.0

v24.10.1

v24.10.0

v24.9.0

v24.8.0

v24.7.0

v24.6.0

v24.5.0

v24.4.0

v24.3.0

v24.2.0

v24.1.0

v23.12.0

v23.11.0

v23.10.0

v23.9.0

v23.8.1

v23.8.0

v23.7.2

v23.7.1

v23.7.0

v23.6.0

v23.5.0

v23.4.2

v23.4.1

v23.4.0

v23.3.2

v23.3.0

v23.2.9

v23.2.5

v23.1.12

v22.12.9

Labels

Clear labels

AI generated

API

bank sync

budgeting

bug

can’t replicate

dependencies

docker

documentation

electron

experimental feature

feature

feedback

goal templates

good first issue

help wanted

importers

maintenance

needs info

needs testing

needs triage

needs votes

openid

payees

pull-request

Mirrored from GitHub Pull Request

regression

reports

responsive

rules

schedules

server

✨ merged

split transactions

tech debt

tech-support

theme

transaction import

transaction reconciliation

transactions

translations

upstream

user interface

✅ approved

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/actual#109674