github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-12 03:42:19 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6364] [MERGED] 🤖 Adding path filters so workflows only run when required #108734

New Issue
Closed
opened 2026-06-02 16:23:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-02 16:23:16 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6364
Author: @MikesGlitch
Created: 12/10/2025
Status: ✅ Merged
Merged: 12/11/2025
Merged by: @MikesGlitch

Base: master ← Head: workflows-to-run-only-when-required

📝 Commits (10+)

  • 96ec27c adding path filters to workflows so they only run when required
  • 03c2820 trigger them also when the workflow changes
  • abe9d66 adding yarn lock in case packages affect e2e
  • 4c9b7e1 release notes
  • c6568f9 add the package.json in case we modify the scripts
  • e77f533 Remove API changes from size comparison workflow
  • e3f19f2 Clarify size impact of package changes in workflow
  • acfe0ab Fix comments for VRT update exclusions
  • a11e2e6 Update VRT screenshots
  • f191483 Update VRT screenshots

📊 Changes

5 files changed (+48 additions, -9 deletions)

View changed files

📝 .github/workflows/e2e-test.yml (+10 -0)
📝 .github/workflows/electron-pr.yml (+9 -0)
📝 .github/workflows/size-compare.yml (+13 -7)
📝 .github/workflows/vrt-update-generate.yml (+9 -2)
➕ upcoming-release-notes/6364.md (+7 -0)

📄 Description

Should help with the Netlify bandwidth and prevent unneeded builds from happening.

Another option is to use path-ignore which would be less paths to specify, but it would also build for more files unnecessarily.

Note

Add path-based filters to multiple GitHub Actions workflows to run only on relevant changes, plus a release note.

  • CI/Workflows:
    • Path filters added to limit triggers to relevant changes:
      • /.github/workflows/e2e-test.yml: runs only on app-related paths; excludes packages/sync-server/**, packages/api/**, packages/ci-actions/**, packages/docs/**, packages/eslint-plugin-actual/**.
      • /.github/workflows/electron-pr.yml: similar filters; excludes API, CI actions, docs, eslint plugin.
      • /.github/workflows/size-compare.yml: adds include/exclude path filters; minor quoting normalization.
      • /.github/workflows/vrt-update-generate.yml: adds include/exclude path filters; excludes sync-server, API, CI actions, docs, eslint plugin.
  • Docs:
    • Adds release note upcoming-release-notes/6364.md about preventing unnecessary GitHub UI workflows.

Written by Cursor Bugbot for commit f1914837ef. This will update automatically on new commits. Configure here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6364 **Author:** [@MikesGlitch](https://github.com/MikesGlitch) **Created:** 12/10/2025 **Status:** ✅ Merged **Merged:** 12/11/2025 **Merged by:** [@MikesGlitch](https://github.com/MikesGlitch) **Base:** `master` ← **Head:** `workflows-to-run-only-when-required` --- ### 📝 Commits (10+) - [`96ec27c`](https://github.com/actualbudget/actual/commit/96ec27c0c175ee1cc192485a7735c6eaaa2d19d2) adding path filters to workflows so they only run when required - [`03c2820`](https://github.com/actualbudget/actual/commit/03c2820480a8f9a708b2f98db61407e719e9c70a) trigger them also when the workflow changes - [`abe9d66`](https://github.com/actualbudget/actual/commit/abe9d669bff4c3943fedcbb08075013803a1160d) adding yarn lock in case packages affect e2e - [`4c9b7e1`](https://github.com/actualbudget/actual/commit/4c9b7e187f8d6f2553f6156c8c16bb6bb1384e69) release notes - [`c6568f9`](https://github.com/actualbudget/actual/commit/c6568f9569059e31315663074bc64d054a191b47) add the package.json in case we modify the scripts - [`e77f533`](https://github.com/actualbudget/actual/commit/e77f533d15e5944ed8eedd036f850d7118e7585b) Remove API changes from size comparison workflow - [`e3f19f2`](https://github.com/actualbudget/actual/commit/e3f19f2cd80b01fd774592de01a06ddbdb99d225) Clarify size impact of package changes in workflow - [`acfe0ab`](https://github.com/actualbudget/actual/commit/acfe0ab265b8e303508fd08c85369e6eeaccbd60) Fix comments for VRT update exclusions - [`a11e2e6`](https://github.com/actualbudget/actual/commit/a11e2e62aa155972203a29cade4df93d902098c5) Update VRT screenshots - [`f191483`](https://github.com/actualbudget/actual/commit/f1914837ef755d4cce09486362b7b84e04c64ff4) Update VRT screenshots ### 📊 Changes **5 files changed** (+48 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/e2e-test.yml` (+10 -0) 📝 `.github/workflows/electron-pr.yml` (+9 -0) 📝 `.github/workflows/size-compare.yml` (+13 -7) 📝 `.github/workflows/vrt-update-generate.yml` (+9 -2) ➕ `upcoming-release-notes/6364.md` (+7 -0) </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes. Try running yarn generate:release-notes *before* pushing your PR for an interactive experience. --> Should help with the Netlify bandwidth and prevent unneeded builds from happening. Another option is to use `path-ignore` which would be less paths to specify, but it would also build for more files unnecessarily. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Add path-based filters to multiple GitHub Actions workflows to run only on relevant changes, plus a release note. > > - **CI/Workflows**: > - **Path filters added** to limit triggers to relevant changes: > - `/.github/workflows/e2e-test.yml`: runs only on app-related paths; excludes `packages/sync-server/**`, `packages/api/**`, `packages/ci-actions/**`, `packages/docs/**`, `packages/eslint-plugin-actual/**`. > - `/.github/workflows/electron-pr.yml`: similar filters; excludes API, CI actions, docs, eslint plugin. > - `/.github/workflows/size-compare.yml`: adds include/exclude path filters; minor quoting normalization. > - `/.github/workflows/vrt-update-generate.yml`: adds include/exclude path filters; excludes sync-server, API, CI actions, docs, eslint plugin. > - **Docs**: > - Adds release note `upcoming-release-notes/6364.md` about preventing unnecessary GitHub UI workflows. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f1914837ef755d4cce09486362b7b84e04c64ff4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-02 16:23:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#108734