github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1536] [CLOSED] [WIP] Goals: Error notifications #10858

New Issue
Closed
opened 2026-04-10 20:45:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:45:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1536
Author: @shall0pass
Created: 8/17/2023
Status: ❌ Closed

Base: master ← Head: Goals_TypeScript

📝 Commits (5)

  • db6f8ba ts notification
  • 47ae28f add promise
  • c92dad9 Merge branch 'actualbudget:master' into Goals_TypeScript
  • 5e26804 Merge branch 'master' into Goals_TypeScript
  • 0f37718 still doesn't work, but more types

📊 Changes

2 files changed (+36 additions, -14 deletions)

View changed files

📝 packages/loot-core/src/server/budget/goaltemplates.ts (+31 -11)
📝 packages/loot-core/src/server/budget/types/handlers.d.ts (+5 -3)

📄 Description

This is an attempt to resolve https://github.com/actualbudget/actual/issues/1507

This still doesn't work and I'm not sure what I'm missing. I'm sure it's very basic. When debugging, the Promise object being returned appears to be consistent between the notifications that do work and those that do not.

If anyone could help me figure this out, I'd appreciate it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1536 **Author:** [@shall0pass](https://github.com/shall0pass) **Created:** 8/17/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `Goals_TypeScript` --- ### 📝 Commits (5) - [`db6f8ba`](https://github.com/actualbudget/actual/commit/db6f8baa8119d96c93b9593861e5223d996d936c) ts notification - [`47ae28f`](https://github.com/actualbudget/actual/commit/47ae28fd358473937aa2a7d72ee9fbf0d6aade96) add promise<notification> - [`c92dad9`](https://github.com/actualbudget/actual/commit/c92dad93074b05d2bd8a63e6d19cecd2050aa8ce) Merge branch 'actualbudget:master' into Goals_TypeScript - [`5e26804`](https://github.com/actualbudget/actual/commit/5e2680408d518a208537a98fd336c7c9030fb9b4) Merge branch 'master' into Goals_TypeScript - [`0f37718`](https://github.com/actualbudget/actual/commit/0f3771809b0b1c68805ed09cfcc0b6faf6e433b1) still doesn't work, but more types ### 📊 Changes **2 files changed** (+36 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/budget/goaltemplates.ts` (+31 -11) 📝 `packages/loot-core/src/server/budget/types/handlers.d.ts` (+5 -3) </details> ### 📄 Description This is an attempt to resolve https://github.com/actualbudget/actual/issues/1507 This still doesn't work and I'm not sure what I'm missing. I'm sure it's very basic. When debugging, the Promise object being returned appears to be consistent between the notifications that do work and those that do not. If anyone could help me figure this out, I'd appreciate it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:45:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#10858
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?