github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-13 17:43:23 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #5600] [MERGED] Add conditional to schedules logic in rules page - improve VRT stability #108290

New Issue
Closed
opened 2026-06-02 15:19:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-02 15:19:37 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/5600
Author: @MatissJanis
Created: 8/21/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-vrt

📝 Commits (1)

  • 344a5fd Refactor schedule handling in ManageRules component

📊 Changes

3 files changed (+24 additions, -12 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.tsx (+12 -11)
📝 packages/loot-core/src/shared/schedules.ts (+6 -1)
➕ upcoming-release-notes/5600.md (+6 -0)

📄 Description

Refactor schedule handling in ManageRules component

  • Updated the ManageRules component to use ScheduleEntity type for schedules.
  • Improved the describeSchedule function to include type annotations for better clarity.
  • Added a conditional check to handle cases where the schedule may not exist, ensuring robust functionality.

This has been making the rules VRT tests flaky. For example: https://github.com/actualbudget/actual/actions/runs/17114788611/job/48543539731?pr=5587

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/5600 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-vrt` --- ### 📝 Commits (1) - [`344a5fd`](https://github.com/actualbudget/actual/commit/344a5fdafc87356179aaeb03f87bd491e6040a71) Refactor schedule handling in ManageRules component ### 📊 Changes **3 files changed** (+24 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.tsx` (+12 -11) 📝 `packages/loot-core/src/shared/schedules.ts` (+6 -1) ➕ `upcoming-release-notes/5600.md` (+6 -0) </details> ### 📄 Description Refactor schedule handling in ManageRules component - Updated the ManageRules component to use ScheduleEntity type for schedules. - Improved the describeSchedule function to include type annotations for better clarity. - Added a conditional check to handle cases where the schedule may not exist, ensuring robust functionality. **This has been making the rules VRT tests flaky. For example: https://github.com/actualbudget/actual/actions/runs/17114788611/job/48543539731?pr=5587** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-02 15:19:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#108290