[PR #1975] [MERGED] Fix cancel add category group #106318

Closed
opened 2026-06-02 11:18:23 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1975
Author: @williamk19
Created: 11/26/2023
Status: ✅ Merged
Merged: 11/26/2023
Merged by: @MatissJanis

Base: master ← Head: fix-cancel-add-category


📝 Commits (3)

  • 088a068 fixing warning when user cancel adding category
  • f357a3c Merge branch 'master' into fix-cancel-add-category
  • 2ba93b3 add release note

📊 Changes

2 files changed (+6 additions, -1 deletions)

View changed files

📝 packages/desktop-client/src/components/budget/SidebarGroup.tsx (+0 -1)
➕ upcoming-release-notes/1975.md (+6 -0)

📄 Description

There's a bug when user cancel add group (leave the input blank and click outside input). I've manage it with delete value: undefined in inputProps following SidebarCategory.tsx code.

Screenshot_1


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1975 **Author:** [@williamk19](https://github.com/williamk19) **Created:** 11/26/2023 **Status:** ✅ Merged **Merged:** 11/26/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `fix-cancel-add-category` --- ### 📝 Commits (3) - [`088a068`](https://github.com/actualbudget/actual/commit/088a0680b861f8316316ce173c4acd6458b2f0b1) fixing warning when user cancel adding category - [`f357a3c`](https://github.com/actualbudget/actual/commit/f357a3cdd1a95c78ef42516538e5bc90c373f648) Merge branch 'master' into fix-cancel-add-category - [`2ba93b3`](https://github.com/actualbudget/actual/commit/2ba93b3b263a60cd18b0970fe56485c6250edbd5) add release note ### 📊 Changes **2 files changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/budget/SidebarGroup.tsx` (+0 -1) ➕ `upcoming-release-notes/1975.md` (+6 -0) </details> ### 📄 Description There's a bug when user cancel add group (leave the input blank and click outside input). I've manage it with delete `value: undefined` in inputProps following SidebarCategory.tsx code. ![Screenshot_1](https://github.com/actualbudget/actual/assets/59714670/295b14c3-2100-421e-bbe8-335809486108) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-02 11:18:23 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#106318