github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 20:15:33 -05:00
Code Issues 1.5k Packages Projects Releases 55 Wiki Activity

[PR #1038] [MERGED] Fixed a bug where it was possible to make a transfer to the same account as the one making the transfer. #10536

New Issue
Closed
opened 2026-04-10 20:36:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:36:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1038
Author: @Miodec
Created: 5/16/2023
Status: ✅ Merged
Merged: 5/21/2023
Merged by: @MatissJanis

Base: master ← Head: transfer-accounts

📝 Commits (4)

  • 8fe3453 only using cached accounts if accounts parameter is nullish
  • 499d7e2 added release note
  • 4d1ac12 Merge branch 'master' into transfer-accounts
  • b3ff0d6 also filtering payees in the same way as accounts

📊 Changes

3 files changed (+18 additions, -2 deletions)

View changed files

📝 packages/desktop-client/src/components/accounts/TransactionsTable.js (+1 -0)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js (+11 -2)
➕ upcoming-release-notes/1038.md (+6 -0)

📄 Description

The payee autocomplete was always using cached accounts. Added a check to see if accounts was already passed in as a parameter - only using cached if it wasnt.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1038 **Author:** [@Miodec](https://github.com/Miodec) **Created:** 5/16/2023 **Status:** ✅ Merged **Merged:** 5/21/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `transfer-accounts` --- ### 📝 Commits (4) - [`8fe3453`](https://github.com/actualbudget/actual/commit/8fe3453d016010834edebe2889d2169f03ffdd0b) only using cached accounts if accounts parameter is nullish - [`499d7e2`](https://github.com/actualbudget/actual/commit/499d7e2d3811ccd5ade0b059cc334730c40129a0) added release note - [`4d1ac12`](https://github.com/actualbudget/actual/commit/4d1ac129752b791bc593475080df9c65b37e8d78) Merge branch 'master' into transfer-accounts - [`b3ff0d6`](https://github.com/actualbudget/actual/commit/b3ff0d60ac394378bcd5e949431e07a79294fc66) also filtering payees in the same way as accounts ### 📊 Changes **3 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.js` (+1 -0) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js` (+11 -2) ➕ `upcoming-release-notes/1038.md` (+6 -0) </details> ### 📄 Description The payee autocomplete was always using cached accounts. Added a check to see if accounts was already passed in as a parameter - only using cached if it wasnt. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:36:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#10536
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?