github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-11 09:32:33 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7987] [CLOSED] Add per-automation notes and improve forecast split handling #105231

New Issue
Closed
opened 2026-05-30 07:41:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-30 07:41:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7987
Author: @MatissJanis
Created: 5/28/2026
Status: ❌ Closed

Base: master ← Head: release

📝 Commits (3)

📊 Changes

17 files changed (+533 additions, -131 deletions)

View changed files

📝 packages/api/package.json (+1 -1)
📝 packages/cli/package.json (+1 -1)
📝 packages/desktop-client/package.json (+2 -1)
📝 packages/desktop-client/src/components/budget/goals/CategoryAutomationButton.tsx (+114 -2)
📝 packages/desktop-client/src/components/modals/BudgetAutomationsModal/AutomationEditorPane.tsx (+56 -2)
📝 packages/desktop-client/src/components/modals/BudgetAutomationsModal/AutomationListRow.tsx (+15 -1)
📝 packages/desktop-client/src/components/modals/BudgetAutomationsModal/migrateTemplatesToAutomations.ts (+5 -0)
📝 packages/desktop-electron/package.json (+1 -1)
📝 packages/loot-core/package.json (+1 -1)
📝 packages/loot-core/src/server/budget/template-notes.test.ts (+129 -0)
📝 packages/loot-core/src/server/budget/template-notes.ts (+148 -117)
📝 packages/loot-core/src/server/forecast/app.test.ts (+44 -0)
📝 packages/loot-core/src/server/forecast/forecast-filters.ts (+2 -3)
📝 packages/loot-core/src/types/models/templates.ts (+1 -0)
📝 packages/sync-server/package.json (+1 -1)
➕ upcoming-release-notes/7906.md (+6 -0)
➕ upcoming-release-notes/7955.md (+6 -0)

📄 Description

Description

This PR adds support for per-automation notes/descriptions and improves the budget automation UI to display these notes in tooltips. It also fixes a bug in the forecast app where split parent transactions were being double-counted.

Key Changes

Automation Notes Feature:

  • Added description field to the Template type to store per-automation notes
  • Updated template parsing in getCategoriesWithTemplates() to capture non-directive lines directly above template directives as descriptions
  • Lines separated by blank lines or other directives are not attached as descriptions
  • Updated unparse() to serialize descriptions back to the note format
  • Added UI for editing automation notes in AutomationEditorPane
  • Enhanced CategoryAutomationButton to display automation notes in a tooltip on the budget page
  • Updated AutomationListRow to show notes in its tooltip

Forecast Bug Fix:

  • Fixed double-counting of split parent transactions in posted transaction balances by removing unnecessary ungrouping logic in forecast-filters.ts

Tests:

  • Added comprehensive test cases for description parsing (single-line, multi-line, blank line separation, multiple templates)
  • Added test cases for description serialization including blank line handling
  • Added test case for split transaction balance calculation

Related issue(s)

Relates to budget automation enhancements and forecast accuracy improvements.

Testing

  • Added unit tests covering description parsing and serialization in template-notes.test.ts
  • Added unit test for split transaction balance calculation in forecast/app.test.ts
  • Existing automation tests continue to pass with the new description field
  • Manual testing: Verify notes can be added/edited in the automation UI and display correctly in tooltips on the budget page

Checklist

  • Release notes added
  • No obvious regressions in affected areas
  • Self-review has been performed

https://claude.ai/code/session_01XGYzr6j3NKxpLUPAeYmQho

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 37 14.02 MB 0%
loot-core 1 5.34 MB 0%
api 2 3.96 MB 0%
cli 1 7.97 MB 0%
crdt 1 11.12 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
37 14.02 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.54 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ManageRules.js 46.98 kB 0%
static/js/PayeeRuleCountLabel.js 7.33 kB 0%
static/js/ReportRouter.js 1.26 MB 0%
static/js/ScheduleEditForm.js 146.45 kB 0%
static/js/SchedulesTable.js 202.7 kB 0%
static/js/TransactionEdit.js 89.65 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 5.07 MB 0%
static/js/_baseIsEqual.js 98.02 kB 0%
static/js/ca.js 186.78 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.17 kB 0%
static/js/de.js 170.79 kB 0%
static/js/en-GB.js 9.25 kB 0%
static/js/en.js 198.13 kB 0%
static/js/es.js 178.71 kB 0%
static/js/extends.js 500.57 kB 0%
static/js/fr.js 178.61 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.02 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.08 kB 0%
static/js/nl.js 106.24 kB 0%
static/js/pt-BR.js 188.46 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.48 kB 0%
static/js/theme.js 31.77 kB 0%
static/js/toString.js 705.14 kB 0%
static/js/uk.js 207.49 kB 0%
static/js/useFormatList.js 2.52 kB 0%
static/js/useTransactionBatchActions.js 9.71 kB 0%
static/js/wide.js 296.1 kB 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 116.92 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.34 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.C_UHYSJL.js 5.34 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.96 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.96 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 11.12 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 11.12 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7987 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 5/28/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `release` --- ### 📝 Commits (3) - [`ead4081`](https://github.com/actualbudget/actual/commit/ead40810ba316f93ec294c21e30c63de64aa311b) 🔖 (26.6.0) - [`36d7a7d`](https://github.com/actualbudget/actual/commit/36d7a7d21ecadba6fd011744fbf6b821aef45b64) automation UI: add per-category notes and tooltip (#7906) - [`3ad3c21`](https://github.com/actualbudget/actual/commit/3ad3c21145bf8d0ddc889e642635a0f561325d7c) [AI] Fix split double-counting in balance forecast (#7955) (#7956) ### 📊 Changes **17 files changed** (+533 additions, -131 deletions) <details> <summary>View changed files</summary> 📝 `packages/api/package.json` (+1 -1) 📝 `packages/cli/package.json` (+1 -1) 📝 `packages/desktop-client/package.json` (+2 -1) 📝 `packages/desktop-client/src/components/budget/goals/CategoryAutomationButton.tsx` (+114 -2) 📝 `packages/desktop-client/src/components/modals/BudgetAutomationsModal/AutomationEditorPane.tsx` (+56 -2) 📝 `packages/desktop-client/src/components/modals/BudgetAutomationsModal/AutomationListRow.tsx` (+15 -1) 📝 `packages/desktop-client/src/components/modals/BudgetAutomationsModal/migrateTemplatesToAutomations.ts` (+5 -0) 📝 `packages/desktop-electron/package.json` (+1 -1) 📝 `packages/loot-core/package.json` (+1 -1) 📝 `packages/loot-core/src/server/budget/template-notes.test.ts` (+129 -0) 📝 `packages/loot-core/src/server/budget/template-notes.ts` (+148 -117) 📝 `packages/loot-core/src/server/forecast/app.test.ts` (+44 -0) 📝 `packages/loot-core/src/server/forecast/forecast-filters.ts` (+2 -3) 📝 `packages/loot-core/src/types/models/templates.ts` (+1 -0) 📝 `packages/sync-server/package.json` (+1 -1) ➕ `upcoming-release-notes/7906.md` (+6 -0) ➕ `upcoming-release-notes/7955.md` (+6 -0) </details> ### 📄 Description ## Description This PR adds support for per-automation notes/descriptions and improves the budget automation UI to display these notes in tooltips. It also fixes a bug in the forecast app where split parent transactions were being double-counted. ### Key Changes **Automation Notes Feature:** - Added `description` field to the `Template` type to store per-automation notes - Updated template parsing in `getCategoriesWithTemplates()` to capture non-directive lines directly above template directives as descriptions - Lines separated by blank lines or other directives are not attached as descriptions - Updated `unparse()` to serialize descriptions back to the note format - Added UI for editing automation notes in `AutomationEditorPane` - Enhanced `CategoryAutomationButton` to display automation notes in a tooltip on the budget page - Updated `AutomationListRow` to show notes in its tooltip **Forecast Bug Fix:** - Fixed double-counting of split parent transactions in posted transaction balances by removing unnecessary ungrouping logic in `forecast-filters.ts` **Tests:** - Added comprehensive test cases for description parsing (single-line, multi-line, blank line separation, multiple templates) - Added test cases for description serialization including blank line handling - Added test case for split transaction balance calculation ## Related issue(s) Relates to budget automation enhancements and forecast accuracy improvements. ## Testing - Added unit tests covering description parsing and serialization in `template-notes.test.ts` - Added unit test for split transaction balance calculation in `forecast/app.test.ts` - Existing automation tests continue to pass with the new description field - Manual testing: Verify notes can be added/edited in the automation UI and display correctly in tooltips on the budget page ## Checklist - [x] Release notes added - [x] No obvious regressions in affected areas - [x] Self-review has been performed https://claude.ai/code/session_01XGYzr6j3NKxpLUPAeYmQho <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 37 | 14.02 MB | 0% loot-core | 1 | 5.34 MB | 0% api | 2 | 3.96 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 11.12 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 37 | 14.02 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.54 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ManageRules.js | 46.98 kB | 0% static/js/PayeeRuleCountLabel.js | 7.33 kB | 0% static/js/ReportRouter.js | 1.26 MB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/SchedulesTable.js | 202.7 kB | 0% static/js/TransactionEdit.js | 89.65 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 5.07 MB | 0% static/js/_baseIsEqual.js | 98.02 kB | 0% static/js/ca.js | 186.78 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.17 kB | 0% static/js/de.js | 170.79 kB | 0% static/js/en-GB.js | 9.25 kB | 0% static/js/en.js | 198.13 kB | 0% static/js/es.js | 178.71 kB | 0% static/js/extends.js | 500.57 kB | 0% static/js/fr.js | 178.61 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.02 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.08 kB | 0% static/js/nl.js | 106.24 kB | 0% static/js/pt-BR.js | 188.46 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.48 kB | 0% static/js/theme.js | 31.77 kB | 0% static/js/toString.js | 705.14 kB | 0% static/js/uk.js | 207.49 kB | 0% static/js/useFormatList.js | 2.52 kB | 0% static/js/useTransactionBatchActions.js | 9.71 kB | 0% static/js/wide.js | 296.1 kB | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 116.92 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.34 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.C_UHYSJL.js | 5.34 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.96 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.96 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 11.12 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 11.12 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-30 07:41:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#105231
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?