github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7722] [MERGED] [AI] Stop mirroring transfer dates on linked transfer updates #105041

New Issue
Closed
opened 2026-05-30 07:11:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-30 07:11:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7722
Author: @StephenBrown2
Created: 5/5/2026
Status: ✅ Merged
Merged: 5/12/2026
Merged by: @youngcw

Base: master ← Head: allow-transfer-date-differ

📝 Commits (1)

  • f9cf050 [AI] No longer adjust date to match on transfers

📊 Changes

4 files changed (+48 additions, -58 deletions)

View changed files

📝 packages/loot-core/src/server/__snapshots__/main.test.ts.snap (+3 -8)
📝 packages/loot-core/src/server/transactions/__snapshots__/transfer.test.ts.snap (+39 -49)
📝 packages/loot-core/src/server/transactions/transfer.ts (+0 -1)
➕ upcoming-release-notes/7722.md (+6 -0)

📄 Description

Description

Transfer pairs created via the transfer payee flow are kept in sync for amount, notes, payee, account moves, and schedule, but dates no longer need to match on both sides. This change removes only the behavior that overwrote the opposite leg's date when one side of a linked transfer was updated (updateTransfer in packages/loot-core/src/server/transactions/transfer.ts). Other validation and transfer logic are unchanged.

Related issue(s)

Fixes #661

Testing

  • yarn workspace @actual-app/core test
  • Manually: create or link two transactions as a transfer with different dates; confirm both remain linked and amounts / opposite account behavior still correct; confirm editing one side does not overwrite the other side’s date.

Screenshots

  1. Created two transactions with different dates, then merged them:
    Screenshot_2026-05-05_11-40-21

2a. Created a single transfer transaction:
Screenshot_2026-05-05_11-41-38

2b. Then updated the date on one of them:
Screenshot_2026-05-05_11-42-27

Checklist

  • Release notes added (see Writing good release notes; consider yarn generate:release-notes before pushing)
  • No obvious regressions in affected areas (transfers, budget load tests, AQL executor tests)
  • Self-review has been performed — each change is understood and justified

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 34 13.93 MB 0%
loot-core 1 5.27 MB → 5.27 MB (-27 B) -0.00%
api 2 3.9 MB → 3.9 MB (-26 B) -0.00%
cli 1 7.97 MB 0%
crdt 1 43.7 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
34 13.93 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/index.js 1.93 MB 0%
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ReportRouter.js 1.22 MB 0%
static/js/ScheduleEditForm.js 145.68 kB 0%
static/js/TransactionEdit.js 189.54 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/Value.js 4.94 MB 0%
static/js/alerts.js 800.08 kB 0%
static/js/bankSyncUtils.js 54.1 kB 0%
static/js/ca.js 187.91 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.38 kB 0%
static/js/de.js 170.55 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 185.11 kB 0%
static/js/es.js 179 kB 0%
static/js/extends.js 520.63 kB 0%
static/js/fr.js 178.9 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.01 kB 0%
static/js/narrow.js 364.41 kB 0%
static/js/nb-NO.js 148.31 kB 0%
static/js/nl.js 106.47 kB 0%
static/js/pl.js 86.52 kB 0%
static/js/pt-BR.js 189.58 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.76 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 207.75 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.91 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.27 MB → 5.27 MB (-27 B) -0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transfer.ts 📉 -27 B (-0.71%) 3.71 kB → 3.68 kB
View detailed bundle breakdown

Added

Asset File Size % Changed
kcab.worker.CBFVZ2-G.js 0 B → 5.27 MB (+5.27 MB) -

Removed

Asset File Size % Changed
kcab.worker.DbAkUAmB.js 5.27 MB → 0 B (-5.27 MB) -100%

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged
No assets were unchanged

api

Total

Files count Total bundle size % Changed
2 3.9 MB → 3.9 MB (-26 B) -0.00%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transfer.ts 📉 -26 B (-0.70%) 3.61 kB → 3.58 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller

Asset File Size % Changed
index.js 3.9 MB → 3.9 MB (-26 B) -0.00%

Unchanged

Asset File Size % Changed
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 43.7 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 43.7 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7722 **Author:** [@StephenBrown2](https://github.com/StephenBrown2) **Created:** 5/5/2026 **Status:** ✅ Merged **Merged:** 5/12/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `allow-transfer-date-differ` --- ### 📝 Commits (1) - [`f9cf050`](https://github.com/actualbudget/actual/commit/f9cf050f3910f1047e2a6541219001f2b6caa6b9) [AI] No longer adjust date to match on transfers ### 📊 Changes **4 files changed** (+48 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `packages/loot-core/src/server/__snapshots__/main.test.ts.snap` (+3 -8) 📝 `packages/loot-core/src/server/transactions/__snapshots__/transfer.test.ts.snap` (+39 -49) 📝 `packages/loot-core/src/server/transactions/transfer.ts` (+0 -1) ➕ `upcoming-release-notes/7722.md` (+6 -0) </details> ### 📄 Description ## Description Transfer pairs created via the transfer payee flow are kept in sync for amount, notes, payee, account moves, and schedule, but dates no longer need to match on both sides. This change removes only the behavior that overwrote the opposite leg's date when one side of a linked transfer was updated (`updateTransfer` in `packages/loot-core/src/server/transactions/transfer.ts`). Other validation and transfer logic are unchanged. ## Related issue(s) Fixes #661 ## Testing - `yarn workspace @actual-app/core test` - Manually: create or link two transactions as a transfer with **different** dates; confirm both remain linked and amounts / opposite account behavior still correct; confirm editing one side does not overwrite the other side’s date. ### Screenshots 1. Created two transactions with different dates, then merged them: <img width="1186" height="61" alt="Screenshot_2026-05-05_11-40-21" src="https://github.com/user-attachments/assets/bad3cb68-bb1c-4b05-a0e9-9d81b3b25ad3" /> 2a. Created a single transfer transaction: <img width="1186" height="67" alt="Screenshot_2026-05-05_11-41-38" src="https://github.com/user-attachments/assets/84129238-609b-4eda-90df-ba31e9e6be66" /> 2b. Then updated the date on one of them: <img width="1186" height="133" alt="Screenshot_2026-05-05_11-42-27" src="https://github.com/user-attachments/assets/de1d7add-5a2f-4d96-be4d-27156b500e55" /> ## Checklist - [x] Release notes added (see [Writing good release notes](https://actualbudget.org/docs/contributing/#writing-good-release-notes); consider `yarn generate:release-notes` before pushing) - [x] No obvious regressions in affected areas (transfers, budget load tests, AQL executor tests) - [x] Self-review has been performed — each change is understood and justified <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 34 | 13.93 MB | 0% loot-core | 1 | 5.27 MB → 5.27 MB (-27 B) | -0.00% api | 2 | 3.9 MB → 3.9 MB (-26 B) | -0.00% cli | 1 | 7.97 MB | 0% crdt | 1 | 43.7 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 34 | 13.93 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.93 MB | 0% static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ReportRouter.js | 1.22 MB | 0% static/js/ScheduleEditForm.js | 145.68 kB | 0% static/js/TransactionEdit.js | 189.54 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/Value.js | 4.94 MB | 0% static/js/alerts.js | 800.08 kB | 0% static/js/bankSyncUtils.js | 54.1 kB | 0% static/js/ca.js | 187.91 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.38 kB | 0% static/js/de.js | 170.55 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 185.11 kB | 0% static/js/es.js | 179 kB | 0% static/js/extends.js | 520.63 kB | 0% static/js/fr.js | 178.9 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.01 kB | 0% static/js/narrow.js | 364.41 kB | 0% static/js/nb-NO.js | 148.31 kB | 0% static/js/nl.js | 106.47 kB | 0% static/js/pl.js | 86.52 kB | 0% static/js/pt-BR.js | 189.58 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.76 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 207.75 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.91 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.27 MB → 5.27 MB (-27 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transfer.ts` | 📉 -27 B (-0.71%) | 3.71 kB → 3.68 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.CBFVZ2-G.js | 0 B → 5.27 MB (+5.27 MB) | - **Removed** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.DbAkUAmB.js | 5.27 MB → 0 B (-5.27 MB) | -100% **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** No assets were unchanged </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.9 MB → 3.9 MB (-26 B) | -0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/transactions/transfer.ts` | 📉 -26 B (-0.70%) | 3.61 kB → 3.58 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.9 MB → 3.9 MB (-26 B) | -0.00% **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 43.7 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 43.7 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-30 07:11:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#105041
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?