github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-11-14 21:15:41 -06:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #7521] [MERGED] [AI] fix: allow clearing pre-assigned category on new transactions #104921

New Issue
Closed
opened 2026-05-30 06:56:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-30 06:56:14 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/7521
Author: @yosofbadr
Created: 4/15/2026
Status: ✅ Merged
Merged: 5/12/2026
Merged by: @youngcw

Base: master ← Head: fix/clear-pre-assigned-category

📝 Commits (10+)

  • 45473f8 [AI] fix: allow clearing pre-assigned category on new transactions
  • a920b0a [AI] docs: add release notes for PR #7521
  • 9adb40a [AI] chore: re-trigger CI for flaky test
  • 9b6c0b0 chore: retrigger CI (flaky api test)
  • 959acdc Merge branch 'master' into fix/clear-pre-assigned-category
  • 51f40a2 Merge branch 'master' into fix/clear-pre-assigned-category
  • 847d29a Merge branch 'master' into fix/clear-pre-assigned-category
  • acf850b fix type issue, better text
  • 5099362 Merge remote-tracking branch 'origin' into fix/clear-pre-assigned-category
  • 053b60f more type fixes

📊 Changes

6 files changed (+34 additions, -3 deletions)

View changed files

📝 packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx (+6 -1)
📝 packages/desktop-client/src/components/modals/CategoryAutocompleteModal.tsx (+16 -1)
📝 packages/desktop-client/src/components/util/GenericInput.tsx (+3 -0)
📝 packages/desktop-client/src/hooks/useTransactionBatchActions.ts (+1 -0)
📝 packages/desktop-client/src/modals/modalsSlice.ts (+2 -1)
➕ upcoming-release-notes/7521.md (+6 -0)

📄 Description

Summary

  • Adds a "Nothing" button to the category autocomplete modal, allowing users to clear a pre-assigned category and leave the transaction uncategorized
  • Enabled for transaction editing (mobile) and batch transaction editing flows
  • Updates the onSelect type in the modal options to accept null for the category ID

Closes #7390

Test plan

  • Add a payee with a pre-assigned category
  • Create a new transaction with that payee
  • Open the category picker and verify the "Nothing" button appears at the bottom
  • Tap "Nothing" and verify the category is cleared (transaction saved as uncategorized)
  • Verify that the "Nothing" button does not appear in cover/transfer modals (budget page)
  • Verify batch editing category still works and also shows the "Nothing" option

Bundle Stats

Bundle Files count Total bundle size % Changed
desktop-client 33 13.91 MB → 13.91 MB (+629 B) +0.00%
loot-core 1 5.28 MB 0%
api 2 3.9 MB 0%
cli 1 7.97 MB 0%
crdt 1 43.41 kB 0%
View detailed bundle stats

desktop-client

Total

Files count Total bundle size % Changed
33 13.91 MB → 13.91 MB (+629 B) +0.00%
Changeset
File Δ Size
src/components/modals/CategoryAutocompleteModal.tsx 📈 +530 B (+16.40%) 3.16 kB → 3.67 kB
src/hooks/useTransactionBatchActions.ts 📈 +27 B (+0.30%) 8.66 kB → 8.69 kB
src/components/util/GenericInput.tsx 📈 +42 B (+0.24%) 17.22 kB → 17.27 kB
src/components/mobile/transactions/TransactionEdit.tsx 📈 +30 B (+0.05%) 64.06 kB → 64.09 kB
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 1.97 MB → 1.97 MB (+530 B) +0.03%
static/js/Value.js 4.96 MB → 4.96 MB (+69 B) +0.00%
static/js/TransactionEdit.js 190.4 kB → 190.43 kB (+30 B) +0.02%

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
static/js/BackgroundImage.js 121.09 kB 0%
static/js/FormulaEditor.js 962.55 kB 0%
static/js/ReportRouter.js 1.22 MB 0%
static/js/ScheduleEditForm.js 146.45 kB 0%
static/js/TransactionList.js 85.81 kB 0%
static/js/bankSyncUtils.js 54.15 kB 0%
static/js/ca.js 187.76 kB 0%
static/js/chart-theme.js 800.08 kB 0%
static/js/client.js 451.37 kB 0%
static/js/da.js 101.28 kB 0%
static/js/de.js 170.42 kB 0%
static/js/en-GB.js 8.2 kB 0%
static/js/en.js 190.1 kB 0%
static/js/es.js 178.87 kB 0%
static/js/extends.js 519.29 kB 0%
static/js/fr.js 178.76 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.46 kB 0%
static/js/it.js 165.17 kB 0%
static/js/narrow.js 364.2 kB 0%
static/js/nb-NO.js 148.23 kB 0%
static/js/nl.js 106.39 kB 0%
static/js/pt-BR.js 189.45 kB 0%
static/js/resize-observer.js 18.06 kB 0%
static/js/th.js 174.62 kB 0%
static/js/theme.js 31.67 kB 0%
static/js/uk.js 207.63 kB 0%
static/js/useFormatList.js 4.96 kB 0%
static/js/wide.js 453 B 0%
static/js/workbox-window.prod.es5.js 7.33 kB 0%
static/js/zh-Hans.js 117.79 kB 0%

loot-core

Total

Files count Total bundle size % Changed
1 5.28 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.CDdN9TXh.js 5.28 MB 0%

api

Total

Files count Total bundle size % Changed
2 3.9 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 3.9 MB 0%
models.js 0 B 0%

cli

Total

Files count Total bundle size % Changed
1 7.97 MB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
cli.js 7.97 MB 0%

crdt

Total

Files count Total bundle size % Changed
1 43.41 kB 0%
View detailed bundle breakdown

Added
No assets were added

Removed
No assets were removed

Bigger
No assets were bigger

Smaller
No assets were smaller

Unchanged

Asset File Size % Changed
index.js 43.41 kB 0%

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/7521 **Author:** [@yosofbadr](https://github.com/yosofbadr) **Created:** 4/15/2026 **Status:** ✅ Merged **Merged:** 5/12/2026 **Merged by:** [@youngcw](https://github.com/youngcw) **Base:** `master` ← **Head:** `fix/clear-pre-assigned-category` --- ### 📝 Commits (10+) - [`45473f8`](https://github.com/actualbudget/actual/commit/45473f84fb6ea2181f78205de527187c9c9983c9) [AI] fix: allow clearing pre-assigned category on new transactions - [`a920b0a`](https://github.com/actualbudget/actual/commit/a920b0ae8d0a55f562eae54a0aef8edada49e3ee) [AI] docs: add release notes for PR #7521 - [`9adb40a`](https://github.com/actualbudget/actual/commit/9adb40adee31fde5cb3c862b6f4092451d8ad44f) [AI] chore: re-trigger CI for flaky test - [`9b6c0b0`](https://github.com/actualbudget/actual/commit/9b6c0b0853e43643c46e0b328d677d59514f850a) chore: retrigger CI (flaky api test) - [`959acdc`](https://github.com/actualbudget/actual/commit/959acdc9c0e92b848cc8c45803aab13d8b61e8fb) Merge branch 'master' into fix/clear-pre-assigned-category - [`51f40a2`](https://github.com/actualbudget/actual/commit/51f40a269ee65acc88180f2181571eaf35b166fc) Merge branch 'master' into fix/clear-pre-assigned-category - [`847d29a`](https://github.com/actualbudget/actual/commit/847d29a084f10ae6f4d2df825990ef09f04e8925) Merge branch 'master' into fix/clear-pre-assigned-category - [`acf850b`](https://github.com/actualbudget/actual/commit/acf850b251e7aa979adaba99848c2447172b7650) fix type issue, better text - [`5099362`](https://github.com/actualbudget/actual/commit/5099362f8232d96063056ee72f5643fbd42d548b) Merge remote-tracking branch 'origin' into fix/clear-pre-assigned-category - [`053b60f`](https://github.com/actualbudget/actual/commit/053b60f7b0179a6952504310f2477c70ce79de28) more type fixes ### 📊 Changes **6 files changed** (+34 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx` (+6 -1) 📝 `packages/desktop-client/src/components/modals/CategoryAutocompleteModal.tsx` (+16 -1) 📝 `packages/desktop-client/src/components/util/GenericInput.tsx` (+3 -0) 📝 `packages/desktop-client/src/hooks/useTransactionBatchActions.ts` (+1 -0) 📝 `packages/desktop-client/src/modals/modalsSlice.ts` (+2 -1) ➕ `upcoming-release-notes/7521.md` (+6 -0) </details> ### 📄 Description ## Summary - Adds a "Nothing" button to the category autocomplete modal, allowing users to clear a pre-assigned category and leave the transaction uncategorized - Enabled for transaction editing (mobile) and batch transaction editing flows - Updates the `onSelect` type in the modal options to accept `null` for the category ID Closes #7390 ## Test plan - [x] Add a payee with a pre-assigned category - [x] Create a new transaction with that payee - [x] Open the category picker and verify the "Nothing" button appears at the bottom - [x] Tap "Nothing" and verify the category is cleared (transaction saved as uncategorized) - [x] Verify that the "Nothing" button does not appear in cover/transfer modals (budget page) - [x] Verify batch editing category still works and also shows the "Nothing" option <!--- actual-bot-sections ---> <hr /> <!--- bundlestats-action-comment key:combined start ---> ### Bundle Stats Bundle | Files count | Total bundle size | % Changed ------ | ----------- | ----------------- | --------- desktop-client | 33 | 13.91 MB → 13.91 MB (+629 B) | +0.00% loot-core | 1 | 5.28 MB | 0% api | 2 | 3.9 MB | 0% cli | 1 | 7.97 MB | 0% crdt | 1 | 43.41 kB | 0% <details> <summary>View detailed bundle stats</summary> #### desktop-client **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 33 | 13.91 MB → 13.91 MB (+629 B) | +0.00% <details> <summary>Changeset</summary> File | Δ | Size ---- | - | ---- `src/components/modals/CategoryAutocompleteModal.tsx` | 📈 +530 B (+16.40%) | 3.16 kB → 3.67 kB `src/hooks/useTransactionBatchActions.ts` | 📈 +27 B (+0.30%) | 8.66 kB → 8.69 kB `src/components/util/GenericInput.tsx` | 📈 +42 B (+0.24%) | 17.22 kB → 17.27 kB `src/components/mobile/transactions/TransactionEdit.tsx` | 📈 +30 B (+0.05%) | 64.06 kB → 64.09 kB </details> <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** Asset | File Size | % Changed ----- | --------- | --------- static/js/index.js | 1.97 MB → 1.97 MB (+530 B) | +0.03% static/js/Value.js | 4.96 MB → 4.96 MB (+69 B) | +0.00% static/js/TransactionEdit.js | 190.4 kB → 190.43 kB (+30 B) | +0.02% **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- static/js/BackgroundImage.js | 121.09 kB | 0% static/js/FormulaEditor.js | 962.55 kB | 0% static/js/ReportRouter.js | 1.22 MB | 0% static/js/ScheduleEditForm.js | 146.45 kB | 0% static/js/TransactionList.js | 85.81 kB | 0% static/js/bankSyncUtils.js | 54.15 kB | 0% static/js/ca.js | 187.76 kB | 0% static/js/chart-theme.js | 800.08 kB | 0% static/js/client.js | 451.37 kB | 0% static/js/da.js | 101.28 kB | 0% static/js/de.js | 170.42 kB | 0% static/js/en-GB.js | 8.2 kB | 0% static/js/en.js | 190.1 kB | 0% static/js/es.js | 178.87 kB | 0% static/js/extends.js | 519.29 kB | 0% static/js/fr.js | 178.76 kB | 0% static/js/indexeddb-main-thread-worker-e59fee74.js | 13.46 kB | 0% static/js/it.js | 165.17 kB | 0% static/js/narrow.js | 364.2 kB | 0% static/js/nb-NO.js | 148.23 kB | 0% static/js/nl.js | 106.39 kB | 0% static/js/pt-BR.js | 189.45 kB | 0% static/js/resize-observer.js | 18.06 kB | 0% static/js/th.js | 174.62 kB | 0% static/js/theme.js | 31.67 kB | 0% static/js/uk.js | 207.63 kB | 0% static/js/useFormatList.js | 4.96 kB | 0% static/js/wide.js | 453 B | 0% static/js/workbox-window.prod.es5.js | 7.33 kB | 0% static/js/zh-Hans.js | 117.79 kB | 0% </div> </details> --- #### loot-core **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 5.28 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- kcab.worker.CDdN9TXh.js | 5.28 MB | 0% </div> </details> --- #### api **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 2 | 3.9 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 3.9 MB | 0% models.js | 0 B | 0% </div> </details> --- #### cli **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 7.97 MB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- cli.js | 7.97 MB | 0% </div> </details> --- #### crdt **Total** Files count | Total bundle size | % Changed ----------- | ----------------- | --------- 1 | 43.41 kB | 0% <details> <summary>View detailed bundle breakdown</summary> <div> **Added** No assets were added **Removed** No assets were removed **Bigger** No assets were bigger **Smaller** No assets were smaller **Unchanged** Asset | File Size | % Changed ----- | --------- | --------- index.js | 43.41 kB | 0% </div> </details> </details> <!--- bundlestats-action-comment key:combined end ---> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-30 06:56:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#104921