github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[Bug]: "," separator not handled in split amount fields #1047

New Issue
Closed
opened 2026-02-28 19:29:57 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-02-28 19:29:57 -06:00
Owner
Copy Link

Originally created by @joklek on GitHub (Apr 18, 2024).

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

On iOS Safari, New Transaction screen, amount field uses the numerical keyboard. On my locale the decimal separator is ",". Entering amounts like "12.34" works fine, as Actual converts the comma into a dot separator after I finish entering the amount.

The bug happens if I try to split the transaction. When entering amount into the split amount field, it no longer handles "," as a separator, and just deletes it from a number. "12.34" becomes "1234", which is then very hard to edit. Same bug is reproducible in Transactions view on Desktop, not logging a new bug yet because I don't know how components reused, might be the same thing as here.

Client version: v24.4.0

Where are you hosting Actual?

None

What browsers are you seeing the problem on?

Safari

Operating System

Mobile Device

EDIT: From the first look this is what handles my happy case

407ad4deee/packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx (L70)

Originally created by @joklek on GitHub (Apr 18, 2024). ### Verified issue does not already exist? - [X] I have searched and found no existing issue - [X] I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file) ### What happened? On iOS Safari, New Transaction screen, amount field uses the numerical keyboard. On my locale the decimal separator is ",". Entering amounts like "12.34" works fine, as Actual converts the comma into a dot separator after I finish entering the amount. The bug happens if I try to split the transaction. When entering amount into the split amount field, it no longer handles "," as a separator, and just deletes it from a number. "12.34" becomes "1234", which is then very hard to edit. Same bug is reproducible in Transactions view on Desktop, not logging a new bug yet because I don't know how components reused, might be the same thing as here. Client version: v24.4.0 ### Where are you hosting Actual? None ### What browsers are you seeing the problem on? Safari ### Operating System Mobile Device EDIT: From the first look this is what handles my happy case https://github.com/actualbudget/actual/blob/407ad4deeee9077ce0060d2f5852a43bc369a8a7/packages/desktop-client/src/components/mobile/transactions/FocusableAmountInput.tsx#L70
GiteaMirror added the bug label 2026-02-28 19:29:57 -06:00
GiteaMirror commented 2026-02-28 19:29:58 -06:00
Author
Owner
Copy Link

@Wizmaster commented on GitHub (Apr 27, 2024):

Hello @joklek

If I understand correctly your issue, you are running Actual with a number format set to dot as decimal separator on a device with the comma separator set in the locale settings.
I believe the easiest would be to set Actual to also use comma as a decimal separator, something you can do in the Settings on the mobile device.

I was working on a feature rather close to your issue, allowing to use comma or dot decimal separator for locales where it's not used as a thousand separator, maybe it could also fit your use-case?
You can test it on #2672

@Wizmaster commented on GitHub (Apr 27, 2024): Hello @joklek If I understand correctly your issue, you are running Actual with a number format set to dot as decimal separator on a device with the comma separator set in the locale settings. I believe the easiest would be to set Actual to also use comma as a decimal separator, something you can do in the Settings on the mobile device. I was working on a feature rather close to your issue, allowing to use comma or dot decimal separator for locales where it's not used as a thousand separator, maybe it could also fit your use-case? You can test it on #2672
GiteaMirror commented 2026-02-28 19:29:59 -06:00
Author
Owner
Copy Link

@joklek commented on GitHub (Apr 27, 2024):

@Wizmaster Hmm, somehow I missed the Actual settings for number formats. Will take a look at that and your PR. Closing bug

@joklek commented on GitHub (Apr 27, 2024): @Wizmaster Hmm, somehow I missed the Actual settings for number formats. Will take a look at that and your PR. Closing bug
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#1047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?