github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #791] [MERGED] nit: use curly apostrophes throughout the UI #10387

New Issue
Closed
opened 2026-04-10 20:31:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:31:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/791
Author: @j-f1
Created: 3/19/2023
Status: ✅ Merged
Merged: 3/21/2023
Merged by: @j-f1

Base: master ← Head: jed/typography

📝 Commits (10+)

  • 9d7fcab nit: use curly apostrophes throughout the UI
  • a6e3f96 + lint rule for curly quotes
  • 88e07b3 Precisely pinpoint quotes
  • a5c7158 Add more exceptions
  • c5b03d2 Release notes
  • 47de64b Fix the reported issues! (or ignore them)
  • 8239a26 clarify that they’re preferred in user-visible text only
  • 7e5c9e5 Merge branch 'master' into jed/typography
  • e467b54 Fix new violation
  • 4f6acc2 Fix deprecated API usage in rule

📊 Changes

88 files changed (+655 additions, -181 deletions)

View changed files

📝 .eslintrc.js (+14 -1)
📝 package.json (+1 -0)
📝 packages/desktop-client/src/components/FatalError.js (+4 -4)
📝 packages/desktop-client/src/components/MobileWebMessage.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/Account.js (+2 -2)
📝 packages/desktop-client/src/components/accounts/AccountSyncCheck.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/TransactionsTable.test.js (+1 -1)
📝 packages/desktop-client/src/components/budget/MobileBudget.js (+1 -1)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+1 -0)
📝 packages/desktop-client/src/components/manager/ConfigServer.js (+2 -2)
📝 packages/desktop-client/src/components/modals/CreateEncryptionKey.js (+2 -2)
📝 packages/desktop-client/src/components/modals/FixEncryptionKey.js (+2 -2)
📝 packages/desktop-client/src/components/modals/ManageRulesModal.js (+1 -1)
📝 packages/desktop-client/src/components/reports/CashFlow.js (+1 -1)
📝 packages/desktop-client/src/components/reports/NetWorth.js (+2 -2)
📝 packages/desktop-client/src/components/reports/Tooltip.js (+1 -0)
📝 packages/desktop-client/src/components/reports/chart-theme.js (+1 -1)
📝 packages/desktop-client/src/components/reports/graphs/CashFlowGraph.js (+1 -0)
📝 packages/desktop-client/src/components/reports/graphs/NetWorthGraph.js (+1 -0)
📝 packages/desktop-client/src/components/schedules/DiscoverSchedules.js (+2 -2)

...and 68 more files

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/791 **Author:** [@j-f1](https://github.com/j-f1) **Created:** 3/19/2023 **Status:** ✅ Merged **Merged:** 3/21/2023 **Merged by:** [@j-f1](https://github.com/j-f1) **Base:** `master` ← **Head:** `jed/typography` --- ### 📝 Commits (10+) - [`9d7fcab`](https://github.com/actualbudget/actual/commit/9d7fcabe9e332da17216e7de8b97d426ed69de0e) nit: use curly apostrophes throughout the UI - [`a6e3f96`](https://github.com/actualbudget/actual/commit/a6e3f963a214807b83eca02191d03986973932b7) + lint rule for curly quotes - [`88e07b3`](https://github.com/actualbudget/actual/commit/88e07b32ec928e5897893721ff4d454ded8bdd53) Precisely pinpoint quotes - [`a5c7158`](https://github.com/actualbudget/actual/commit/a5c715883cf089934e45df168cf5e0a58438a536) Add more exceptions - [`c5b03d2`](https://github.com/actualbudget/actual/commit/c5b03d21613339e0f1e479495a330f344b15d11e) Release notes - [`47de64b`](https://github.com/actualbudget/actual/commit/47de64b302daf92516a74248aeb810d34c615d1b) Fix the reported issues! (or ignore them) - [`8239a26`](https://github.com/actualbudget/actual/commit/8239a26004a064314a025900d89fadc9abbf2b7f) clarify that they’re preferred in user-visible text only - [`7e5c9e5`](https://github.com/actualbudget/actual/commit/7e5c9e572eba8f1ca0bb4e4ea43faa8d12e6505f) Merge branch 'master' into jed/typography - [`e467b54`](https://github.com/actualbudget/actual/commit/e467b547617f40495da43164343787fdca0d14cf) Fix new violation - [`4f6acc2`](https://github.com/actualbudget/actual/commit/4f6acc218d4e22d78055d88a78f0a1d7f5da6e8f) Fix deprecated API usage in rule ### 📊 Changes **88 files changed** (+655 additions, -181 deletions) <details> <summary>View changed files</summary> 📝 `.eslintrc.js` (+14 -1) 📝 `package.json` (+1 -0) 📝 `packages/desktop-client/src/components/FatalError.js` (+4 -4) 📝 `packages/desktop-client/src/components/MobileWebMessage.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+2 -2) 📝 `packages/desktop-client/src/components/accounts/AccountSyncCheck.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/TransactionsTable.test.js` (+1 -1) 📝 `packages/desktop-client/src/components/budget/MobileBudget.js` (+1 -1) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+1 -0) 📝 `packages/desktop-client/src/components/manager/ConfigServer.js` (+2 -2) 📝 `packages/desktop-client/src/components/modals/CreateEncryptionKey.js` (+2 -2) 📝 `packages/desktop-client/src/components/modals/FixEncryptionKey.js` (+2 -2) 📝 `packages/desktop-client/src/components/modals/ManageRulesModal.js` (+1 -1) 📝 `packages/desktop-client/src/components/reports/CashFlow.js` (+1 -1) 📝 `packages/desktop-client/src/components/reports/NetWorth.js` (+2 -2) 📝 `packages/desktop-client/src/components/reports/Tooltip.js` (+1 -0) 📝 `packages/desktop-client/src/components/reports/chart-theme.js` (+1 -1) 📝 `packages/desktop-client/src/components/reports/graphs/CashFlowGraph.js` (+1 -0) 📝 `packages/desktop-client/src/components/reports/graphs/NetWorthGraph.js` (+1 -0) 📝 `packages/desktop-client/src/components/schedules/DiscoverSchedules.js` (+2 -2) _...and 68 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:31:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#10387
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?