github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-07 04:18:51 -05:00
Code Issues 1.6k Packages Projects Releases 55 Wiki Activity

[PR #739] [CLOSED] Regex rules for matching #10348

New Issue
Closed
opened 2026-04-10 20:31:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:31:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/739
Author: @ostat
Created: 3/10/2023
Status: ❌ Closed

Base: master ← Head: regex_rules

📝 Commits (8)

  • b52c6ea WIP Regex rules
  • 7378207 regex unicode and ignore case support
  • d9176de Merge branch 'master' into regex_rules
  • 61ec068 correct regexp rule matching
  • 39ce95b style cleanup
  • f085958 lint fixes, capture regexp error
  • 9de67dd added PR release notes
  • 76b0139 single line release notes

📊 Changes

10 files changed (+102 additions, -4 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/EditRule.js (+1 -1)
📝 packages/loot-core/src/platform/server/sqlite/index.electron.ts (+6 -1)
📝 packages/loot-core/src/platform/server/sqlite/index.web.ts (+3 -0)
📝 packages/loot-core/src/server/accounts/rules.js (+31 -1)
📝 packages/loot-core/src/server/accounts/rules.test.js (+31 -0)
📝 packages/loot-core/src/server/accounts/transaction-rules.js (+2 -0)
📝 packages/loot-core/src/server/accounts/transaction-rules.test.js (+15 -0)
📝 packages/loot-core/src/server/aql/compiler.js (+4 -0)
📝 packages/loot-core/src/shared/rules.ts (+3 -1)
➕ upcoming-release-notes/739.md (+6 -0)

📄 Description

Resolves #500,

Allow the use of regex when creating rules.

image

image

Testing:
Create a new rule with the

  • field Imported Payee
  • condition matches
  • value '(company|store)'
    image

Import this test file
test-importfile.csv
image

Result
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/739 **Author:** [@ostat](https://github.com/ostat) **Created:** 3/10/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `regex_rules` --- ### 📝 Commits (8) - [`b52c6ea`](https://github.com/actualbudget/actual/commit/b52c6ea0a4f767e155a4f0d56ff31526d1014b34) WIP Regex rules - [`7378207`](https://github.com/actualbudget/actual/commit/7378207591822782708195d52bb7a7cbe35b03b6) regex unicode and ignore case support - [`d9176de`](https://github.com/actualbudget/actual/commit/d9176deb8067c5b124f5cbce5c680c437f0fca3d) Merge branch 'master' into regex_rules - [`61ec068`](https://github.com/actualbudget/actual/commit/61ec0685717472f3cdeac6b9415ea7901936891c) correct regexp rule matching - [`39ce95b`](https://github.com/actualbudget/actual/commit/39ce95b450bf02ada6f49ab3d706785f321e5413) style cleanup - [`f085958`](https://github.com/actualbudget/actual/commit/f0859588977e255f1a596f25a9117c9f84451830) lint fixes, capture regexp error - [`9de67dd`](https://github.com/actualbudget/actual/commit/9de67ddd587ef137e1858d790f7891a7db82676c) added PR release notes - [`76b0139`](https://github.com/actualbudget/actual/commit/76b0139b32d5639dd7e48c31dc26fade8b22ae99) single line release notes ### 📊 Changes **10 files changed** (+102 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/EditRule.js` (+1 -1) 📝 `packages/loot-core/src/platform/server/sqlite/index.electron.ts` (+6 -1) 📝 `packages/loot-core/src/platform/server/sqlite/index.web.ts` (+3 -0) 📝 `packages/loot-core/src/server/accounts/rules.js` (+31 -1) 📝 `packages/loot-core/src/server/accounts/rules.test.js` (+31 -0) 📝 `packages/loot-core/src/server/accounts/transaction-rules.js` (+2 -0) 📝 `packages/loot-core/src/server/accounts/transaction-rules.test.js` (+15 -0) 📝 `packages/loot-core/src/server/aql/compiler.js` (+4 -0) 📝 `packages/loot-core/src/shared/rules.ts` (+3 -1) ➕ `upcoming-release-notes/739.md` (+6 -0) </details> ### 📄 Description Resolves #500, Allow the use of regex when creating rules. ![image](https://user-images.githubusercontent.com/2128234/224438935-e9e17dde-ecf2-4d7f-9d06-6d61bd86c96d.png) ![image](https://user-images.githubusercontent.com/2128234/224438980-eefb68a0-a14e-4b18-8528-4fc62f69922c.png) **Testing:** Create a new rule with the - **field** `Imported Payee` - **condition** `matches` - **value** '(company|store)' ![image](https://user-images.githubusercontent.com/2128234/229979468-a2fce32c-70ee-4bd1-ab43-34da298ee180.png) Import this test file [test-importfile.csv](https://github.com/actualbudget/actual/files/11155136/test-importfile.csv) ![image](https://user-images.githubusercontent.com/2128234/229979785-55f47e7b-4251-45de-9e85-ea22c0293901.png) Result ![image](https://user-images.githubusercontent.com/2128234/229979817-2e1e3511-7e10-4213-8041-1b2d6504ccaa.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:31:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#10348
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?