github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 15:14:02 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #1542] [MERGED] Replace usage of glamor CSSProperties with React CSSProperties #101503

New Issue
Closed
opened 2026-05-29 23:03:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-05-29 23:03:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1542
Author: @joel-jeremy
Created: 8/18/2023
Status: ✅ Merged
Merged: 9/3/2023
Merged by: @joel-jeremy

Base: master ← Head: remove-glamor-cssproperties

📝 Commits (10+)

📊 Changes

100 files changed (+1310 additions, -1409 deletions)

View changed files

📝 packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-1-chromium-linux.png (+0 -0)
📝 packages/desktop-client/src/components/AnimatedRefresh.tsx (+3 -2)
📝 packages/desktop-client/src/components/DevelopmentTopBar.tsx (+11 -13)
📝 packages/desktop-client/src/components/LoggedInUser.tsx (+9 -11)
📝 packages/desktop-client/src/components/NotesButton.tsx (+11 -11)
📝 packages/desktop-client/src/components/Notifications.tsx (+8 -13)
📝 packages/desktop-client/src/components/Page.tsx (+20 -26)
📝 packages/desktop-client/src/components/Titlebar.tsx (+13 -16)
📝 packages/desktop-client/src/components/accounts/Account.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/Header.js (+1 -1)
📝 packages/desktop-client/src/components/accounts/MobileAccounts.js (+13 -17)
📝 packages/desktop-client/src/components/alerts.tsx (+18 -18)
📝 packages/desktop-client/src/components/autocomplete/AccountAutocomplete.js (+5 -7)
📝 packages/desktop-client/src/components/autocomplete/Autocomplete.tsx (+31 -35)
📝 packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx (+5 -7)
📝 packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js (+5 -4)
📝 packages/desktop-client/src/components/autocomplete/SavedFilterAutocomplete.js (+5 -4)
📝 packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx (+5 -5)
📝 packages/desktop-client/src/components/budget/BudgetSummaries.js (+5 -4)
📝 packages/desktop-client/src/components/budget/MobileBudgetTable.js (+94 -86)

...and 80 more files

📄 Description

Relates to #701

Gist of changes:

  • Replace usage of glamor's CSSProperties with custom CSSProperties that extends from React's.
  • Replace style={[...]} with style={{...}}
  • Replace usage of HTMLPropsWithStyle (which was created because of glamor's style typing) with React's HTMLProps
    - Still need to remove HTMLPropsWithStyle in View.tsx but I will put that in a separate PR to make review easier.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1542 **Author:** [@joel-jeremy](https://github.com/joel-jeremy) **Created:** 8/18/2023 **Status:** ✅ Merged **Merged:** 9/3/2023 **Merged by:** [@joel-jeremy](https://github.com/joel-jeremy) **Base:** `master` ← **Head:** `remove-glamor-cssproperties` --- ### 📝 Commits (10+) - [`8dcb372`](https://github.com/actualbudget/actual/commit/8dcb3723e86d89e343c9789cecfc0fd8295588cb) Remove usages of glamor CSSProperties - [`5b680af`](https://github.com/actualbudget/actual/commit/5b680af697437579356d6bf7cf65c4ad68d8ec42) Cleanup - [`c99222c`](https://github.com/actualbudget/actual/commit/c99222c14fefb0496d1c6d85c2f60dddac6f6d65) Re-add CellButton className prop - [`89a1615`](https://github.com/actualbudget/actual/commit/89a16150a684000aa1044a8f069f2785ab0c1a18) More removal of glamor CSSProperties - [`3461a05`](https://github.com/actualbudget/actual/commit/3461a053fec7650a3bbbb86a2daab08a3e599e17) Release notes - [`7ed4ea6`](https://github.com/actualbudget/actual/commit/7ed4ea62afb2f74bf2776dbd41e7f699de364334) Fix vrt test failures - [`312cccb`](https://github.com/actualbudget/actual/commit/312cccbe89106a6791304167b519f182f5211a1c) Use React CSSProperties in View - [`e529626`](https://github.com/actualbudget/actual/commit/e5296261cec509bd039d55147638ebc4063acf77) Custom CSSProperties type - [`2b171c6`](https://github.com/actualbudget/actual/commit/2b171c64f7dade2100926697c869edd1af131305) Settings UI regression fix - [`a300ee8`](https://github.com/actualbudget/actual/commit/a300ee8455d5dfdc2fb3fa493a166887b501d021) Fix type check errors ### 📊 Changes **100 files changed** (+1310 additions, -1409 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/e2e/rules.test.js-snapshots/Rules-creates-a-rule-and-makes-sure-it-is-applied-when-creating-a-transaction-1-chromium-linux.png` (+0 -0) 📝 `packages/desktop-client/src/components/AnimatedRefresh.tsx` (+3 -2) 📝 `packages/desktop-client/src/components/DevelopmentTopBar.tsx` (+11 -13) 📝 `packages/desktop-client/src/components/LoggedInUser.tsx` (+9 -11) 📝 `packages/desktop-client/src/components/NotesButton.tsx` (+11 -11) 📝 `packages/desktop-client/src/components/Notifications.tsx` (+8 -13) 📝 `packages/desktop-client/src/components/Page.tsx` (+20 -26) 📝 `packages/desktop-client/src/components/Titlebar.tsx` (+13 -16) 📝 `packages/desktop-client/src/components/accounts/Account.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/Header.js` (+1 -1) 📝 `packages/desktop-client/src/components/accounts/MobileAccounts.js` (+13 -17) 📝 `packages/desktop-client/src/components/alerts.tsx` (+18 -18) 📝 `packages/desktop-client/src/components/autocomplete/AccountAutocomplete.js` (+5 -7) 📝 `packages/desktop-client/src/components/autocomplete/Autocomplete.tsx` (+31 -35) 📝 `packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx` (+5 -7) 📝 `packages/desktop-client/src/components/autocomplete/PayeeAutocomplete.js` (+5 -4) 📝 `packages/desktop-client/src/components/autocomplete/SavedFilterAutocomplete.js` (+5 -4) 📝 `packages/desktop-client/src/components/budget/BalanceWithCarryover.tsx` (+5 -5) 📝 `packages/desktop-client/src/components/budget/BudgetSummaries.js` (+5 -4) 📝 `packages/desktop-client/src/components/budget/MobileBudgetTable.js` (+94 -86) _...and 80 more files_ </details> ### 📄 Description <!-- Thank you for submitting a pull request! Make sure to follow the instructions to write release notes for your PR — it should only take a minute or two: https://github.com/actualbudget/docs#writing-good-release-notes --> Relates to #701 Gist of changes: - Replace usage of glamor's `CSSProperties` with custom `CSSProperties` that extends from React's. - Replace `style={[...]}` with `style={{...}}` - Replace usage of `HTMLPropsWithStyle` (which was created because of glamor's style typing) with React's `HTMLProps` ~~- Still need to remove `HTMLPropsWithStyle` in `View.tsx` but I will put that in a separate PR to make review easier.~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-05-29 23:03:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#101503
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?