From f07ad1f8c6dc501e000186a14bda7b916eaa8277 Mon Sep 17 00:00:00 2001
From: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
Date: Fri, 17 Jan 2025 09:26:47 -0800
Subject: [PATCH] [TypeScript] Add types to loot-core app (#4155)

* Add types to loot-core app

* Release notes

---------

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>
---
 packages/loot-core/src/server/app.ts | 11 +++++++----
 upcoming-release-notes/4155.md       |  6 ++++++
 2 files changed, 13 insertions(+), 4 deletions(-)
 create mode 100644 upcoming-release-notes/4155.md

diff --git a/packages/loot-core/src/server/app.ts b/packages/loot-core/src/server/app.ts
index a8005a25fb..38a9e01fe1 100644
--- a/packages/loot-core/src/server/app.ts
+++ b/packages/loot-core/src/server/app.ts
@@ -14,16 +14,19 @@ type Events = {
   'load-budget': { id: string };
 };
 
+type UnlistenService = () => void;
+type Service = () => UnlistenService;
+
 class App<Handlers> {
   events: Emitter<Events>;
   handlers: Handlers;
-  services;
-  unlistenServices;
+  services: Service[];
+  unlistenServices: UnlistenService[];
 
   constructor() {
     this.handlers = {} as Handlers;
     this.services = [];
-    this.events = mitt();
+    this.events = mitt<Events>();
     this.unlistenServices = [];
   }
 
@@ -39,7 +42,7 @@ class App<Handlers> {
     this.handlers[name] = func;
   }
 
-  service(func) {
+  service(func: Service) {
     this.services.push(func);
   }
 
diff --git a/upcoming-release-notes/4155.md b/upcoming-release-notes/4155.md
new file mode 100644
index 0000000000..1b50cad187
--- /dev/null
+++ b/upcoming-release-notes/4155.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [joel-jeremy]
+---
+
+Add types to loot-core app