From db68170cce073853152cfeecc0d3fdd47fa86e87 Mon Sep 17 00:00:00 2001 From: Greg Lorenzen <31518305+glorenzen@users.noreply.github.com> Date: Tue, 12 Nov 2024 11:05:35 -0800 Subject: [PATCH] Translation: desktop-client/components/payees/PayeeMenu (#3670) * Translation: desktop-client/components/payees/PayeeMenu * Add release notes * Merge master * Remove dynamic values from selected payee translation --- .../src/components/payees/PayeeMenu.tsx | 12 ++++++++---- upcoming-release-notes/3670.md | 6 ++++++ 2 files changed, 14 insertions(+), 4 deletions(-) create mode 100644 upcoming-release-notes/3670.md diff --git a/packages/desktop-client/src/components/payees/PayeeMenu.tsx b/packages/desktop-client/src/components/payees/PayeeMenu.tsx index c9229e1a99..514b7ae0ae 100644 --- a/packages/desktop-client/src/components/payees/PayeeMenu.tsx +++ b/packages/desktop-client/src/components/payees/PayeeMenu.tsx @@ -1,3 +1,5 @@ +import { useTranslation } from 'react-i18next'; + import { type PayeeEntity } from 'loot-core/src/types/models'; import { SvgDelete, SvgMerge } from '../../icons/v0'; @@ -23,6 +25,8 @@ export function PayeeMenu({ onFavorite, onClose, }: PayeeMenuProps) { + const { t } = useTranslation(); + // Transfer accounts are never editable const isDisabled = [...selectedPayees].some( id => payeesById[id] == null || payeesById[id].transfer_acct, @@ -57,28 +61,28 @@ export function PayeeMenu({ {[...selectedPayees] .slice(0, 4) .map(id => payeesById[id].name) - .join(', ') + (selectedPayees.size > 4 ? ', and more' : '')} + .join(', ') + (selectedPayees.size > 4 ? t(', and more') : '')} } items={[ { icon: SvgDelete, name: 'delete', - text: 'Delete', + text: t('Delete'), disabled: isDisabled, }, { icon: SvgBookmark, iconSize: 9, name: 'favorite', - text: 'Favorite', + text: t('Favorite'), disabled: isDisabled, }, { icon: SvgMerge, iconSize: 9, name: 'merge', - text: 'Merge', + text: t('Merge'), disabled: isDisabled || selectedPayees.size < 2, }, Menu.line, diff --git a/upcoming-release-notes/3670.md b/upcoming-release-notes/3670.md new file mode 100644 index 0000000000..2e658ceec8 --- /dev/null +++ b/upcoming-release-notes/3670.md @@ -0,0 +1,6 @@ +--- +category: Enhancements +authors: [glorenzen] +--- + +Support translations in packages/desktop-client/src/components/payees/PayeeMenu.tsx. \ No newline at end of file