github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-04-30 10:14:53 -05:00
Code Issues 1.3k Packages Projects Releases 54 Wiki Activity

♻️ (eslint) disallow importing actual-app/web in loot-core (#4347)

Browse Source
This commit is contained in:
Matiss Janis Aboltins
2025-02-11 18:22:09 +00:00
committed by GitHub
parent 7d9190ea9c
commit be1c194eb4
5 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
eslint.config.mjs
View File

@@ -671,7 +671,6 @@ export default [
}, },
{ {
files: ['packages/loot-core/src/**/*'], files: ['packages/loot-core/src/**/*'],
rules: { rules: {
'no-restricted-imports': [ 'no-restricted-imports': [
'warn', 'warn',
@@ -691,6 +690,10 @@ export default [
message: message:
'Please use relative imports in loot-core instead of importing from `loot-core/*`', 'Please use relative imports in loot-core instead of importing from `loot-core/*`',
}, },
{
group: ['@actual-app/web/*'],
message: 'Please do not import `@actual-app/web` in `loot-core`',
},
], ],
}, },
], ],

1
packages/loot-core/src/client/actions/prefs.ts
View File

@@ -1,3 +1,4 @@
// eslint-disable-next-line no-restricted-imports -- fix me -- do not import @actual-app/web in loot-core
import { setI18NextLanguage } from '@actual-app/web/src/i18n'; import { setI18NextLanguage } from '@actual-app/web/src/i18n';
import { send } from '../../platform/client/fetch'; import { send } from '../../platform/client/fetch';

1
packages/loot-core/src/client/data-hooks/schedules.tsx
View File

@@ -8,6 +8,7 @@ import React, {
useState, useState,
} from 'react'; } from 'react';
// eslint-disable-next-line no-restricted-imports -- fix me -- do not import @actual-app/web in loot-core
import { useSyncedPref } from '@actual-app/web/src/hooks/useSyncedPref'; import { useSyncedPref } from '@actual-app/web/src/hooks/useSyncedPref';
import { q, type Query } from '../../shared/query'; import { q, type Query } from '../../shared/query';

1
packages/loot-core/src/client/data-hooks/transactions.ts
View File

@@ -1,5 +1,6 @@
import { useEffect, useRef, useState, useMemo, useCallback } from 'react'; import { useEffect, useRef, useState, useMemo, useCallback } from 'react';
// eslint-disable-next-line no-restricted-imports -- fix me -- do not import @actual-app/web in loot-core
import { useSyncedPref } from '@actual-app/web/src/hooks/useSyncedPref'; import { useSyncedPref } from '@actual-app/web/src/hooks/useSyncedPref';
import * as d from 'date-fns'; import * as d from 'date-fns';
import debounce from 'lodash/debounce'; import debounce from 'lodash/debounce';

6
upcoming-release-notes/4347.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [MatissJanis]
---
Disallow importing `@actual-app/web` in `loot-core` - circular dependencies.