mirror of
https://github.com/actualbudget/actual.git
synced 2026-04-29 19:14:22 -05:00
test: use local dev server for e2e tests (#6388)
* fix: use start:browser for playwright webServer to load correct browser-preload The playwright webServer was running 'yarn start' which doesn't set IS_GENERIC_BROWSER, causing Vite to not resolve .browser.js files. This resulted in browser-preload.js (empty electron stub) being loaded instead of browser-preload.browser.js, making window.Actual undefined. Changed to 'yarn start:browser' which properly sets IS_GENERIC_BROWSER=1 via the watch-browser script. * chore: update Playwright configuration and add blob-report to .gitignore - Modified Playwright config to use 'yarn start' with the correct working directory for local builds. - Added 'blob-report' to .gitignore to exclude it from version control. - Created release notes for running e2e tests against a local build instead of Netlify. * chore: update transaction test snapshots for split and transfer transactions - Updated binary snapshots for split and transfer test transactions in the e2e tests. - Ensured that the latest visual changes are reflected in the test suite for accurate regression testing. * chore: update transaction test snapshots for split and transfer transactions - Updated binary snapshots for split and transfer test transactions in the e2e tests to reflect recent changes. - Ensured visual consistency for accurate regression testing. * refactor: change test lifecycle hooks from beforeAll/afterAll to beforeEach/afterEach - Updated test files to use beforeEach and afterEach hooks for better isolation of tests. - This change ensures that each test starts with a fresh state, improving reliability and reducing side effects across tests. * chore: update e2e test workflow to disable translation downloads - Modified the e2e test workflow to include a new input parameter `download-translations` set to 'false' for the setup action. - This change aims to streamline the testing process by preventing unnecessary translation downloads during the test runs. * chore: update e2e test snapshots for settings page visuals - Updated binary snapshots for the settings page in e2e tests to reflect recent visual changes. - Ensured that the latest visual updates are accurately represented for regression testing. * fix: safely close page in e2e tests - Updated all e2e test files to use optional chaining when closing the page, ensuring that the close method is only called if the page is defined. - This change improves the robustness of the tests by preventing potential errors when the page object is not available.
This commit is contained in:
committed by
GitHub
parent
6fafc6371b
commit
af7bf534ba
11
.github/workflows/vrt-update-generate.yml
vendored
11
.github/workflows/vrt-update-generate.yml
vendored
@@ -51,18 +51,9 @@ jobs:
|
||||
run: |
|
||||
xvfb-run --auto-servernum --server-args="-screen 0 1920x1080x24" -- yarn e2e:desktop --update-snapshots
|
||||
|
||||
- name: Wait for Netlify build to finish
|
||||
id: netlify
|
||||
env:
|
||||
COMMIT_SHA: ${{ steps.pr.outputs.head_sha }}
|
||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
run: ./.github/actions/netlify-wait-for-build
|
||||
|
||||
- name: Run VRT Tests on Netlify URL
|
||||
- name: Run VRT Tests
|
||||
continue-on-error: true
|
||||
run: yarn vrt --update-snapshots
|
||||
env:
|
||||
E2E_START_URL: ${{ steps.netlify.outputs.url }}
|
||||
|
||||
- name: Create patch with PNG changes only
|
||||
id: create-patch
|
||||
|
||||
Reference in New Issue
Block a user