github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-21 15:36:50 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

🐛 fix menu not closing when menu item is clicked (#4716)

Browse Source
This commit is contained in:
Matiss Janis Aboltins
2025-03-31 18:15:17 +01:00
committed by GitHub
parent e04ca554e2
commit aef38f1679
7 changed files with 232 additions and 179 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/desktop-client/e2e/page-models/mobile-budget-page.ts
View File

@@ -180,7 +180,11 @@ export class MobileBudgetPage {
const categoryButton = await this.#getButtonForCategory(categoryName);
await categoryButton.click();
return new CategoryMenuModal(this.page.getByRole('dialog'));
return new CategoryMenuModal(
this.page.getByRole('dialog', {
name: 'Modal dialog',
}),
);
}
async #getButtonForCell(
@@ -222,7 +226,11 @@ export class MobileBudgetPage {
const budgetedButton = await this.getButtonForBudgeted(categoryName);
await budgetedButton.click();
return new BudgetMenuModal(this.page.getByRole('dialog'));
return new BudgetMenuModal(
this.page.getByRole('dialog', {
name: 'Modal dialog',
}),
);
}
async openSpentPage(categoryName: string) {
@@ -239,7 +247,11 @@ export class MobileBudgetPage {
if (await balanceButton.isVisible()) {
await balanceButton.click();
return new BalanceMenuModal(this.page.getByRole('dialog'));
return new BalanceMenuModal(
this.page.getByRole('dialog', {
name: 'Modal dialog',
}),
);
} else {
throw new Error(
`Balance button for category ${categoryName} not found or not visible.`,
@@ -324,7 +336,11 @@ export class MobileBudgetPage {
}
await budgetSummaryButton.click();
return new EnvelopeBudgetSummaryModal(this.page.getByRole('dialog'));
return new EnvelopeBudgetSummaryModal(
this.page.getByRole('dialog', {
name: 'Modal dialog',
}),
);
}
async #getButtonForTrackingBudgetSummary({
@@ -358,6 +374,10 @@ export class MobileBudgetPage {
}
await budgetSummaryButton.click();
return new TrackingBudgetSummaryModal(this.page.getByRole('dialog'));
return new TrackingBudgetSummaryModal(
this.page.getByRole('dialog', {
name: 'Modal dialog',
}),
);
}
}

6
packages/desktop-client/e2e/page-models/mobile-category-menu-modal.ts
View File

@@ -25,6 +25,10 @@ export class CategoryMenuModal {
async editNotes() {
await this.editNotesButton.click();
return new EditNotesModal(this.page.getByRole('dialog'));
return new EditNotesModal(
this.page.getByRole('dialog', {
name: 'Modal dialog',
}),
);
}
}