github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-04-30 10:14:53 -05:00
Code Issues 1.3k Packages Projects Releases 54 Wiki Activity

fix: Sabadell Bank regression, missing date field during normalization (#474)

Browse Source 
* fix: Sabadell Bank regression, missing date field during normalization

* release notes
This commit is contained in:
David Martos
2024-10-12 18:27:36 +02:00
committed by GitHub
parent 290c6f646f
commit a8c4c5fa23
3 changed files with 25 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/app-gocardless/banks/bancsabadell-bsabesbbb.js
View File

@@ -31,6 +31,7 @@ export default {
return { return {
...transaction, ...transaction,
payeeName: formatPayeeName(transaction), payeeName: formatPayeeName(transaction),
date: transaction.bookingDate || transaction.valueDate,
}; };
}, },
}; };

18
src/app-gocardless/banks/tests/bancsabadell-bsabesbbb.spec.js
View File

@@ -9,6 +9,7 @@ describe('BancSabadell', () => {
remittanceInformationUnstructuredArray: ['some-creditor-name'], remittanceInformationUnstructuredArray: ['some-creditor-name'],
internalTransactionId: 'd7dca139cf31d9', internalTransactionId: 'd7dca139cf31d9',
transactionId: '04704109322', transactionId: '04704109322',
bookingDate: '2022-05-01',
}; };
const normalizedTransaction = Sabadell.normalizeTransaction( const normalizedTransaction = Sabadell.normalizeTransaction(
transaction, transaction,
@@ -26,6 +27,7 @@ describe('BancSabadell', () => {
remittanceInformationUnstructuredArray: ['some-debtor-name'], remittanceInformationUnstructuredArray: ['some-debtor-name'],
internalTransactionId: 'd7dca139cf31d9', internalTransactionId: 'd7dca139cf31d9',
transactionId: '04704109322', transactionId: '04704109322',
bookingDate: '2022-05-01',
}; };
const normalizedTransaction = Sabadell.normalizeTransaction( const normalizedTransaction = Sabadell.normalizeTransaction(
transaction, transaction,
@@ -35,5 +37,21 @@ describe('BancSabadell', () => {
expect(normalizedTransaction.creditorName).toEqual(null); expect(normalizedTransaction.creditorName).toEqual(null);
}); });
}); });
it('extract date', () => {
const transaction = {
transactionAmount: { amount: '-100', currency: 'EUR' },
remittanceInformationUnstructuredArray: ['some-creditor-name'],
internalTransactionId: 'd7dca139cf31d9',
transactionId: '04704109322',
bookingDate: '2024-10-02',
valueDate: '2024-10-05',
};
const normalizedTransaction = Sabadell.normalizeTransaction(
transaction,
true,
);
expect(normalizedTransaction.date).toEqual('2024-10-02');
});
}); });
}); });

6
upcoming-release-notes/474.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [davidmartos96]
---
Fixes Sabadell Bank regression, by including the date field during normalization