github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-04-30 10:14:53 -05:00
Code Issues 1.3k Packages Projects Releases 54 Wiki Activity

Stream file without loading to memory in /download-user-file (#172)

Browse Source
This commit is contained in:
Jakub Kuczys
2023-03-28 22:05:31 +02:00
committed by GitHub
parent 7713848067
commit 9b2d74c3ad
3 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/app-sync.js
View File

@@ -313,17 +313,8 @@ app.get('/download-user-file', async (req, res) => {
return; return;
} }
let buffer;
try {
buffer = await fs.readFile(getPathForUserFile(fileId));
} catch (e) {
console.log(`Error: file does not exist: ${getPathForUserFile(fileId)}`);
res.status(500).send('File does not exist on server');
return;
}
res.setHeader('Content-Disposition', `attachment;filename=${fileId}`); res.setHeader('Content-Disposition', `attachment;filename=${fileId}`);
res.send(buffer); res.sendFile(getPathForUserFile(fileId));
}); });
app.post('/update-user-filename', (req, res) => { app.post('/update-user-filename', (req, res) => {

2
src/app-sync.test.js
View File

@@ -50,7 +50,7 @@ describe('/download-user-file', () => {
.set('x-actual-token', 'valid-token') .set('x-actual-token', 'valid-token')
.set('x-actual-file-id', 'missing-fs-file'); .set('x-actual-file-id', 'missing-fs-file');
expect(res.statusCode).toEqual(500); expect(res.statusCode).toEqual(404);
}); });
it('returns an attachment file', async () => { it('returns an attachment file', async () => {

6
upcoming-release-notes/172.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Enhancements
authors: [Jackenmen]
---
Changed budget file download endpoint to use less memory by using streams