github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-04-30 18:20:24 -05:00
Code Issues 1.4k Packages Projects Releases 54 Wiki Activity

Use isPending instead of isFetching

Browse Source
This commit is contained in:
Joel Jeremy Marquez
2026-01-26 09:27:44 -08:00
parent d9a18d03ee
commit 98a758c1b4
9 changed files with 20 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/desktop-client/src/components/accounts/Balance.tsx
View File

@@ -94,9 +94,9 @@ function SelectedBalance({ selectedItems, account }: SelectedBalanceProps) {
let scheduleBalance = 0; let scheduleBalance = 0;
const { data: schedules = [], isFetching } = useCachedSchedules(); const { data: schedules = [], isPending } = useCachedSchedules();
if (isFetching) { if (isPending) {
return null; return null;
} }

6
packages/desktop-client/src/components/mobile/schedules/MobileSchedulesPage.tsx
View File

@@ -39,9 +39,9 @@ export function MobileSchedulesPage() {
const format = useFormat(); const format = useFormat();
const dateFormat = useDateFormat() || 'MM/dd/yyyy'; const dateFormat = useDateFormat() || 'MM/dd/yyyy';
const { isFetching: isSchedulesLoading, data: schedules = [] } = useSchedules( const { isPending: isSchedulesLoading, data: schedules = [] } = useSchedules({
{ query: q('schedules').select('*') }, query: q('schedules').select('*'),
); });
const { data: { statusLookup = {} } = {} } = useScheduleStatus({ schedules }); const { data: { statusLookup = {} } = {} } = useScheduleStatus({ schedules });
const payees = usePayees(); const payees = usePayees();

2
packages/desktop-client/src/components/mobile/transactions/TransactionListItem.tsx
View File

@@ -315,7 +315,7 @@ type PayeeIconsProps = {
function PayeeIcons({ transaction, transferAccount }: PayeeIconsProps) { function PayeeIcons({ transaction, transferAccount }: PayeeIconsProps) {
const { id, schedule: scheduleId } = transaction; const { id, schedule: scheduleId } = transaction;
const { isFetching: isSchedulesLoading, data: schedules = [] } = const { isPending: isSchedulesLoading, data: schedules = [] } =
useCachedSchedules(); useCachedSchedules();
const isPreview = isPreviewId(id); const isPreview = isPreviewId(id);
const schedule = schedules.find(s => s.id === scheduleId); const schedule = schedules.find(s => s.id === scheduleId);

8
packages/desktop-client/src/components/modals/ScheduledTransactionMenuModal.tsx
View File

@@ -44,11 +44,9 @@ export function ScheduledTransactionMenuModal({
borderTop: `1px solid ${theme.pillBorder}`, borderTop: `1px solid ${theme.pillBorder}`,
}; };
const scheduleId = transactionId?.split('/')?.[1]; const scheduleId = transactionId?.split('/')?.[1];
const { isFetching: isSchedulesLoading, data: schedules = [] } = useSchedules( const { isPending: isSchedulesLoading, data: schedules = [] } = useSchedules({
{ query: q('schedules').filter({ id: scheduleId }).select('*'),
query: q('schedules').filter({ id: scheduleId }).select('*'), });
},
);
if (isSchedulesLoading) { if (isSchedulesLoading) {
return null; return null;

6
packages/desktop-client/src/components/rules/RuleEditor.tsx
View File

@@ -363,9 +363,9 @@ function ScheduleDescription({ id }) {
const { isNarrowWidth } = useResponsive(); const { isNarrowWidth } = useResponsive();
const dateFormat = useDateFormat() || 'MM/dd/yyyy'; const dateFormat = useDateFormat() || 'MM/dd/yyyy';
const format = useFormat(); const format = useFormat();
const { data: schedules = [], isFetching: isSchedulesLoading } = useSchedules( const { data: schedules = [], isPending: isSchedulesLoading } = useSchedules({
{ query: q('schedules').filter({ id }).select('*') }, query: q('schedules').filter({ id }).select('*'),
); });
const { const {
data: { statusLookup = {} }, data: { statusLookup = {} },

4
packages/desktop-client/src/components/rules/ScheduleValue.tsx
View File

@@ -22,11 +22,11 @@ export function ScheduleValue({ value }: ScheduleValueProps) {
const { t } = useTranslation(); const { t } = useTranslation();
const payees = usePayees(); const payees = usePayees();
const byId = getPayeesById(payees); const byId = getPayeesById(payees);
const { data: schedules = [], isFetching } = useSchedules({ const { data: schedules = [], isPending } = useSchedules({
query: q('schedules').select('*'), query: q('schedules').select('*'),
}); });
if (isFetching) { if (isPending) {
return ( return (
<View aria-label={t('Loading...')} style={{ display: 'inline-flex' }}> <View aria-label={t('Loading...')} style={{ display: 'inline-flex' }}>
<AnimatedLoading width={10} height={10} /> <AnimatedLoading width={10} height={10} />

8
packages/desktop-client/src/components/schedules/ScheduleLink.tsx
View File

@@ -41,11 +41,9 @@ export function ScheduleLink({
const dispatch = useDispatch(); const dispatch = useDispatch();
const [filter, setFilter] = useState(accountName || ''); const [filter, setFilter] = useState(accountName || '');
const { isFetching: isSchedulesLoading, data: schedules = [] } = useSchedules( const { isPending: isSchedulesLoading, data: schedules = [] } = useSchedules({
{ query: q('schedules').filter({ completed: false }).select('*'),
query: q('schedules').filter({ completed: false }).select('*'), });
},
);
const { const {
data: { statusLookup = {} }, data: { statusLookup = {} },

4
packages/desktop-client/src/components/transactions/TransactionsTable.tsx
View File

@@ -764,9 +764,9 @@ function PayeeIcons({
const { t } = useTranslation(); const { t } = useTranslation();
const scheduleId = transaction.schedule; const scheduleId = transaction.schedule;
const { isFetching, data: schedules = [] } = useCachedSchedules(); const { isPending, data: schedules = [] } = useCachedSchedules();
if (isFetching) { if (isPending) {
return null; return null;
} }

2
packages/desktop-client/src/hooks/usePreviewTransactions.ts
View File

@@ -41,7 +41,7 @@ export function usePreviewTransactions({
TransactionEntity[] TransactionEntity[]
>([]); >([]);
const { const {
isFetching: isSchedulesLoading, isPending: isSchedulesLoading,
error: scheduleQueryError, error: scheduleQueryError,
data: schedules = [], data: schedules = [],
} = useCachedSchedules(); } = useCachedSchedules();