Rename "Nest egg" to "Life Savings" in crossover report graph (#6425)

I'm not sure how widely-understood the term "nest egg" is,
so use a more general term like "life savings". Also, for
projected future amounts, the tooltip already contains the word
"(projected)" to indicate that this is a future value, so we don't
need the word 'target' here, which I find a bit confusing. See
https://github.com/actualbudget/actual/pull/6384#issuecomment-3649921717
for more discussion.

Signed-off-by: Jonathon Jongsma <jonathon@quotidian.org>

packages/desktop-client/src/components/reports/graphs/CrossoverGraph.tsx

@@ -127,11 +127,7 @@ export function CrossoverGraph({
                 })}
               >
                 <div>
-                  {payload[0].payload.isProjection ? (
+                  <Trans>Life savings:</Trans>
-                    <Trans>Target Nest Egg:</Trans>
-                  ) : (
-                    <Trans>Nest Egg:</Trans>
-                  )}
                 </div>
                 <div>{format(payload[0].payload.nestEgg, 'financial')}</div>
               </View>

packages/desktop-client/src/components/reports/reports/Crossover.tsx

@@ -858,7 +858,7 @@ function CrossoverInner({ widget }: CrossoverInnerProps) {
                 }}
               >
                 <span>
-                  <Trans>Target Nest Egg</Trans>:{' '}
+                  <Trans>Target Life Savings</Trans>:{' '}
                   <PrivacyFilter>
                     {targetNestEgg != null && !isNaN(targetNestEgg)
                       ? format(targetNestEgg, 'financial')

upcoming-release-notes/6425.md

@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [jonner]
+---
+
+Rename "Nest egg" to "Life Savings" in crossover report graph