github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-21 15:36:50 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

Fix null context crash in tracking budget mode (#6538)

Browse Source 
* Initial plan

* Fix fatal error by adding default values to TrackingBudgetContext

The TrackingBudgetContext was initialized with null, causing a fatal error when components tried to destructure properties like currentMonth. This fix adds proper default values and type definitions, matching the pattern used in EnvelopeBudgetContext.

Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>

* Add release notes for issue #6538

Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
This commit is contained in:
Copilot
2026-01-05 23:58:54 +01:00
committed by GitHub
parent 7f3aa3a2b5
commit 64db9a59f4
2 changed files with 31 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
packages/desktop-client/src/components/budget/tracking/TrackingBudgetContext.tsx
View File

@@ -1,14 +1,31 @@
// @ts-strict-ignore
import React, { type ReactNode, createContext, useContext } from 'react';
import * as monthUtils from 'loot-core/shared/months';
const Context = createContext(null);
type TrackingBudgetProviderProps = {
type TrackingBudgetContextDefinition = {
summaryCollapsed: boolean;
onBudgetAction: (month: string, action: string, arg: unknown) => void;
onBudgetAction: (month: string, action: string, arg?: unknown) => void;
onToggleSummaryCollapse: () => void;
currentMonth: string;
};
const TrackingBudgetContext = createContext<TrackingBudgetContextDefinition>({
summaryCollapsed: false,
onBudgetAction: () => {
throw new Error('Unitialised context method called: onBudgetAction');
},
onToggleSummaryCollapse: () => {
throw new Error(
'Unitialised context method called: onToggleSummaryCollapse',
);
},
currentMonth: 'unknown',
});
type TrackingBudgetProviderProps = Omit<
TrackingBudgetContextDefinition,
'currentMonth'
> & {
children: ReactNode;
};
export function TrackingBudgetProvider({
@@ -20,7 +37,7 @@ export function TrackingBudgetProvider({
const currentMonth = monthUtils.currentMonth();
return (
<Context.Provider
<TrackingBudgetContext.Provider
value={{
currentMonth,
summaryCollapsed,
@@ -29,10 +46,10 @@ export function TrackingBudgetProvider({
}}
>
{children}
</Context.Provider>
</TrackingBudgetContext.Provider>
);
}
export function useTrackingBudget() {
return useContext(Context);
return useContext(TrackingBudgetContext);
}