♻️ removal of '.testing.ts' file extensions in favour of mocks (#4632)

packages/api/jest.config.js

@@ -1,7 +1,5 @@
 module.exports = {
   moduleFileExtensions: [
-    'testing.js',
-    'testing.ts',
     'api.js',
     'api.ts',
     'api.tsx',

packages/loot-core/jest.config.js

@@ -1,7 +1,5 @@
 module.exports = {
   moduleFileExtensions: [
-    'testing.js',
-    'testing.ts',
     'electron.js',
     'electron.ts',
     'mjs',

packages/loot-core/jest.web.config.js

@@ -1,7 +1,5 @@
 module.exports = {
   moduleFileExtensions: [
-    'testing.js',
-    'testing.ts',
     'web.js',
     'web.ts',
     'web.tsx',

packages/loot-core/src/mocks/setup.ts

@@ -15,7 +15,10 @@ import * as rules from '../server/transactions/transaction-rules';
 import { updateVersion } from '../server/update';
 import { resetTracer, tracer } from '../shared/test-helpers';
 
+jest.mock('../platform/client/fetch');
 jest.mock('../platform/exceptions');
+jest.mock('../platform/server/asyncStorage');
+jest.mock('../platform/server/connection');
 jest.mock('../server/post');
 
 // By default, syncing is disabled

packages/loot-core/src/platform/client/fetch/__mocks__/index.ts

@@ -1,5 +1,5 @@
 // @ts-strict-ignore
-import type * as T from '..';
+import type * as T from '../index.d';
 
 let listeners = new Map();
 let serverHandler = null;

packages/loot-core/src/platform/client/fetch/index.browser.ts

@@ -5,7 +5,7 @@ import { v4 as uuidv4 } from 'uuid';
 import { captureException, captureBreadcrumb } from '../../exceptions';
 import * as undo from '../undo';
 
-import type * as T from '.';
+import type * as T from './index.d';
 
 const replyHandlers = new Map();
 const listeners = new Map();
@@ -199,6 +199,6 @@ export const unlisten: T.Unlisten = function (name) {
   listeners.set(name, []);
 };
 
-export const clearServer: T.ClearServer = async function () {
-  //
-};
+export const initServer: T.InitServer = async function () {};
+export const serverPush: T.ServerPush = async function () {};
+export const clearServer: T.ClearServer = async function () {};

packages/loot-core/src/platform/client/fetch/index.testing.ts

@@ -1,2 +0,0 @@
-// eslint-disable-next-line no-restricted-imports
-export * from './__mocks__/index.web';

packages/loot-core/src/platform/client/fetch/index.ts

@@ -3,7 +3,7 @@ import { v4 as uuidv4 } from 'uuid';
 
 import * as undo from '../undo';
 
-import type * as T from '.';
+import type * as T from './index.d';
 
 const replyHandlers = new Map();
 const listeners = new Map();
@@ -145,3 +145,5 @@ export const clearServer: T.ClearServer = async function () {
     return new Promise(closeSocket);
   }
 };
+export const initServer: T.InitServer = async function () {};
+export const serverPush: T.ServerPush = async function () {};

packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts

@@ -1,7 +1,6 @@
 // @ts-strict-ignore
-import { GlobalPrefsJson } from '../../../types/prefs';
-
-import * as T from '.';
+import { GlobalPrefsJson } from '../../../../types/prefs';
+import * as T from '../index.d';
 
 const store: GlobalPrefsJson = {};
 

packages/loot-core/src/platform/server/asyncStorage/index.electron.ts

@@ -5,7 +5,7 @@ import { join } from 'path';
 import { GlobalPrefsJson } from '../../../types/prefs';
 import * as lootFs from '../fs';
 
-import * as T from '.';
+import * as T from './index.d';
 
 const getStorePath = () => join(lootFs.getDataDir(), 'global-store.json');
 let store: GlobalPrefsJson;

packages/loot-core/src/platform/server/asyncStorage/index.ts

@@ -2,7 +2,7 @@
 import { GlobalPrefsJson } from '../../../types/prefs';
 import { getDatabase } from '../indexeddb';
 
-import * as T from '.';
+import * as T from './index.d';
 
 export const init: T.Init = function () {};
 

packages/loot-core/src/platform/server/connection/__mocks__/index.ts

@@ -1,5 +1,4 @@
-// @ts-strict-ignore
-import type * as T from '.';
+import type * as T from '../index.d';
 
 let events = [];
 
@@ -9,10 +8,6 @@ export const send: T.Send = function (type, args) {
   events.push([type, args]);
 };
 
-export const getEvents: T.GetEvents = function () {
-  return events;
-};
-
 export const resetEvents: T.ResetEvents = function () {
   events = [];
 };

packages/loot-core/src/platform/server/connection/index.api.ts

@@ -1,4 +1,4 @@
-import type * as T from '.';
+import type * as T from './index.d';
 
 export const init: T.Init = function () {};
 

packages/loot-core/src/platform/server/connection/index.d.ts

@@ -13,9 +13,6 @@ export function send<K extends keyof ServerEvents>(
 ): void;
 export type Send = typeof send;
 
-export function getEvents(): unknown[];
-export type GetEvents = typeof getEvents;
-
 export function getNumClients(): number;
 export type GetNumClients = typeof getNumClients;
 

packages/loot-core/src/platform/server/connection/index.electron.ts

@@ -3,7 +3,7 @@ import { APIError } from '../../../server/errors';
 import { runHandler, isMutating } from '../../../server/mutators';
 import { captureException } from '../../exceptions';
 
-import type * as T from '.';
+import type * as T from './index.d';
 
 function coerceError(error) {
   if (error.type && error.type === 'APIError') {
@@ -84,3 +84,5 @@ export const getNumClients: T.GetNumClients = function () {
 export const send: T.Send = function (name, args) {
   process.parentPort.postMessage({ type: 'push', name, args });
 };
+
+export const resetEvents: T.ResetEvents = function () {};

packages/loot-core/src/platform/server/connection/index.ts

@@ -3,7 +3,7 @@ import { APIError } from '../../../server/errors';
 import { runHandler, isMutating } from '../../../server/mutators';
 import { captureException } from '../../exceptions';
 
-import type * as T from '.';
+import type * as T from './index.d';
 
 function getGlobalObject() {
   const obj =
@@ -135,3 +135,5 @@ export const send: T.Send = function (name, args) {
 export const getNumClients = function () {
   return 1;
 };
+
+export const resetEvents: T.ResetEvents = function () {};

packages/loot-core/src/platform/server/fetch/index.d.ts

@@ -1,4 +0,0 @@
-export function fetch(
-  input: RequestInfo | URL,
-  options?: unknown,
-): Promise<Response>;

packages/loot-core/src/server/cloud-storage.ts

@@ -304,7 +304,9 @@ export async function upload() {
           ? { 'X-ACTUAL-ENCRYPT-META': JSON.stringify(uploadMeta) }
           : null),
         ...(groupId ? { 'X-ACTUAL-GROUP-ID': groupId } : null),
-      },
+        // TODO: fix me
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      } as any,
       body: uploadContent,
     });
   } catch (err) {