From 5e8a24f283c861b71df1782b280fd62d4730a897 Mon Sep 17 00:00:00 2001 From: "Thiago Rodrigues (xthiago)" Date: Sat, 18 Jan 2025 16:54:05 -0300 Subject: [PATCH] ensure GitHub name is used correctly across the project (#4187) It follows the official trademark style[1]. [1] https://docs.github.com/en/site-policy/content-removal-policies/github-trademark-policy --- .github/ISSUE_TEMPLATE/bug-report.yml | 2 +- .../src/components/manager/subscribe/OpenIdForm.tsx | 4 ++-- .../src/components/modals/manager/ImportActualModal.tsx | 2 +- .../src/components/modals/manager/ImportModal.tsx | 2 +- .../src/components/modals/manager/ImportYNAB4Modal.tsx | 2 +- .../src/components/modals/manager/ImportYNAB5Modal.tsx | 2 +- packages/desktop-client/src/components/settings/Export.tsx | 2 +- packages/desktop-client/src/util/versions.ts | 2 +- packages/loot-core/src/client/actions/notifications.ts | 2 +- packages/loot-core/src/client/shared-listeners.ts | 4 ++-- upcoming-release-notes/4187.md | 6 ++++++ 11 files changed, 18 insertions(+), 12 deletions(-) create mode 100644 upcoming-release-notes/4187.md diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index c61a9eedf2..c3d9061629 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -12,7 +12,7 @@ body: id: intro-md attributes: value: | - **IMPORTANT:** we use Github Issues only for BUG REPORTS and FEATURE REQUESTS. If you are looking for help/support - please reach out to the [community on Discord](https://discord.gg/pRYNYr4W5A). All non-bug and non-feature-request issues will be closed. + **IMPORTANT:** we use GitHub Issues only for BUG REPORTS and FEATURE REQUESTS. If you are looking for help/support - please reach out to the [community on Discord](https://discord.gg/pRYNYr4W5A). All non-bug and non-feature-request issues will be closed. **Bank-sync problems (SimpleFin / GoCardless)?** Reach out via the [community Discord](https://discord.gg/pRYNYr4W5A) first and open an issue only if the community deems the issue to be a legitimate bug in Actual. - type: checkboxes diff --git a/packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx b/packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx index 7a6208eb07..238f5319a1 100644 --- a/packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx +++ b/packages/desktop-client/src/components/manager/subscribe/OpenIdForm.tsx @@ -337,7 +337,7 @@ const openIdProviders: (OpenIdProviderOption | typeof Menu.line)[] = [ ), }, { - label: 'Github', + label: 'GitHub', value: 'github', clientIdRequired: true, clientSecretRequired: true, @@ -348,7 +348,7 @@ const openIdProviders: (OpenIdProviderOption | typeof Menu.line)[] = [ <> - Github does not support discovery. You need to configure it in the + GitHub does not support discovery. You need to configure it in the server. {' '} diff --git a/packages/desktop-client/src/components/modals/manager/ImportActualModal.tsx b/packages/desktop-client/src/components/modals/manager/ImportActualModal.tsx index 995154b13e..2db879abbc 100644 --- a/packages/desktop-client/src/components/modals/manager/ImportActualModal.tsx +++ b/packages/desktop-client/src/components/modals/manager/ImportActualModal.tsx @@ -26,7 +26,7 @@ function getErrorMessage(error: string): string { case 'invalid-metadata-file': return 'The metadata file in the given archive is corrupted.'; default: - return 'An unknown error occurred while importing. Please report this as a new issue on Github.'; + return 'An unknown error occurred while importing. Please report this as a new issue on GitHub.'; } } diff --git a/packages/desktop-client/src/components/modals/manager/ImportModal.tsx b/packages/desktop-client/src/components/modals/manager/ImportModal.tsx index ef4d1824f0..e38c1990ca 100644 --- a/packages/desktop-client/src/components/modals/manager/ImportModal.tsx +++ b/packages/desktop-client/src/components/modals/manager/ImportModal.tsx @@ -16,7 +16,7 @@ function getErrorMessage(error: 'not-ynab4' | boolean) { case 'not-ynab4': return 'This file is not valid. Please select a .ynab4 file'; default: - return 'An unknown error occurred while importing. Please report this as a new issue on Github.'; + return 'An unknown error occurred while importing. Please report this as a new issue on GitHub.'; } } diff --git a/packages/desktop-client/src/components/modals/manager/ImportYNAB4Modal.tsx b/packages/desktop-client/src/components/modals/manager/ImportYNAB4Modal.tsx index 49a80721bf..401bce1cf1 100644 --- a/packages/desktop-client/src/components/modals/manager/ImportYNAB4Modal.tsx +++ b/packages/desktop-client/src/components/modals/manager/ImportYNAB4Modal.tsx @@ -18,7 +18,7 @@ function getErrorMessage(error: string): string { case 'not-ynab4': return 'This file is not valid. Please select a compressed ynab4 zip file.'; default: - return 'An unknown error occurred while importing. Please report this as a new issue on Github.'; + return 'An unknown error occurred while importing. Please report this as a new issue on GitHub.'; } } diff --git a/packages/desktop-client/src/components/modals/manager/ImportYNAB5Modal.tsx b/packages/desktop-client/src/components/modals/manager/ImportYNAB5Modal.tsx index 8945278e80..a8545a2ec3 100644 --- a/packages/desktop-client/src/components/modals/manager/ImportYNAB5Modal.tsx +++ b/packages/desktop-client/src/components/modals/manager/ImportYNAB5Modal.tsx @@ -21,7 +21,7 @@ function getErrorMessage(error: string): string { case 'not-ynab5': return 'This file is not valid. Please select a JSON file exported from nYNAB.'; default: - return 'An unknown error occurred while importing. Please report this as a new issue on Github.'; + return 'An unknown error occurred while importing. Please report this as a new issue on GitHub.'; } } diff --git a/packages/desktop-client/src/components/settings/Export.tsx b/packages/desktop-client/src/components/settings/Export.tsx index 393752a7b2..1b437801fc 100644 --- a/packages/desktop-client/src/components/settings/Export.tsx +++ b/packages/desktop-client/src/components/settings/Export.tsx @@ -51,7 +51,7 @@ export function ExportBudget() { {error && ( {t( - 'An unknown error occurred while exporting. Please report this as a new issue on Github.', + 'An unknown error occurred while exporting. Please report this as a new issue on GitHub.', )} )} diff --git a/packages/desktop-client/src/util/versions.ts b/packages/desktop-client/src/util/versions.ts index 09427e15f2..18a9b74fc9 100644 --- a/packages/desktop-client/src/util/versions.ts +++ b/packages/desktop-client/src/util/versions.ts @@ -35,7 +35,7 @@ export async function getLatestVersion(): Promise { return tags[tags.length - 1]; } catch { - // Rate limit exceeded? Or perhaps Github is down? + // Rate limit exceeded? Or perhaps GitHub is down? return 'unknown'; } } diff --git a/packages/loot-core/src/client/actions/notifications.ts b/packages/loot-core/src/client/actions/notifications.ts index 9c02215480..2988ae464d 100644 --- a/packages/loot-core/src/client/actions/notifications.ts +++ b/packages/loot-core/src/client/actions/notifications.ts @@ -26,7 +26,7 @@ export function addGenericErrorNotification() { type: 'error', message: t( 'Something internally went wrong. You may want to restart the app if anything looks wrong. ' + - 'Please report this as a new issue on Github.', + 'Please report this as a new issue on GitHub.', ), }); } diff --git a/packages/loot-core/src/client/shared-listeners.ts b/packages/loot-core/src/client/shared-listeners.ts index 06ea0ab453..82c07a5763 100644 --- a/packages/loot-core/src/client/shared-listeners.ts +++ b/packages/loot-core/src/client/shared-listeners.ts @@ -284,7 +284,7 @@ export function listenForSyncEvent(store: AppStore) { console.trace('apply-failure', event.meta); notif = { message: t( - 'We couldn’t apply that change to the database. Please report this as a bug by [opening a Github issue]({{githubIssueLink}}).', + 'We couldn’t apply that change to the database. Please report this as a bug by [opening a GitHub issue]({{githubIssueLink}}).', { githubIssueLink }, ), }; @@ -308,7 +308,7 @@ export function listenForSyncEvent(store: AppStore) { console.trace('unknown error', event); notif = { message: t( - 'We had problems syncing your changes. Please report this as a bug by [opening a Github issue]({{githubIssueLink}}).', + 'We had problems syncing your changes. Please report this as a bug by [opening a GitHub issue]({{githubIssueLink}}).', { githubIssueLink }, ), }; diff --git a/upcoming-release-notes/4187.md b/upcoming-release-notes/4187.md new file mode 100644 index 0000000000..b3e5539393 --- /dev/null +++ b/upcoming-release-notes/4187.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [xthiago] +--- + +Ensure 'GitHub' name is used correctly across the project, following the official style.