From 586a26968ce7e9c0f755e1f92167fa64ad5588e6 Mon Sep 17 00:00:00 2001 From: Joel Jeremy Marquez Date: Thu, 21 Mar 2024 13:36:59 -0700 Subject: [PATCH] Force async onRefresh on PullToRefresh component (#2487) * Force async onRefresh * Release notes --- .../desktop-client/src/components/mobile/PullToRefresh.tsx | 4 ++++ upcoming-release-notes/2487.md | 6 ++++++ 2 files changed, 10 insertions(+) create mode 100644 upcoming-release-notes/2487.md diff --git a/packages/desktop-client/src/components/mobile/PullToRefresh.tsx b/packages/desktop-client/src/components/mobile/PullToRefresh.tsx index 20f4df91a6..7838d190c0 100644 --- a/packages/desktop-client/src/components/mobile/PullToRefresh.tsx +++ b/packages/desktop-client/src/components/mobile/PullToRefresh.tsx @@ -22,6 +22,10 @@ export function PullToRefresh(props: PullToRefreshProps) { }), )} {...props} + // Force async because the library errors out when a sync onRefresh method is provided. + onRefresh={async () => { + await props.onRefresh?.(); + }} /> ); diff --git a/upcoming-release-notes/2487.md b/upcoming-release-notes/2487.md new file mode 100644 index 0000000000..13ada7ab54 --- /dev/null +++ b/upcoming-release-notes/2487.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [joel-jeremy] +--- + +Fix mobile accounts page pull to refresh functionality