Fix version bump logic to work if the month has rolled over (#5662)

* Fix version bump logic to work if the month has rolled over

* Refactor script to be more testable

* Add tests for regression

* Move tests to dedicated package

* Add release notes

* Coderabbit

.github/actions/get-next-package-version.js

@@ -1,117 +0,0 @@
-#!/usr/bin/env node
-
-// This script is used in GitHub Actions to get the next version based on the current package.json version.
-// It supports three types of versioning: nightly, hotfix, and monthly.
-
-const { parseArgs } = require('node:util');
-const fs = require('node:fs');
-
-const args = process.argv;
-
-const options = {
-  'package-json': {
-    type: 'string',
-    short: 'p',
-  },
-  type: {
-    type: 'string', // nightly, hotfix, monthly, auto
-    short: 't',
-  },
-  update: {
-    type: 'boolean',
-    short: 'u',
-    default: false,
-  },
-};
-
-const { values } = parseArgs({
-  args,
-  options,
-  allowPositionals: true,
-});
-
-if (!values['package-json']) {
-  console.error(
-    'Please specify the path to package.json using --package-json or -p option.',
-  );
-  process.exit(1);
-}
-
-try {
-  const packageJsonPath = values['package-json'];
-
-  // Read and parse package.json
-  const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
-  const currentVersion = packageJson.version;
-
-  // Parse year and month from version (e.g. 25.5.1 -> year=2025, month=5)
-  const versionParts = currentVersion.split('.');
-  const versionYear = parseInt(versionParts[0]);
-  const versionMonth = parseInt(versionParts[1]);
-  const versionHotfix = parseInt(versionParts[2]);
-
-  // Create date and add 1 month
-  const versionDate = new Date(2000 + versionYear, versionMonth - 1, 1); // month is 0-indexed
-  const nextVersionMonthDate = new Date(
-    versionDate.getFullYear(),
-    versionDate.getMonth() + 1,
-    1,
-  );
-
-  // Format back to YY.M format
-  const nextVersionYear = nextVersionMonthDate
-    .getFullYear()
-    .toString()
-    .slice(nextVersionMonthDate.getFullYear() < 2100 ? -2 : -3);
-  const nextVersionMonth = nextVersionMonthDate.getMonth() + 1; // Convert back to 1-indexed
-
-  // Get current date string
-  const currentDate = new Date();
-  const currentDateString = currentDate
-    .toISOString()
-    .split('T')[0]
-    .replaceAll('-', '');
-
-  if (values.type === 'auto') {
-    if (currentDate.getDate() <= 25) {
-      values.type = 'hotfix';
-    } else {
-      values.type = 'monthly';
-    }
-  }
-
-  let newVersion;
-  switch (values.type) {
-    case 'nightly': {
-      newVersion = `${nextVersionYear}.${nextVersionMonth}.0-nightly.${currentDateString}`;
-      break;
-    }
-    case 'hotfix': {
-      newVersion = `${versionYear}.${versionMonth}.${versionHotfix + 1}`;
-      break;
-    }
-    case 'monthly': {
-      newVersion = `${nextVersionYear}.${nextVersionMonth}.0`;
-      break;
-    }
-    default:
-      console.error(
-        'Invalid type specified. Use "auto", "nightly", "hotfix", or "monthly".',
-      );
-      process.exit(1);
-  }
-
-  process.stdout.write(newVersion); // return the new version to stdout
-
-  if (values.update) {
-    packageJson.version = newVersion;
-    fs.writeFileSync(
-      packageJsonPath,
-      JSON.stringify(packageJson, null, 2) + '\n',
-      'utf8',
-    );
-  }
-} catch (error) {
-  console.error('Error:', error.message);
-  process.exit(1);
-}

.github/workflows/generate-release-pr.yml

@@ -37,7 +37,7 @@ jobs:
             if [[ -n "${{ github.event.inputs.version }}" ]]; then
               version="${{ github.event.inputs.version }}"
             else
-              version=$(node ./.github/actions/get-next-package-version.js \
+              version=$(node ./packages/ci-actions/bin/get-next-package-version.js \
                 --package-json "./packages/$pkg/package.json" \
                 --type auto \
                 --update)

.github/workflows/publish-nightly-npm-packages.yml

@@ -20,9 +20,9 @@ jobs:
       - name: Update package versions
         run: |
           # Get new nightly versions
-          NEW_WEB_VERSION=$(node ./.github/actions/get-next-package-version.js --package-json ./packages/desktop-client/package.json --type nightly)
-          NEW_SYNC_VERSION=$(node ./.github/actions/get-next-package-version.js --package-json ./packages/sync-server/package.json --type nightly)
-          NEW_API_VERSION=$(node ./.github/actions/get-next-package-version.js --package-json ./packages/api/package.json --type nightly)
+          NEW_WEB_VERSION=$(node ./packages/ci-actions/bin/get-next-package-version.js --package-json ./packages/desktop-client/package.json --type nightly)
+          NEW_SYNC_VERSION=$(node ./packages/ci-actions/bin/get-next-package-version.js --package-json ./packages/sync-server/package.json --type nightly)
+          NEW_API_VERSION=$(node ./packages/ci-actions/bin/get-next-package-version.js --package-json ./packages/api/package.json --type nightly)
 
           # Set package versions
           npm version $NEW_WEB_VERSION --no-git-tag-version --workspace=@actual-app/web --no-workspaces-update