From 224d4458406141f203e301eb0b99f6313c189594 Mon Sep 17 00:00:00 2001 From: Michael Clark <5285928+MikesGlitch@users.noreply.github.com> Date: Fri, 15 Nov 2024 12:38:54 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20=20Fix=20parameter=20formatting?= =?UTF-8?q?=20issues=20(#3841)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix some errors in translation format * release notes --- .../components/modals/EnvelopeBudgetMonthMenuModal.tsx | 10 +++++----- .../components/modals/TrackingBudgetMonthMenuModal.tsx | 8 ++++---- packages/loot-core/src/shared/errors.ts | 6 +++--- upcoming-release-notes/3841.md | 6 ++++++ 4 files changed, 18 insertions(+), 12 deletions(-) create mode 100644 upcoming-release-notes/3841.md diff --git a/packages/desktop-client/src/components/modals/EnvelopeBudgetMonthMenuModal.tsx b/packages/desktop-client/src/components/modals/EnvelopeBudgetMonthMenuModal.tsx index a113de8426..6e4cd4f62a 100644 --- a/packages/desktop-client/src/components/modals/EnvelopeBudgetMonthMenuModal.tsx +++ b/packages/desktop-client/src/components/modals/EnvelopeBudgetMonthMenuModal.tsx @@ -158,7 +158,7 @@ export function EnvelopeBudgetMonthMenuModal({ close(); showUndoNotification({ message: t( - '{displayMonth} budgets have all been set to last month’s budgeted amounts.', + '{{displayMonth}} budgets have all been set to last month’s budgeted amounts.', { displayMonth }, ), }); @@ -168,7 +168,7 @@ export function EnvelopeBudgetMonthMenuModal({ close(); showUndoNotification({ message: t( - '{displayMonth} budgets have all been set to zero.', + '{{displayMonth}} budgets have all been set to zero.', { displayMonth }, ), }); @@ -189,7 +189,7 @@ export function EnvelopeBudgetMonthMenuModal({ close(); showUndoNotification({ message: t( - '{displayMonth} budget templates have been applied.', + '{{displayMonth}} budget templates have been applied.', { displayMonth }, ), }); @@ -199,7 +199,7 @@ export function EnvelopeBudgetMonthMenuModal({ close(); showUndoNotification({ message: t( - '{displayMonth} budget templates have been overwritten.', + '{{displayMonth}} budget templates have been overwritten.', { displayMonth }, ), }); @@ -209,7 +209,7 @@ export function EnvelopeBudgetMonthMenuModal({ close(); showUndoNotification({ message: t( - '{displayMonth} end-of-month cleanup templates have been applied.', + '{{displayMonth}} end-of-month cleanup templates have been applied.', { displayMonth }, ), }); diff --git a/packages/desktop-client/src/components/modals/TrackingBudgetMonthMenuModal.tsx b/packages/desktop-client/src/components/modals/TrackingBudgetMonthMenuModal.tsx index 4120464e1b..a95c91389c 100644 --- a/packages/desktop-client/src/components/modals/TrackingBudgetMonthMenuModal.tsx +++ b/packages/desktop-client/src/components/modals/TrackingBudgetMonthMenuModal.tsx @@ -160,7 +160,7 @@ export function TrackingBudgetMonthMenuModal({ close(); showUndoNotification({ message: t( - '{displayMonth} budgets have all been set to last month’s budgeted amounts.', + '{{displayMonth}} budgets have all been set to last month’s budgeted amounts.', { displayMonth }, ), }); @@ -170,7 +170,7 @@ export function TrackingBudgetMonthMenuModal({ close(); showUndoNotification({ message: t( - '{displayMonth} budgets have all been set to zero.', + '{{displayMonth}} budgets have all been set to zero.', { displayMonth }, ), }); @@ -191,7 +191,7 @@ export function TrackingBudgetMonthMenuModal({ close(); showUndoNotification({ message: t( - '{displayMonth} budget templates have been applied.', + '{{displayMonth}} budget templates have been applied.', { displayMonth }, ), }); @@ -201,7 +201,7 @@ export function TrackingBudgetMonthMenuModal({ close(); showUndoNotification({ message: t( - '{displayMonth} budget templates have been overwritten.', + '{{displayMonth}} budget templates have been overwritten.', { displayMonth }, ), }); diff --git a/packages/loot-core/src/shared/errors.ts b/packages/loot-core/src/shared/errors.ts index d27d984e2f..0dffe54f22 100644 --- a/packages/loot-core/src/shared/errors.ts +++ b/packages/loot-core/src/shared/errors.ts @@ -34,7 +34,7 @@ export function getUploadError({ return t('Uploading the file failed. Check your network connection.'); default: return t( - 'An internal error occurred, sorry! Visit https://actualbudget.org/contact/ for support. (ref: {reason})', + 'An internal error occurred, sorry! Visit https://actualbudget.org/contact/ for support. (ref: {{reason}})', { reason }, ); } @@ -67,7 +67,7 @@ export function getDownloadError({ reason, meta, fileName }) { default: const info = meta && meta.fileId ? `, fileId: ${meta.fileId}` : ''; return t( - 'Something went wrong trying to download that file, sorry! Visit https://actualbudget.org/contact/ for support. reason: {reason}{info}', + 'Something went wrong trying to download that file, sorry! Visit https://actualbudget.org/contact/ for support. reason: {{reason}}{{info}}', { reason, info }, ); } @@ -105,7 +105,7 @@ export function getSyncError(error, id) { { id }, ); } else { - return t('We had an unknown problem opening “{id}”.', { id }); + return t('We had an unknown problem opening “{{id}}”.', { id }); } } diff --git a/upcoming-release-notes/3841.md b/upcoming-release-notes/3841.md new file mode 100644 index 0000000000..5d897fc304 --- /dev/null +++ b/upcoming-release-notes/3841.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [MikesGlitch] +--- + +Fix translations parameter formatting issues