From 1b4c4319e15c85db8212b6dbfd3d76f1d585317d Mon Sep 17 00:00:00 2001 From: Julian Dominguez-Schatz Date: Sat, 3 Aug 2024 11:05:30 -0400 Subject: [PATCH] Disable typography linter in tests (#3114) * Disable typography linter in tests * Add release notes * Remove unused type ignore --- .eslintrc.js | 13 ++++++++++++- packages/loot-core/src/server/aql/views.test.ts | 1 - upcoming-release-notes/3114.md | 6 ++++++ 3 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 upcoming-release-notes/3114.md diff --git a/.eslintrc.js b/.eslintrc.js index 95078706ff..1dc0b593b5 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -1,4 +1,3 @@ -/* eslint-disable rulesdir/typography */ const path = require('path'); const rulesDirPlugin = require('eslint-plugin-rulesdir'); @@ -332,6 +331,18 @@ module.exports = { 'react-hooks/exhaustive-deps': 'off', }, }, + { + files: [ + '.eslintrc.js', + '*.test.js', + '*.test.ts', + '*.test.jsx', + '*.test.tsx', + ], + rules: { + 'rulesdir/typography': 'off', + }, + }, ], settings: { 'import/resolver': { diff --git a/packages/loot-core/src/server/aql/views.test.ts b/packages/loot-core/src/server/aql/views.test.ts index 817f4c334c..69a4d9681f 100644 --- a/packages/loot-core/src/server/aql/views.test.ts +++ b/packages/loot-core/src/server/aql/views.test.ts @@ -30,7 +30,6 @@ const schemaConfig = { v_transactions2: (_, publicFields) => { const fields = publicFields({ - // eslint-disable-next-line rulesdir/typography transfer_id: 'COERCE(transfer_id, "foo")', }); diff --git a/upcoming-release-notes/3114.md b/upcoming-release-notes/3114.md new file mode 100644 index 0000000000..b77be48569 --- /dev/null +++ b/upcoming-release-notes/3114.md @@ -0,0 +1,6 @@ +--- +category: Maintenance +authors: [jfdoming] +--- + +Disable typography linter in tests