From 04f8140d26740b8f1e040b1677b9e32757b08ec7 Mon Sep 17 00:00:00 2001 From: Martin Michotte <55855805+MMichotte@users.noreply.github.com> Date: Sun, 16 Feb 2025 14:03:06 +0100 Subject: [PATCH] Add fallback value for payeename: 'undefined' - CBC Bank (#4384) * Add fallback value for payename: 'undefined' * docs: add release note * Add fallback value for payename: 'undefined' (for negative amounts) --- .../sync-server/src/app-gocardless/banks/cbc_cregbebb.js | 7 +++++-- upcoming-release-notes/4384.md | 6 ++++++ 2 files changed, 11 insertions(+), 2 deletions(-) create mode 100644 upcoming-release-notes/4384.md diff --git a/packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js b/packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js index 832d15cd49..013fe7f2dd 100644 --- a/packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js +++ b/packages/sync-server/src/app-gocardless/banks/cbc_cregbebb.js @@ -16,14 +16,17 @@ export default { if (Number(transaction.transactionAmount.amount) > 0) { editedTrans.payeeName = - transaction.debtorName || transaction.remittanceInformationUnstructured; + transaction.debtorName || + transaction.remittanceInformationUnstructured || + 'undefined'; } else { editedTrans.payeeName = transaction.creditorName || extractPayeeNameFromRemittanceInfo( transaction.remittanceInformationUnstructured, ['Paiement', 'Domiciliation', 'Transfert', 'Ordre permanent'], - ); + ) || + 'undefined'; } return Fallback.normalizeTransaction(transaction, booked, editedTrans); diff --git a/upcoming-release-notes/4384.md b/upcoming-release-notes/4384.md new file mode 100644 index 0000000000..f020cbf178 --- /dev/null +++ b/upcoming-release-notes/4384.md @@ -0,0 +1,6 @@ +--- +category: Bugfix +authors: [MMichotte] +--- + +Provides a default fallback payeename value ('undefined') for the CBC bank in case the payeename is missing.