From 2f86bafd1f4c65978bc7c589aa407a4ecbf6ab99 Mon Sep 17 00:00:00 2001
From: Joel Jeremy Marquez <joeljeremy.marquez@gmail.com>
Date: Thu, 5 Feb 2026 09:05:09 -0800
Subject: [PATCH] Fix react/exhaustive-deps in Modals (#6862)

* Fix react/exhaustive-deps in Modals

* Add release notes for PR #6862

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
---
 packages/desktop-client/src/components/Modals.tsx | 11 +++++++----
 upcoming-release-notes/6862.md                    |  6 ++++++
 2 files changed, 13 insertions(+), 4 deletions(-)
 create mode 100644 upcoming-release-notes/6862.md

diff --git a/packages/desktop-client/src/components/Modals.tsx b/packages/desktop-client/src/components/Modals.tsx
index 61d60ba62a..f3ba35003e 100644
--- a/packages/desktop-client/src/components/Modals.tsx
+++ b/packages/desktop-client/src/components/Modals.tsx
@@ -1,5 +1,5 @@
 // @ts-strict-ignore
-import React, { Fragment, useEffect } from 'react';
+import React, { Fragment, useEffect, useEffectEvent } from 'react';
 import { useLocation } from 'react-router';
 
 import { send } from 'loot-core/platform/client/fetch';
@@ -89,12 +89,15 @@ export function Modals() {
   const { modalStack } = useModalState();
   const [budgetId] = useMetadataPref('id');
 
-  useEffect(() => {
+  const onCloseModal = useEffectEvent(() => {
     if (modalStack.length > 0) {
       dispatch(closeModal());
     }
-    // oxlint-disable-next-line react/exhaustive-deps
-  }, [dispatch, location]);
+  });
+
+  useEffect(() => {
+    onCloseModal();
+  }, [location]);
 
   const modals = modalStack
     .map((modal, idx) => {
diff --git a/upcoming-release-notes/6862.md b/upcoming-release-notes/6862.md
new file mode 100644
index 0000000000..e24e9e9526
--- /dev/null
+++ b/upcoming-release-notes/6862.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [joel-jeremy]
+---
+
+Refactor modal closing behavior to improve code clarity and eliminate eslint disable patterns.